From: Ian Rogers <irogers@google.com>
To: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Ian Rogers <irogers@google.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Kan Liang <kan.liang@linux.intel.com>, Hao Ge <gehao@kylinos.cn>,
James Clark <james.clark@linaro.org>,
Howard Chu <howardchu95@gmail.com>,
Dominique Martinet <asmadeus@codewreck.org>,
Levi Yun <yeoreum.yun@arm.com>, Xu Yang <xu.yang_2@nxp.com>,
Tengda Wu <wutengda@huaweicloud.com>,
Yang Jihong <yangjihong1@huawei.com>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v1 00/10] Move uid filtering to BPF filters
Date: Sat, 11 Jan 2025 11:01:33 -0800 [thread overview]
Message-ID: <20250111190143.1029906-1-irogers@google.com> (raw)
Rather than scanning /proc and skipping PIDs based on their UIDs, use
BPF filters for uid filtering. The /proc scanning in thread_map is
racy as the PID may exit before the perf_event_open causing perf to
abort. BPF UID filters are more robust as they avoid the race. Add a
helper for commands that support UID filtering and wire up. Remove the
non-BPF UID filtering support.
Ian Rogers (10):
perf bench evlist-open-close: Reduce scope of 2 variables
perf parse-events filter: Use evsel__find_pmu
perf target: Separate parse_uid into its own function
perf parse-events: Add parse_uid_filter helper
perf record: Switch user option to use BPF filter
perf top: Switch user option to use BPF filter
perf trace: Switch user option to use BPF filter
perf bench evlist-open-close: Switch user option to use BPF filter
perf target: Remove uid from target
perf thread_map: Remove uid options
tools/perf/bench/evlist-open-close.c | 76 ++++++++++++---------
tools/perf/builtin-ftrace.c | 1 -
tools/perf/builtin-kvm.c | 2 -
tools/perf/builtin-record.c | 26 +++----
tools/perf/builtin-stat.c | 4 +-
tools/perf/builtin-top.c | 22 +++---
tools/perf/builtin-trace.c | 25 ++++---
tools/perf/tests/backward-ring-buffer.c | 1 -
tools/perf/tests/event-times.c | 8 +--
tools/perf/tests/keep-tracking.c | 2 +-
tools/perf/tests/mmap-basic.c | 2 +-
tools/perf/tests/openat-syscall-all-cpus.c | 2 +-
tools/perf/tests/openat-syscall-tp-fields.c | 1 -
tools/perf/tests/openat-syscall.c | 2 +-
tools/perf/tests/perf-record.c | 1 -
tools/perf/tests/perf-time-to-tsc.c | 2 +-
tools/perf/tests/switch-tracking.c | 2 +-
tools/perf/tests/task-exit.c | 1 -
tools/perf/tests/thread-map.c | 2 +-
tools/perf/util/bpf-filter.c | 2 +-
tools/perf/util/evlist.c | 3 +-
tools/perf/util/parse-events.c | 25 ++++---
tools/perf/util/parse-events.h | 1 +
tools/perf/util/python.c | 10 +--
tools/perf/util/target.c | 54 ++-------------
tools/perf/util/target.h | 15 +---
tools/perf/util/thread_map.c | 32 +--------
tools/perf/util/thread_map.h | 6 +-
tools/perf/util/top.c | 4 +-
tools/perf/util/top.h | 1 +
30 files changed, 135 insertions(+), 200 deletions(-)
--
2.47.1.613.gc27f4b7a9f-goog
next reply other threads:[~2025-01-11 19:02 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-11 19:01 Ian Rogers [this message]
2025-01-11 19:01 ` [PATCH v1 01/10] perf bench evlist-open-close: Reduce scope of 2 variables Ian Rogers
2025-02-12 14:17 ` Arnaldo Carvalho de Melo
2025-01-11 19:01 ` [PATCH v1 02/10] perf parse-events filter: Use evsel__find_pmu Ian Rogers
2025-02-12 14:51 ` Arnaldo Carvalho de Melo
2025-02-12 16:11 ` Ian Rogers
2025-01-11 19:01 ` [PATCH v1 03/10] perf target: Separate parse_uid into its own function Ian Rogers
2025-01-11 19:01 ` [PATCH v1 04/10] perf parse-events: Add parse_uid_filter helper Ian Rogers
2025-01-11 19:01 ` [PATCH v1 05/10] perf record: Switch user option to use BPF filter Ian Rogers
2025-01-11 19:01 ` [PATCH v1 06/10] perf top: " Ian Rogers
2025-01-11 19:01 ` [PATCH v1 07/10] perf trace: " Ian Rogers
2025-01-11 19:01 ` [PATCH v1 08/10] perf bench evlist-open-close: " Ian Rogers
2025-01-11 19:01 ` [PATCH v1 09/10] perf target: Remove uid from target Ian Rogers
2025-01-11 19:01 ` [PATCH v1 10/10] perf thread_map: Remove uid options Ian Rogers
2025-02-10 18:18 ` [PATCH v1 00/10] Move uid filtering to BPF filters Ian Rogers
2025-02-10 19:59 ` Namhyung Kim
2025-02-10 22:06 ` Ian Rogers
2025-02-11 3:12 ` Namhyung Kim
2025-02-11 4:40 ` Ian Rogers
2025-02-11 17:51 ` Namhyung Kim
2025-02-11 18:06 ` Ian Rogers
2025-02-12 1:51 ` Namhyung Kim
2025-02-12 5:41 ` Ian Rogers
2025-02-12 18:46 ` Namhyung Kim
2025-02-12 20:00 ` Ian Rogers
2025-02-12 22:56 ` Namhyung Kim
2025-02-12 23:17 ` Ian Rogers
2025-02-13 1:44 ` Namhyung Kim
2025-02-13 7:27 ` Ian Rogers
2025-02-13 17:47 ` Namhyung Kim
2025-02-13 18:13 ` Ian Rogers
2025-02-13 18:59 ` Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250111190143.1029906-1-irogers@google.com \
--to=irogers@google.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=asmadeus@codewreck.org \
--cc=gehao@kylinos.cn \
--cc=howardchu95@gmail.com \
--cc=james.clark@linaro.org \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=wutengda@huaweicloud.com \
--cc=xu.yang_2@nxp.com \
--cc=yangjihong1@huawei.com \
--cc=yeoreum.yun@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox