From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BB4971DFD1 for ; Sun, 12 Jan 2025 04:23:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736655812; cv=none; b=DUgHX39AWo2lqTIMpD9i6V6lafnuw2nrlIueK7/wDkxJ1bA3+tG3LfKrWQarmSIXaHsKxRnE8R/qSGIPMyW4XQygQWyXoVgWUel/pDTdu1amCrs1EKyHsBh+/yXsN4LVhqjt4+FnbUZPvGGnT4wR7OO0CLc2UPlmp/Hf18QFNcg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736655812; c=relaxed/simple; bh=36RubHS3Cnm6huMkfjDsiWl/nxjNKQeCb1t+02PapzM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=rETMNrF/ynL2a5LsEOie6wkEkGHSuOkaLIG8Hu8nEDxby+IqsGaGX0wTTvjKYUB4IScrObEwLaVJ8jG8t/PwdG6vvoAqX0ntEg6soa2/6VQpdJywkbMLCb0IT4/cGZ8ucHLqVW1QLO4qvn0wUVGO/llKUl7cUEPxJj3o1OcC1K0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=V7/hYADb; arc=none smtp.client-ip=209.85.216.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="V7/hYADb" Received: by mail-pj1-f51.google.com with SMTP id 98e67ed59e1d1-2ee989553c1so5456433a91.3 for ; Sat, 11 Jan 2025 20:23:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1736655810; x=1737260610; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=o1iD5FXnr9tRagISbCiZ6n33Qv7hNVSaezl59sxw848=; b=V7/hYADbVUoisWJjXgfkHYGi9d0jHjpTC3nJZUap0To20zcAM8SnphgMrdZsmvh4F2 duPwzRogXWQTrCGWNufByM8A/WB7sQUJJrOSpXle8tspZxH62SEwRT/rEcXt3s4vRf8J j5qUsiH4gnOiguwR1xsNict/vBVXCGzxi4jF2vtnIUKfpItv5QHuA93iGrqtDNqWy9rx 3++vsrpwOYd1vap4HzANvCPuEcYO+RljiV78rD0cDCmRVlx+x0tvWh9PLRgeq3PmIRhg B3isps/g4U4L8rHLXuWH/E1AMq96DD5OmpmyTJjuZquchoSu2ysEJZxT5gLEXMyDNEol uu0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736655810; x=1737260610; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=o1iD5FXnr9tRagISbCiZ6n33Qv7hNVSaezl59sxw848=; b=urMQx0pGah0RywarlHoYv/mUHdUvykC3vfpYS5cerHr330gT18x8DDRuSPz+SwhMjk S3UMo/BtIsmVFTAFAFUSc/acwdxxVv5XR91dZkqpNoD1BfjrkXeOQ0J1uuO2MMk0u2ko SKcvRinW+BzQTEvAa/9g9yzRnS92hmXfTFrf8bsNKp3Fum5bE2ZizW5GQYrl2CjQiRGZ qXPgL8xhQ9dGwCeGukLZu5x8YBnzBZXA+NnzmXBXSXc/dmhg2gAo8Xs86hSS4S3BvdzO 2zUWeRMzwIh5cFw10RrNUnwevZvU0HRJkGKnaB8GgPpn/qN9jKfiZv+fxvHt9H7iAQrt AmpQ== X-Forwarded-Encrypted: i=1; AJvYcCVNptYdoq9QEppo6wKV/NmqlqeJgdc0X4CeX4jLmd9xWNq3MTJ3q/sa6FExcxmIdy36MehNLwPOQ40Spq8=@vger.kernel.org X-Gm-Message-State: AOJu0YyfmmqpDwOBzcYp4ui2UcGHqaskmq2YH3e0L9MYS59OCZMcdemJ T39PachFBOTdhoA4NxYi2jBBFje1R9jTWJ8UfT5RxEnfzyGBL0sgK9+4l9PUKA== X-Gm-Gg: ASbGncu0XHR3FL2XPks1IAgxqlAOjENxfN+Sd5onjn2loRkJFUmLtqEFP24yBVmUf19 QnkXxVDBsLl36prbXRkcw+oT5xnJd0C/uG39RcHWj7wipHn3Cw2p4owHqsVyNmB18uYQzzXANMf tZSUYY2zsWPX91G0ZmqSeYlLpgtWaAo+J6csh/tS+H3cD+YC8xK3CO50tW6bXcOZ68HX77bNIv5 QELI5Hu7BuC4Y9UU3xTJVdXb4d17i0h+cAq2KHy+/lqGRc+N2NSxgoU7otgqA1k0yDx X-Google-Smtp-Source: AGHT+IF3OEz850HbSNTcnLpGcYOvuZZBOpakiqJoF5m/TvFHKLFMjvbB2UauZ+EQoabKlqDmh0L6kA== X-Received: by 2002:a17:90a:da8e:b0:2ee:b0b0:8e02 with SMTP id 98e67ed59e1d1-2f5490ac09cmr22992308a91.28.1736655810070; Sat, 11 Jan 2025 20:23:30 -0800 (PST) Received: from thinkpad ([117.193.215.92]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2f54a2872a3sm7694399a91.16.2025.01.11.20.23.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 11 Jan 2025 20:23:29 -0800 (PST) Date: Sun, 12 Jan 2025 09:53:23 +0530 From: Manivannan Sadhasivam To: Loic Poulain Cc: mhi@lists.linux.dev, Johan Hovold , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH 2/2] bus: mhi: host: pci_generic: Recover the device synchronously from mhi_pci_runtime_resume() Message-ID: <20250112042323.kn7xlgyf3olpcavf@thinkpad> References: <20250108-mhi_recovery_fix-v1-0-a0a00a17da46@linaro.org> <20250108-mhi_recovery_fix-v1-2-a0a00a17da46@linaro.org> <20250108160211.6dok3zcn2qaoj3lp@thinkpad> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Thu, Jan 09, 2025 at 09:50:55PM +0100, Loic Poulain wrote: > On Wed, 8 Jan 2025 at 17:02, Manivannan Sadhasivam > wrote: > > > > On Wed, Jan 08, 2025 at 04:19:06PM +0100, Loic Poulain wrote: > > > On Wed, 8 Jan 2025 at 14:39, Manivannan Sadhasivam via B4 Relay > > > wrote: > > > > > > > > From: Manivannan Sadhasivam > > > > > > > > Currently, in mhi_pci_runtime_resume(), if the resume fails, recovery_work > > > > is started asynchronously and success is returned. But this doesn't align > > > > with what PM core expects as documented in > > > > Documentation/power/runtime_pm.rst: > > > > > > > > "Once the subsystem-level resume callback (or the driver resume callback, > > > > if invoked directly) has completed successfully, the PM core regards the > > > > device as fully operational, which means that the device _must_ be able to > > > > complete I/O operations as needed. The runtime PM status of the device is > > > > then 'active'." > > > > > > > > So the PM core ends up marking the runtime PM status of the device as > > > > 'active', even though the device is not able to handle the I/O operations. > > > > This same condition more or less applies to system resume as well. > > > > > > > > So to avoid this ambiguity, try to recover the device synchronously from > > > > mhi_pci_runtime_resume() and return the actual error code in the case of > > > > recovery failure. > > > > > > > > For doing so, move the recovery code to __mhi_pci_recovery_work() helper > > > > and call that from both mhi_pci_recovery_work() and > > > > mhi_pci_runtime_resume(). Former still ignores the return value, while the > > > > latter passes it to PM core. > > > > > > > > Cc: stable@vger.kernel.org # 5.13 > > > > Reported-by: Johan Hovold > > > > Closes: https://lore.kernel.org/mhi/Z2PbEPYpqFfrLSJi@hovoldconsulting.com > > > > Fixes: d3800c1dce24 ("bus: mhi: pci_generic: Add support for runtime PM") > > > > Signed-off-by: Manivannan Sadhasivam > > > > > > Note that it will noticeably impact the user experience on system-wide > > > resume (mhi_pci_resume), because MHI devices usually take a while (a > > > few seconds) to cold boot and reach a ready state (or time out in the > > > worst case). So we may have people complaining about delayed resume > > > regression on their laptop even if they are not using the MHI > > > device/modem function. Are we ok with that? > > > > > > > Are you saying that the modem will enter D3Cold all the time during system > > suspend? I think you are referring to x86 host machines here. > > It depends on the host and its firmware implementation, but yes I > observed that x86_64 based laptops are powering off the mPCIe slot > while suspended. > Then the default behavior should be to power down the MHI stack during suspend. > > If that is the case, we should not be using mhi_pci_runtime_*() calls in > > mhi_pci_suspend/resume(). Rather the MHI stack should be powered down during > > suspend and powered ON during resume. > > Yes, but what about the hosts keeping power in suspend state? we can > not really know that programmatically AFAIK. > Well, there are a few APIs we can rely on, but they are not reliable atleast on DT platforms. However, powering down the MHI stack should be safe irrespective of what the platform decides to do. Regarding your comment on device taking time to resume, we can opt for async PM to let the device come up without affecting overall system resume. Let me know if both of the above options make sense to you. I'll submit patches to incorporate them. - Mani -- மணிவண்ணன் சதாசிவம்