From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net [217.70.183.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 07E5414A614 for ; Sun, 12 Jan 2025 22:54:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736722459; cv=none; b=CUTkm405CZVME/02wtgP7NtqRL/CP2/J3IE9ML7ds/lcPn7j09ckuxq162uPRbr6V5NOiYQVnsWcHQGpIPZKNnb7BSxixqOHLfCNfIrlLYWjJ0XIZDDLYj8dsvzzHEyitBZBZx1dUIcqIywfxd+vyVkCvBRcwFd/0wXS8tV6now= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736722459; c=relaxed/simple; bh=QwOrfkRoNiWvpYtFcc5er8zGNluyf8Q5CAShDe7vd6Q=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=QGVY43jxqm7/Ud4637vHpBrpJ4IsPbTt63U9hm6y943IGiHrNBAuyoyhMfBgLQEId+LH0ptEOgOI8hLul+rjMySOKoqCrHqoiw3Hul7GYb3dkCuiNZUECcAZbbpov4FDpf0IAITFxrTazuZnVoN1/9PM6fKuBtyOWTks4zmnuXw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=QqndU374; arc=none smtp.client-ip=217.70.183.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="QqndU374" Received: by mail.gandi.net (Postfix) with ESMTPSA id 262D71BF204; Sun, 12 Jan 2025 22:54:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1736722449; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7999jetr7TTK/iQtMJ+/kbDvvNRKuEQNa3t5KglJsDU=; b=QqndU374soXhDCiGZK+ADo0n+zinWpmuou7O2Bnk2Jff3sOM5dORxMYo7lMN2+3iLtTeRC XIxey5cv8dAGaXZ1G5PXwkUPYFTOx1icvgPuWXUkZ5BdkPnAH8fJ9EY7wR8jOVebve6kWC QRNNkopXDiCjaoRCo7WU7HA9H9oOmnlVFIofw7EAFz/sBTGPOAkvfe8xreOa9V7CkXF1XK TwEXSyVUNvC8P9Vf5Y1faZbW0DS6m7e4G7GRZlTDjBftSCxYaYFacf7OimUENRtjggy9Ld fuJ+oFAZsCist7H0RcZ+to1yBgivWFqrwGdoBBcdGCVXJ7Khtkv0aX+iXsbV4A== Date: Sun, 12 Jan 2025 23:54:08 +0100 From: Alexandre Belloni To: linux@treblig.org Cc: linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] i3c: Remove unused i3c_device_do_setdasa Message-ID: <202501122254082b225acf@mail.local> References: <20241221143418.86012-1-linux@treblig.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241221143418.86012-1-linux@treblig.org> X-GND-Sasl: alexandre.belloni@bootlin.com Hello, On 21/12/2024 14:34:18+0000, linux@treblig.org wrote: > From: "Dr. David Alan Gilbert" > > i3c_device_do_setdasa() was added in 2022 as part of > commit 672825cd2823 ("i3c: export SETDASA method") > > but has been unused. > > It calls i3c_dev_setdasa_locked() which is now also unused. > > Remove them both. > (This is effectively a revert of 672825cd2823). > Yeah, i guess this just means that we didn't see the device driver yet. I'm going to keep those function around for now. > Signed-off-by: Dr. David Alan Gilbert > --- > drivers/i3c/device.c | 20 -------------------- > drivers/i3c/internals.h | 1 - > drivers/i3c/master.c | 19 ------------------- > include/linux/i3c/device.h | 2 -- > 4 files changed, 42 deletions(-) > > diff --git a/drivers/i3c/device.c b/drivers/i3c/device.c > index e80e48756914..984976f28314 100644 > --- a/drivers/i3c/device.c > +++ b/drivers/i3c/device.c > @@ -54,26 +54,6 @@ int i3c_device_do_priv_xfers(struct i3c_device *dev, > } > EXPORT_SYMBOL_GPL(i3c_device_do_priv_xfers); > > -/** > - * i3c_device_do_setdasa() - do I3C dynamic address assignement with > - * static address > - * > - * @dev: device with which the DAA should be done > - * > - * Return: 0 in case of success, a negative error core otherwise. > - */ > -int i3c_device_do_setdasa(struct i3c_device *dev) > -{ > - int ret; > - > - i3c_bus_normaluse_lock(dev->bus); > - ret = i3c_dev_setdasa_locked(dev->desc); > - i3c_bus_normaluse_unlock(dev->bus); > - > - return ret; > -} > -EXPORT_SYMBOL_GPL(i3c_device_do_setdasa); > - > /** > * i3c_device_get_info() - get I3C device information > * > diff --git a/drivers/i3c/internals.h b/drivers/i3c/internals.h > index 433f6088b7ce..842e1a865877 100644 > --- a/drivers/i3c/internals.h > +++ b/drivers/i3c/internals.h > @@ -13,7 +13,6 @@ > void i3c_bus_normaluse_lock(struct i3c_bus *bus); > void i3c_bus_normaluse_unlock(struct i3c_bus *bus); > > -int i3c_dev_setdasa_locked(struct i3c_dev_desc *dev); > int i3c_dev_do_priv_xfers_locked(struct i3c_dev_desc *dev, > struct i3c_priv_xfer *xfers, > int nxfers); > diff --git a/drivers/i3c/master.c b/drivers/i3c/master.c > index 42310c9a00c2..000187339400 100644 > --- a/drivers/i3c/master.c > +++ b/drivers/i3c/master.c > @@ -2916,25 +2916,6 @@ void i3c_master_unregister(struct i3c_master_controller *master) > } > EXPORT_SYMBOL_GPL(i3c_master_unregister); > > -int i3c_dev_setdasa_locked(struct i3c_dev_desc *dev) > -{ > - struct i3c_master_controller *master; > - > - if (!dev) > - return -ENOENT; > - > - master = i3c_dev_get_master(dev); > - if (!master) > - return -EINVAL; > - > - if (!dev->boardinfo || !dev->boardinfo->init_dyn_addr || > - !dev->boardinfo->static_addr) > - return -EINVAL; > - > - return i3c_master_setdasa_locked(master, dev->info.static_addr, > - dev->boardinfo->init_dyn_addr); > -} > - > int i3c_dev_do_priv_xfers_locked(struct i3c_dev_desc *dev, > struct i3c_priv_xfer *xfers, > int nxfers) > diff --git a/include/linux/i3c/device.h b/include/linux/i3c/device.h > index 0a8a44ac2f02..f4e924c179d7 100644 > --- a/include/linux/i3c/device.h > +++ b/include/linux/i3c/device.h > @@ -301,8 +301,6 @@ int i3c_device_do_priv_xfers(struct i3c_device *dev, > struct i3c_priv_xfer *xfers, > int nxfers); > > -int i3c_device_do_setdasa(struct i3c_device *dev); > - > void i3c_device_get_info(const struct i3c_device *dev, struct i3c_device_info *info); > > struct i3c_ibi_payload { > -- > 2.47.1 > -- Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com