* [PATCH] rtc: Remove hpet_rtc_dropped_irq()
@ 2024-12-15 2:23 linux
2025-01-12 23:26 ` Alexandre Belloni
2025-01-13 22:10 ` Alexandre Belloni
0 siblings, 2 replies; 4+ messages in thread
From: linux @ 2024-12-15 2:23 UTC (permalink / raw)
To: bp, mingo, tglx, dave.hansen, hpa, alexandre.belloni
Cc: x86, linux-rtc, arnd, linux-kernel, Dr. David Alan Gilbert
From: "Dr. David Alan Gilbert" <linux@treblig.org>
hpet_rtc_dropped_irq() has been unused since
commit f52ef24be21a ("rtc/alpha: remove legacy rtc driver")
Remove it in rtc, and x86 hpet code.
Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
---
arch/x86/include/asm/hpet.h | 1 -
arch/x86/kernel/hpet.c | 6 ------
drivers/rtc/rtc-cmos.c | 5 -----
3 files changed, 12 deletions(-)
diff --git a/arch/x86/include/asm/hpet.h b/arch/x86/include/asm/hpet.h
index ab9f3dd87c80..ab0c78855ecb 100644
--- a/arch/x86/include/asm/hpet.h
+++ b/arch/x86/include/asm/hpet.h
@@ -84,7 +84,6 @@ extern int hpet_set_rtc_irq_bit(unsigned long bit_mask);
extern int hpet_set_alarm_time(unsigned char hrs, unsigned char min,
unsigned char sec);
extern int hpet_set_periodic_freq(unsigned long freq);
-extern int hpet_rtc_dropped_irq(void);
extern int hpet_rtc_timer_init(void);
extern irqreturn_t hpet_rtc_interrupt(int irq, void *dev_id);
extern int hpet_register_irq_handler(rtc_irq_handler handler);
diff --git a/arch/x86/kernel/hpet.c b/arch/x86/kernel/hpet.c
index c96ae8fee95e..7e21018a0e04 100644
--- a/arch/x86/kernel/hpet.c
+++ b/arch/x86/kernel/hpet.c
@@ -1392,12 +1392,6 @@ int hpet_set_periodic_freq(unsigned long freq)
}
EXPORT_SYMBOL_GPL(hpet_set_periodic_freq);
-int hpet_rtc_dropped_irq(void)
-{
- return is_hpet_enabled();
-}
-EXPORT_SYMBOL_GPL(hpet_rtc_dropped_irq);
-
static void hpet_rtc_timer_reinit(void)
{
unsigned int delta;
diff --git a/drivers/rtc/rtc-cmos.c b/drivers/rtc/rtc-cmos.c
index 78f2ce12c75a..9c8ce7510c56 100644
--- a/drivers/rtc/rtc-cmos.c
+++ b/drivers/rtc/rtc-cmos.c
@@ -151,11 +151,6 @@ static inline int hpet_set_periodic_freq(unsigned long freq)
return 0;
}
-static inline int hpet_rtc_dropped_irq(void)
-{
- return 0;
-}
-
static inline int hpet_rtc_timer_init(void)
{
return 0;
--
2.47.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] rtc: Remove hpet_rtc_dropped_irq()
2024-12-15 2:23 [PATCH] rtc: Remove hpet_rtc_dropped_irq() linux
@ 2025-01-12 23:26 ` Alexandre Belloni
2025-01-13 9:59 ` Borislav Petkov
2025-01-13 22:10 ` Alexandre Belloni
1 sibling, 1 reply; 4+ messages in thread
From: Alexandre Belloni @ 2025-01-12 23:26 UTC (permalink / raw)
To: linux; +Cc: bp, mingo, tglx, dave.hansen, hpa, x86, linux-rtc, arnd,
linux-kernel
Dear x86 maintainers,
On 15/12/2024 02:23:56+0000, linux@treblig.org wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
>
> hpet_rtc_dropped_irq() has been unused since
> commit f52ef24be21a ("rtc/alpha: remove legacy rtc driver")
>
> Remove it in rtc, and x86 hpet code.
>
I'm willing t take this patch, can I get an ack?
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
> ---
> arch/x86/include/asm/hpet.h | 1 -
> arch/x86/kernel/hpet.c | 6 ------
> drivers/rtc/rtc-cmos.c | 5 -----
> 3 files changed, 12 deletions(-)
>
> diff --git a/arch/x86/include/asm/hpet.h b/arch/x86/include/asm/hpet.h
> index ab9f3dd87c80..ab0c78855ecb 100644
> --- a/arch/x86/include/asm/hpet.h
> +++ b/arch/x86/include/asm/hpet.h
> @@ -84,7 +84,6 @@ extern int hpet_set_rtc_irq_bit(unsigned long bit_mask);
> extern int hpet_set_alarm_time(unsigned char hrs, unsigned char min,
> unsigned char sec);
> extern int hpet_set_periodic_freq(unsigned long freq);
> -extern int hpet_rtc_dropped_irq(void);
> extern int hpet_rtc_timer_init(void);
> extern irqreturn_t hpet_rtc_interrupt(int irq, void *dev_id);
> extern int hpet_register_irq_handler(rtc_irq_handler handler);
> diff --git a/arch/x86/kernel/hpet.c b/arch/x86/kernel/hpet.c
> index c96ae8fee95e..7e21018a0e04 100644
> --- a/arch/x86/kernel/hpet.c
> +++ b/arch/x86/kernel/hpet.c
> @@ -1392,12 +1392,6 @@ int hpet_set_periodic_freq(unsigned long freq)
> }
> EXPORT_SYMBOL_GPL(hpet_set_periodic_freq);
>
> -int hpet_rtc_dropped_irq(void)
> -{
> - return is_hpet_enabled();
> -}
> -EXPORT_SYMBOL_GPL(hpet_rtc_dropped_irq);
> -
> static void hpet_rtc_timer_reinit(void)
> {
> unsigned int delta;
> diff --git a/drivers/rtc/rtc-cmos.c b/drivers/rtc/rtc-cmos.c
> index 78f2ce12c75a..9c8ce7510c56 100644
> --- a/drivers/rtc/rtc-cmos.c
> +++ b/drivers/rtc/rtc-cmos.c
> @@ -151,11 +151,6 @@ static inline int hpet_set_periodic_freq(unsigned long freq)
> return 0;
> }
>
> -static inline int hpet_rtc_dropped_irq(void)
> -{
> - return 0;
> -}
> -
> static inline int hpet_rtc_timer_init(void)
> {
> return 0;
> --
> 2.47.1
>
--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] rtc: Remove hpet_rtc_dropped_irq()
2025-01-12 23:26 ` Alexandre Belloni
@ 2025-01-13 9:59 ` Borislav Petkov
0 siblings, 0 replies; 4+ messages in thread
From: Borislav Petkov @ 2025-01-13 9:59 UTC (permalink / raw)
To: Alexandre Belloni
Cc: linux, mingo, tglx, dave.hansen, hpa, x86, linux-rtc, arnd,
linux-kernel
On Mon, Jan 13, 2025 at 12:26:00AM +0100, Alexandre Belloni wrote:
> Dear x86 maintainers,
>
> On 15/12/2024 02:23:56+0000, linux@treblig.org wrote:
> > From: "Dr. David Alan Gilbert" <linux@treblig.org>
> >
> > hpet_rtc_dropped_irq() has been unused since
> > commit f52ef24be21a ("rtc/alpha: remove legacy rtc driver")
> >
> > Remove it in rtc, and x86 hpet code.
> >
>
> I'm willing t take this patch, can I get an ack?
Acked-by: Borislav Petkov (AMD) <bp@alien8.de>
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] rtc: Remove hpet_rtc_dropped_irq()
2024-12-15 2:23 [PATCH] rtc: Remove hpet_rtc_dropped_irq() linux
2025-01-12 23:26 ` Alexandre Belloni
@ 2025-01-13 22:10 ` Alexandre Belloni
1 sibling, 0 replies; 4+ messages in thread
From: Alexandre Belloni @ 2025-01-13 22:10 UTC (permalink / raw)
To: bp, mingo, tglx, dave.hansen, hpa, linux
Cc: x86, linux-rtc, arnd, linux-kernel
On Sun, 15 Dec 2024 02:23:56 +0000, linux@treblig.org wrote:
> hpet_rtc_dropped_irq() has been unused since
> commit f52ef24be21a ("rtc/alpha: remove legacy rtc driver")
>
> Remove it in rtc, and x86 hpet code.
>
>
Applied, thanks!
[1/1] rtc: Remove hpet_rtc_dropped_irq()
https://git.kernel.org/abelloni/c/58589c6a6e9e
Best regards,
--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-01-13 22:10 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-12-15 2:23 [PATCH] rtc: Remove hpet_rtc_dropped_irq() linux
2025-01-12 23:26 ` Alexandre Belloni
2025-01-13 9:59 ` Borislav Petkov
2025-01-13 22:10 ` Alexandre Belloni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox