From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fout-a7-smtp.messagingengine.com (fout-a7-smtp.messagingengine.com [103.168.172.150]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AB6C32AE6C for ; Mon, 13 Jan 2025 01:43:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=103.168.172.150 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736732588; cv=none; b=jocWcG5tfbzn5X/LL4sIV43aBkr3qgyzhEZ4RnSdzJqgLBJhxsYEbNQySOlF+04RqDyNbBWSdjg87W4VStXrSwCwAe36pAiNBLdkOuevn/ELCuvu+5XC/a8pZDX1+Bm/Y5U/vEmHf9Hy3g5KBXmljnfaRE1UdlJOjsoMr1L53og= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736732588; c=relaxed/simple; bh=kMHRegsxSusdLj0F/esHMu2anGu0teirGPtKnQ2yFno=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=iFPLJXbmh5EvUWQHmwv6jNN89Av4VPSE9nEfaU4QPjwYbmMowQAYZrC3YXYPjEK+vuSM3s1bLWo/wPROAAL3HFQac6CGONB4SzLG6tmtltFktVe7oOVv85Updviog1zU6N8rKZCYD0SMi3xANOsJIWoyqnaToGj0l3pu37TSaEQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sakamocchi.jp; spf=pass smtp.mailfrom=sakamocchi.jp; dkim=pass (2048-bit key) header.d=sakamocchi.jp header.i=@sakamocchi.jp header.b=HvCoVSmX; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=iM3eDlgw; arc=none smtp.client-ip=103.168.172.150 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sakamocchi.jp Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sakamocchi.jp Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sakamocchi.jp header.i=@sakamocchi.jp header.b="HvCoVSmX"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="iM3eDlgw" Received: from phl-compute-12.internal (phl-compute-12.phl.internal [10.202.2.52]) by mailfout.phl.internal (Postfix) with ESMTP id 8EBEA138019F; Sun, 12 Jan 2025 20:43:03 -0500 (EST) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-12.internal (MEProxy); Sun, 12 Jan 2025 20:43:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sakamocchi.jp; h=cc:cc:content-type:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm2; t=1736732583; x= 1736818983; bh=nj5NmPz4q2DNLdNYVNvbcUlqJz+8Zz24YB2RmUbxT8I=; b=H vCoVSmXPQBf35F176RFDG3rpzB0LqFK2NFmC6IznR1GiMrH4yjCL+/9i+gPmFqOy ykRzx/m4unQ6gTobL9HybZVtF5ui/OVgl7uM+aPJq13F1RW4WcOyYS/wKTGhZAqA fF5uXVWEy6vVltDgvufolxmcYiVuHjNR5p2mlMwNIjsxuaPgii34Z0sK0qIefqrK ev7Sd5x31Q0hFxL6PzRcNAORkcMF/qjYoDTVaKvL3YUzzYqNcxC6Ls5IIX1eEoBd 8NpP1ruuRPQZOSgli5keHNySC9vPOxpbl/z3rD6XQIdw1q7HZ4A4onu1pMpT0sdx 12hRlostt2+Ex/ffyfGgg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1736732583; x=1736818983; bh=nj5NmPz4q2DNLdNYVNvbcUlqJz+8Zz24YB2 RmUbxT8I=; b=iM3eDlgwKxg4O8cKn9LDyvn2SNbaOeoK7BROXJ9+dlzz+egeSVL Q5htCnj7y4C+smqU/yoncCpA7cbDQ62Ezw/EoVj/AGj8tCfcb9IaofX5En7GIklw kUvGmXsfJ9ymCRliizIeJd0upVIN9IhRgwD0RyIkYbLWbnmNcbyRytr/P/Uke/LL 2jr8GfIfHtdyWpbRr3+ZKw3kaPRt0dHenL4ae2pwt6YGqFJ+uBHsf3OvsqyEohLP wBsbqlY6ei0LABcdjVgX3vgvcnRzlcaVDgpx885MnqeuK5cOBdRG5lHyRX3QSXCd D8Q3TBat00JDByK3MFCHqEovllA1soY/n6w== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefuddrudehfedgfeejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucenucfjughrpeffhffvve fukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpefvrghkrghshhhiucfurghkrghm ohhtohcuoehoqdhtrghkrghshhhisehsrghkrghmohgttghhihdrjhhpqeenucggtffrrg htthgvrhhnpeehhffhteetgfekvdeiueffveevueeftdelhfejieeitedvleeftdfgfeeu udekueenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe hoqdhtrghkrghshhhisehsrghkrghmohgttghhihdrjhhppdhnsggprhgtphhtthhopeef pdhmohguvgepshhmthhpohhuthdprhgtphhtthhopehhrghntghhuhhntghhrghosehinh hsphhurhdrtghomhdprhgtphhtthhopehlihhnuhigudefleegqdguvghvvghlsehlihhs thhsrdhsohhurhgtvghfohhrghgvrdhnvghtpdhrtghpthhtoheplhhinhhugidqkhgvrh hnvghlsehvghgvrhdrkhgvrhhnvghlrdhorhhg X-ME-Proxy: Feedback-ID: ie8e14432:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 12 Jan 2025 20:43:01 -0500 (EST) Date: Mon, 13 Jan 2025 10:42:58 +0900 From: Takashi Sakamoto To: Charles Han Cc: linux1394-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: [PATCH] firewire: test: Fix potential null dereference in firewire kunit test Message-ID: <20250113014258.GA68470@workstation.local> Mail-Followup-To: Charles Han , linux1394-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org References: <20250110084237.8877-1-hanchunchao@inspur.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250110084237.8877-1-hanchunchao@inspur.com> Hi, On Fri, Jan 10, 2025 at 04:42:37PM +0800, Charles Han wrote: > kunit_kzalloc() may return a NULL pointer, dereferencing it without > NULL check may lead to NULL dereference. > Add a NULL check for test_state. > > Fixes: 1c8506d62624 ("firewire: test: add test of device attributes for simple AV/C device") > Signed-off-by: Charles Han > --- > drivers/firewire/device-attribute-test.c | 2 ++ > 1 file changed, 2 insertions(+) Applied to for-next branch. Thanks Takashi Sakamoto