From: Masahiro Yamada <masahiroy@kernel.org>
To: linux-kbuild@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Masahiro Yamada <masahiroy@kernel.org>
Subject: [PATCH 16/17] genksyms: fix syntax error for builtin (u)int*x*_t types
Date: Tue, 14 Jan 2025 00:00:54 +0900 [thread overview]
Message-ID: <20250113150253.3097820-17-masahiroy@kernel.org> (raw)
In-Reply-To: <20250113150253.3097820-1-masahiroy@kernel.org>
A longstanding issue with genksyms is that it has hidden syntax errors.
When a syntax error occurs, yyerror() is called. However,
error_with_pos() is a no-op unless the -w option is provided.
You can observe syntax errors by manually passing the -w option.
For example, genksyms fails to parse the following code in
arch/arm64/lib/xor-neon.c:
static inline uint64x2_t eor3(uint64x2_t p, uint64x2_t q, uint64x2_t r)
{
[ snip ]
}
The syntax error occurs because genksyms does not recognize the
uint64x2_t keyword.
This commit adds support for builtin types described in Arm Neon
Intrinsics Reference.
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
---
scripts/genksyms/lex.l | 1 +
1 file changed, 1 insertion(+)
diff --git a/scripts/genksyms/lex.l b/scripts/genksyms/lex.l
index a1f969dcf24f..22aeb57649d9 100644
--- a/scripts/genksyms/lex.l
+++ b/scripts/genksyms/lex.l
@@ -51,6 +51,7 @@ MC_TOKEN ([~%^&*+=|<>/-]=)|(&&)|("||")|(->)|(<<)|(>>)
%%
+u?int(8|16|32|64)x(1|2|4|8|16)_t return BUILTIN_INT_KEYW;
/* Keep track of our location in the original source files. */
^#[ \t]+{INT}[ \t]+\"[^\"\n]+\".*\n return FILENAME;
--
2.43.0
next prev parent reply other threads:[~2025-01-13 15:03 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-13 15:00 [PATCH 00/17] genksyms: fix conflicts and syntax errors in parser Masahiro Yamada
2025-01-13 15:00 ` [PATCH 01/17] genksyms: rename m_abstract_declarator to abstract_declarator Masahiro Yamada
2025-01-13 15:00 ` [PATCH 02/17] genksyms: rename cvar_qualifier to type_qualifier Masahiro Yamada
2025-01-13 15:00 ` [PATCH 03/17] genksyms: reduce type_qualifier directly to decl_specifier Masahiro Yamada
2025-01-13 15:00 ` [PATCH 04/17] genksyms: fix 6 shift/reduce conflicts and 5 reduce/reduce conflicts Masahiro Yamada
2025-01-14 1:23 ` Masahiro Yamada
2025-01-13 15:00 ` [PATCH 05/17] genksyms: fix last 3 shift/reduce conflicts Masahiro Yamada
2025-01-13 15:00 ` [PATCH 06/17] genksyms: remove Makefile hack Masahiro Yamada
2025-01-13 15:00 ` [PATCH 07/17] genksyms: restrict direct-abstract-declarator to take one parameter-type-list Masahiro Yamada
2025-01-13 15:00 ` [PATCH 08/17] genksyms: restrict direct-declarator " Masahiro Yamada
2025-01-13 15:00 ` [PATCH 09/17] genksyms: record attributes consistently for init-declarator Masahiro Yamada
2025-01-13 15:00 ` [PATCH 10/17] genksyms: decouple ATTRIBUTE_PHRASE from type-qualifier Masahiro Yamada
2025-01-13 15:00 ` [PATCH 11/17] genksyms: fix syntax error for attribute before abstract_declarator Masahiro Yamada
2025-01-13 15:00 ` [PATCH 12/17] genksyms: fix syntax error for attribute before nested_declarator Masahiro Yamada
2025-01-13 15:00 ` [PATCH 13/17] genksyms: fix syntax error for attribute after abstact_declarator Masahiro Yamada
2025-01-13 15:00 ` [PATCH 14/17] genksyms: fix syntax error for attribute after 'struct' Masahiro Yamada
2025-01-13 15:00 ` [PATCH 15/17] genksyms: fix syntax error for attribute after 'union' Masahiro Yamada
2025-01-13 15:00 ` Masahiro Yamada [this message]
2025-01-13 15:00 ` [PATCH 17/17] genksyms: fix syntax error for attribute before init-declarator Masahiro Yamada
2025-01-14 20:33 ` [PATCH 00/17] genksyms: fix conflicts and syntax errors in parser Nicolas Schier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250113150253.3097820-17-masahiroy@kernel.org \
--to=masahiroy@kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox