From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f48.google.com (mail-qv1-f48.google.com [209.85.219.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6EE382135AF for ; Tue, 14 Jan 2025 13:07:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736860045; cv=none; b=UZaD4TN/zp/B1IhVm423+4C3lK1PnzKd4Zg8a4rmuCACxEszRdSr8sonYuCvJjz+2E+fJ+maDsSTStE4i8EasFDHk6NTbFic+ntl8paxvVtnS/zV/CZ0VQjIowmXoLa8GvxXBu7FaIyc37l2NHWm+HGNd7HIjpqQj3dLTlHGqYk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736860045; c=relaxed/simple; bh=/avICbdPpHdjemOQvkLGAY2+9dfeloypzwM49yfXZ78=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=oojKpAc633ol+MAjPlCC4LOLPa+al76eBi1tjTE4skLd2KX54vSu5R2QR/KENNU/BHZiyG6TjtZCWECmZxWCTKU7CozOG+j2AtQFG5RCFKjPa60C0Qvg/qZmv56FtQbewoHT96vqzKCmAQ4644/cK9gRf6fCZyLlreOr8r438N0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca; spf=pass smtp.mailfrom=ziepe.ca; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b=LQsFjL50; arc=none smtp.client-ip=209.85.219.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="LQsFjL50" Received: by mail-qv1-f48.google.com with SMTP id 6a1803df08f44-6dd1962a75bso43424406d6.3 for ; Tue, 14 Jan 2025 05:07:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1736860042; x=1737464842; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=3TbuYi0/uhpyIsEsjZiVCHU/0H6AIyzAzvX2PVA6CnY=; b=LQsFjL50oooI+CayDX5ewn/omBqtoeqN9u1guEYka1oIK5aqJcGXPu42aIYmBpVd0h gK6ZAH4VWW95bnThaOCHO90Mr6bcnqcb1aizzIAbA9RYQT/V9g1R6k77uAf5I6Gst7mW 78xdyPRUcGd0h/ACazOzotcMN2LfIuCVOrHnxuZH3sz9kslWBrW6rGcaRPjAkRJLqIBN 59eIC8cBFKYx+GqzdZBsFEfkJnsGHVxkAyKIAM0DiNja5uAZkcf7JwV6ipFZ0NaX6VMH KvyBLIU6lII0pwcvkfSigsh9ucohloB1ndeT02w6bXbO/M5Z/REQbFqYaOa2WCE27bjA s8Rw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736860042; x=1737464842; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=3TbuYi0/uhpyIsEsjZiVCHU/0H6AIyzAzvX2PVA6CnY=; b=rL0W0m8Mge+Mj2f0lAaRIdBSlbgQRse1ShqRWlscbIDsZ4KceGxfl/rxNXfpKMDUis FoBCa9jCIwzNAvIQX2z5Uu3sDmejSEMGPlUDh0Pe3iOzTP/o0+9aF8LsNl4Eosvr9rlK a3qEY0vb/poEoqW2ZnxsXnxNDpSw2G0sfaXIAri7INpb6zb8bzVkpbztqh6mhKFbABNb vNreYJQemZ1XU4OcopDPUduAb+p/5Hjly3GsV/RhIESsoFUdkm4DMEUJoDigKAMtdP3s wMeIEmouUMM8pITDt70hO/JnaRyBcn43cagcPSxmjmu8YPX/SzG4UgC3PxOsN5rk+Axe DD3g== X-Forwarded-Encrypted: i=1; AJvYcCXrQiT17SIEgnk+L23t4opkdBn5g4Mmaadh2XXT4aPEZVLjJ3xdn+LhS0zaMQw+MsYB48z4iUjlfSBB3RU=@vger.kernel.org X-Gm-Message-State: AOJu0Yx5iymL9f9WXe5Tf35SxTfWLbZC0MEMwp03flsvPRe0f22TWl9+ Gjn3J3dl2+60aDsMiAjLpl9oOF7Qzw4wCxxJmJVlsQ/+E4LOaMs1HUjfNi48jh8= X-Gm-Gg: ASbGncsade4AGPtR+ZPCmn8teyWt9kDByLK/Yx3YNvTMzRJV63hmpsYBhG9veIA32GV rPEDA32yx1wiVbPrtd4kdTrv77g5mpTtZr8qtlEBG/tzBTwDLEFJ6k15dQG2XxLFlC5oxuc8PCV ua9ecbM6f9yhyjbO6zDa4u77XQk41qVL+G+xrAbaDfLTdrVFi2bTey7d1w9wsUpryDTzTK0QIGM aDu1D64Qv4yCzu12BxfAQMgigIPulIZIQ7bLQVB4OBcGV3A8J2q9UZlDNEIE6y0135jh/Lxaf/5 m27S8fSSXIXADnKPFkbc2LiOzOqpdA== X-Google-Smtp-Source: AGHT+IGLd1udhy0Of2yDBsH2ne4/vF+q3n9lb8J+wsePBP6osAhl0cEquesspYzUnUKjTPWXZsReXA== X-Received: by 2002:a05:6214:2686:b0:6d4:36ff:4356 with SMTP id 6a1803df08f44-6df9b220effmr448916986d6.19.1736860042256; Tue, 14 Jan 2025 05:07:22 -0800 (PST) Received: from ziepe.ca (hlfxns017vw-142-68-128-5.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.68.128.5]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6dfade73b8fsm52418026d6.72.2025.01.14.05.07.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jan 2025 05:07:21 -0800 (PST) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1tXgdc-00000002Lxg-3sFN; Tue, 14 Jan 2025 09:07:20 -0400 Date: Tue, 14 Jan 2025 09:07:20 -0400 From: Jason Gunthorpe To: Stefano Garzarella Cc: Jarkko Sakkinen , James Bottomley , linux-coco@lists.linux.dev, Borislav Petkov , Dave Hansen , Peter Huewe , "H. Peter Anvin" , linux-integrity@vger.kernel.org, x86@kernel.org, Joerg Roedel , Jarkko Sakkinen , linux-kernel@vger.kernel.org, Ingo Molnar , Thomas Gleixner , Claudio Carvalho , Dov Murik , Tom Lendacky Subject: Re: [PATCH 3/3] x86/sev: add a SVSM vTPM platform device Message-ID: <20250114130720.GJ26854@ziepe.ca> References: <20241210143423.101774-4-sgarzare@redhat.com> <20241210144025.GG1888283@ziepe.ca> <50a2e1d29b065498146f459035e447851a518d1a.camel@HansenPartnership.com> <20241210150413.GI1888283@ziepe.ca> <20241211150048.GJ1888283@ziepe.ca> <6rwo7tkdst227kb4pwvr54w4mfz2zw3offux7mqfupi3rgwkaz@65yklvvqw6n4> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Jan 14, 2025 at 11:42:34AM +0100, Stefano Garzarella wrote: > Hi Jarkko, > > On Thu, 19 Dec 2024 at 17:07, Stefano Garzarella wrote: > > > > On Thu, Dec 19, 2024 at 05:40:58PM +0200, Jarkko Sakkinen wrote: > > >On Thu Dec 19, 2024 at 5:35 PM EET, Stefano Garzarella wrote: > > >> So to use them directly in sev, we would have to move these definitions > > >> into include/linux/tpm.h or some other file in inlcude/. Is this > > >> acceptable for TPM maintainers? > > > > > >There's only me. > > > > > >I don't know. > > > > > >What you want to put to include/linux/tpm.h anyway? > > > > At least tpmm_chip_alloc(), tpm2_probe(), and tpm_chip_register() The intention was that tpm drivers would be under drivers/char/tpm/ Do you really need to put your tpm driver in arch code? Historically drivers in arch code have not worked out so well. Meaning that you'd export some of your arch stuff for the tpm driver to live in its natural home Jason