Re: [PATCH 6.1 00/92] 6.1.125-rc1 review

[Greg Kroah-Hartman <gregkh@linuxfoundation.org>]

On Wed, Jan 15, 2025 at 06:09:06AM -0800, Ron Economos wrote:
> On 1/15/25 04:50, Pavel Machek wrote:
> > Hi!
> > 
> > > This is the start of the stable review cycle for the 6.1.125 release.
> > > There are 92 patches in this series, all will be posted as a response
> > > to this one.  If anyone has any issues with these being applied, please
> > > let me know.
> > Still building, but we already have failures on risc-v.
> > 
> > drivers/usb/core/port.c: In function 'usb_port_shutdown':
> > 2912
> > drivers/usb/core/port.c:417:26: error: 'struct usb_device' has no member named 'port_is_suspended'
> > 2913
> >    417 |         if (udev && !udev->port_is_suspended) {
> > 2914
> >        |                          ^~
> > 2915
> > make[4]: *** [scripts/Makefile.build:250: drivers/usb/core/port.o] Error 1
> > 2916
> > make[4]: *** Waiting for unfinished jobs....
> > 2917
> >    CC      drivers/gpu/drm/radeon/radeon_test.o
> > 
> > https://gitlab.com/cip-project/cip-testing/linux-stable-rc-ci/-/pipelines/1626266073
> > 
> > Best regards,
> > 								Pavel
> 
> I'm seeing the build failure here also. Looks like it's due to not having
> CONFIG_PM set in the config. The member "port_is_suspended" is inside of an
> #ifdef CONFIG_PM in include/linux/usb.h. The #ifdef CONFIG_PM has been
> removed at some point.

Yeah, it was fixed up in 6.4 with commit 130eac417085 ("xhci: use
pm_ptr() instead of #ifdef for CONFIG_PM conditionals"), which is why we
didn't see this as a dependency.  I'll see if I can figure that out
tomorrow for how to backport it as it doesn't apply cleanly.

thanks,

greg k-h