From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D35C21DD525 for ; Thu, 16 Jan 2025 12:43:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.11 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737031427; cv=none; b=WMDryLpJdKcjCY5h3dM6LwVtPtJEzHmI0X4jO2fNSQo+Xc4uZF5z1Nr5H5d6mzjT+THOz3u3Me965Xc18elGZEqwWD6U3HNbaGTqi7Q7nqNCEy15v4TJ5DRHAhl26F8p+boDOkinuEgVFnqz6SX76wbJiAUBObgaYZXog6YWZyA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737031427; c=relaxed/simple; bh=zgM7/YpCZqDK8HTamCWxZslPH4UQZi5iIotPMuGgkJs=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=WhHYC6RWV09unlgHMRlBXQsLdUkIpltMiy59w0G6Zhyx8pyiYEOQLGrJYv9RFdMlqxT9qPVMnSw0Y9ON2ia9AnZqotJfP1bzQ0l9fMFhi+PNWxH8FdPqhSt1vvSHVwVWJPQdOLdhhUaKW1h+IxOVxKXYmHoUo7H64AS9v+jM5ew= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=Le4QAPTO; arc=none smtp.client-ip=198.175.65.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="Le4QAPTO" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1737031425; x=1768567425; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=zgM7/YpCZqDK8HTamCWxZslPH4UQZi5iIotPMuGgkJs=; b=Le4QAPTOvKRbfiYvsu7QQEB/ombBmrkQdbxMKQbKpGN7lcUVkyi9cFDG uADXhziYvFFTgG91adAnhwjHJpkMD+nd7WUIKQegs5aHjaIx0eAyBZ0Fa aGA2jb+0LbGpwVIXzkweg/N59OKQKghtbTEnpH8gaw1mBib9T+qLjX12I YcsTOml21xat77xQVO7amUkbIw5A1su0qnp2XFB+jMsKCCWcVC+O2QBou 9PKUB9cNJQaKMKIdQjNq/pjSK3jQ5oLCqq2lP8diNHwvsL1a0vQ5cy6DB jkQ2079CTjmldPNe03Xze6D+AsMjysNOZ4/duAQ55qnhTzlX4DmkO4x5K A==; X-CSE-ConnectionGUID: 95Arh44RS6qbA8ydFtjsGA== X-CSE-MsgGUID: iEb+ZdrvRcWzbymPXqvgRA== X-IronPort-AV: E=McAfee;i="6700,10204,11316"; a="47904761" X-IronPort-AV: E=Sophos;i="6.13,209,1732608000"; d="scan'208";a="47904761" Received: from fmviesa003.fm.intel.com ([10.60.135.143]) by orvoesa103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Jan 2025 04:43:45 -0800 X-CSE-ConnectionGUID: EhUAWHgLSLaYcu0XFE+mIQ== X-CSE-MsgGUID: xUIHhoLUT2mxiM7bShti5g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,224,1728975600"; d="scan'208";a="109525865" Received: from black.fi.intel.com ([10.237.72.28]) by fmviesa003.fm.intel.com with ESMTP; 16 Jan 2025 04:43:43 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id 7A477478; Thu, 16 Jan 2025 14:43:41 +0200 (EET) From: Andy Shevchenko To: Mark Brown , linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , Andy Shevchenko Subject: [PATCH v2 1/1] regmap: Drop unused devm_regmap_*_free() APIs Date: Thu, 16 Jan 2025 14:43:30 +0200 Message-ID: <20250116124339.3941636-1-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.43.0.rc1.1336.g36b5255a03ac Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Besides the fact that currently defined devm_*_free() APIs are being unused, it's usually a sign of bad design to call such explicitly. Drop them and make people pay more attention on the misuse of devm_regmap_*() APIs, Signed-off-by: Andy Shevchenko --- v2: rebased on the top of latest vanilla drivers/base/regmap/regmap.c | 36 ------------------------------------ include/linux/regmap.h | 3 --- 2 files changed, 39 deletions(-) diff --git a/drivers/base/regmap/regmap.c b/drivers/base/regmap/regmap.c index 197c79b66828..2314744201b4 100644 --- a/drivers/base/regmap/regmap.c +++ b/drivers/base/regmap/regmap.c @@ -1330,42 +1330,6 @@ void regmap_field_bulk_free(struct regmap_field *field) } EXPORT_SYMBOL_GPL(regmap_field_bulk_free); -/** - * devm_regmap_field_bulk_free() - Free a bulk register field allocated using - * devm_regmap_field_bulk_alloc. - * - * @dev: Device that will be interacted with - * @field: regmap field which should be freed. - * - * Free register field allocated using devm_regmap_field_bulk_alloc(). Usually - * drivers need not call this function, as the memory allocated via devm - * will be freed as per device-driver life-cycle. - */ -void devm_regmap_field_bulk_free(struct device *dev, - struct regmap_field *field) -{ - devm_kfree(dev, field); -} -EXPORT_SYMBOL_GPL(devm_regmap_field_bulk_free); - -/** - * devm_regmap_field_free() - Free a register field allocated using - * devm_regmap_field_alloc. - * - * @dev: Device that will be interacted with - * @field: regmap field which should be freed. - * - * Free register field allocated using devm_regmap_field_alloc(). Usually - * drivers need not call this function, as the memory allocated via devm - * will be freed as per device-driver life-cyle. - */ -void devm_regmap_field_free(struct device *dev, - struct regmap_field *field) -{ - devm_kfree(dev, field); -} -EXPORT_SYMBOL_GPL(devm_regmap_field_free); - /** * regmap_field_alloc() - Allocate and initialise a register field. * diff --git a/include/linux/regmap.h b/include/linux/regmap.h index 3a96d068915f..c7f51f0b13af 100644 --- a/include/linux/regmap.h +++ b/include/linux/regmap.h @@ -1441,7 +1441,6 @@ void regmap_field_free(struct regmap_field *field); struct regmap_field *devm_regmap_field_alloc(struct device *dev, struct regmap *regmap, struct reg_field reg_field); -void devm_regmap_field_free(struct device *dev, struct regmap_field *field); int regmap_field_bulk_alloc(struct regmap *regmap, struct regmap_field **rm_field, @@ -1452,8 +1451,6 @@ int devm_regmap_field_bulk_alloc(struct device *dev, struct regmap *regmap, struct regmap_field **field, const struct reg_field *reg_field, int num_fields); -void devm_regmap_field_bulk_free(struct device *dev, - struct regmap_field *field); int regmap_field_read(struct regmap_field *field, unsigned int *val); int regmap_field_update_bits_base(struct regmap_field *field, -- 2.43.0.rc1.1336.g36b5255a03ac