From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
Felipe Balbi <balbi@kernel.org>,
linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, Ferry Toth <fntoth@gmail.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: [PATCH v1 3/3] usb: dwc3: gadget: Skip endpoints ep[18]{in,out} on Intel Merrifield
Date: Thu, 16 Jan 2025 17:40:48 +0200 [thread overview]
Message-ID: <20250116154117.148915-4-andriy.shevchenko@linux.intel.com> (raw)
In-Reply-To: <20250116154117.148915-1-andriy.shevchenko@linux.intel.com>
Intel Merrifield SoC uses these endpoints for tracing and they shouldn't
be used for normal transfers, we need to skip them.
• 1 High BW Bulk IN (IN#1) (RTIT)
• 1 1KB BW Bulk IN (IN#8) + 1 1KB BW Bulk OUT (Run Control) (OUT#8)
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/usb/dwc3/dwc3-pci.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/drivers/usb/dwc3/dwc3-pci.c b/drivers/usb/dwc3/dwc3-pci.c
index 052852f80146..9b73dfd34823 100644
--- a/drivers/usb/dwc3/dwc3-pci.c
+++ b/drivers/usb/dwc3/dwc3-pci.c
@@ -148,11 +148,20 @@ static const struct property_entry dwc3_pci_intel_byt_properties[] = {
{}
};
+/*
+ * Intel Merrifield uses these endpoints for tracing and they shouldn't be used
+ * for normal transfers, we need to skip them.
+ * • 1 High BW Bulk IN (IN#1) (RTIT)
+ * • 1 1KB BW Bulk IN (IN#8) + 1 1KB BW Bulk OUT (Run Control) (OUT#8)
+ */
+static const u8 dwc3_pci_mrfld_reserved_endpoints[] = { 3, 16, 17 };
+
static const struct property_entry dwc3_pci_mrfld_properties[] = {
PROPERTY_ENTRY_STRING("dr_mode", "otg"),
PROPERTY_ENTRY_STRING("linux,extcon-name", "mrfld_bcove_pwrsrc"),
PROPERTY_ENTRY_BOOL("snps,dis_u3_susphy_quirk"),
PROPERTY_ENTRY_BOOL("snps,dis_u2_susphy_quirk"),
+ PROPERTY_ENTRY_U8_ARRAY("snps,reserved-endpoints", dwc3_pci_mrfld_reserved_endpoints),
PROPERTY_ENTRY_BOOL("snps,usb2-gadget-lpm-disable"),
PROPERTY_ENTRY_BOOL("linux,sysdev_is_parent"),
{}
--
2.43.0.rc1.1336.g36b5255a03ac
next prev parent reply other threads:[~2025-01-16 15:41 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-16 15:40 [PATCH v1 0/3] usb: dwc3: Avoid using reserved EPs Andy Shevchenko
2025-01-16 15:40 ` [PATCH v1 1/3] dt-bindings: usb: dwc3: Add a property to reserve endpoints Andy Shevchenko
2025-01-23 22:09 ` Rob Herring
2025-01-24 14:55 ` Andy Shevchenko
2025-01-16 15:40 ` [PATCH v1 2/3] usb: dwc3: gadget: Add support for snps,reserved-endpoints property Andy Shevchenko
2025-01-16 23:35 ` Thinh Nguyen
2025-01-17 13:32 ` Andy Shevchenko
2025-01-22 1:44 ` Thinh Nguyen
2025-01-22 17:12 ` Andy Shevchenko
2025-01-28 2:39 ` Thinh Nguyen
2025-01-28 16:55 ` Andy Shevchenko
2025-01-30 1:48 ` Thinh Nguyen
2025-01-16 15:40 ` Andy Shevchenko [this message]
2025-01-16 23:39 ` [PATCH v1 3/3] usb: dwc3: gadget: Skip endpoints ep[18]{in,out} on Intel Merrifield Thinh Nguyen
2025-01-17 13:33 ` Andy Shevchenko
2025-01-21 23:46 ` Thinh Nguyen
2025-01-21 23:51 ` Thinh Nguyen
2025-01-22 16:24 ` Andy Shevchenko
2025-01-22 16:23 ` Andy Shevchenko
2025-01-28 2:21 ` Thinh Nguyen
2025-01-28 16:50 ` Andy Shevchenko
2025-01-30 1:44 ` Thinh Nguyen
2025-01-16 23:18 ` [PATCH v1 0/3] usb: dwc3: Avoid using reserved EPs Thinh Nguyen
2025-01-17 13:38 ` Andy Shevchenko
2025-01-20 15:02 ` Andy Shevchenko
2025-01-21 23:43 ` Thinh Nguyen
2025-01-22 16:27 ` Andy Shevchenko
2025-01-28 2:25 ` Thinh Nguyen
2025-01-28 16:57 ` Andy Shevchenko
2025-01-17 22:00 ` Ferry Toth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250116154117.148915-4-andriy.shevchenko@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=Thinh.Nguyen@synopsys.com \
--cc=balbi@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=fntoth@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox