From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6A30E22B8CA for ; Thu, 16 Jan 2025 15:54:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737042895; cv=none; b=Qu3fUyTd4x1PzP47jXE5nxesPHjeB1WBLPHnDBxdx0w4lK8JMsVV/zTycPt0G9NDIOZFrAXBJS6JAZ/9kqNZGDLge3o5/jdidQ836oz07fKtzPM7Zm1uZAJHePUkz5BDwd+yZQEBLmmIo/AiB2EFhhlx+4ZOb50HkYCkBXeGcks= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737042895; c=relaxed/simple; bh=rQG3Chwl/9sp6tLgsiCJZ2e5h2KbdVwRxMUL1hZdaB4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=hpLjpCY+sUbK/rEyw00WoOgQ6CXbX/FbKhngfPdOzqfGUti//3r3V9maaO7mO3mh8iJ1EaEJMHy79ZAXxKfMM5v4JCFwsNurkRLTg6VQMbDUYtEFpF5/BWYrUZIhzewT1SdJhTjLFdJM17MX17xEDeHcADBo5VI6ZrG/DRQCN2E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=cLjnWkKO; arc=none smtp.client-ip=209.85.221.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cLjnWkKO" Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-3862d6d5765so680798f8f.3 for ; Thu, 16 Jan 2025 07:54:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1737042891; x=1737647691; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=lsIy1hwmOo/E5E4bQodyMN+5T0LtN8lt/FWTPRJwl3E=; b=cLjnWkKOUeKULBcQ4s0KIgF6bLsjnWYuqcH9ldUewH7+l2nqVTl7iTRfL0LV2BqHUe bFZbEpq1pDMkesptZRLYbmLyRoRMuH0Z+Kh2YAFlksd93OMBMe3r0LyO/l3Mbo7e0n4f 2GWu1RnyVEgfSoijFniHtEJKn3eBlcT7UI9DHPeIqwbZHQ2oNKhnZgesNWFnhKtNZJXq 38q2sVCTDMQ5DzHUxfH4pe8/fmtaoCjHYJl2RdL8jAobUsZhvgU5Rpa75e23euuRt4F1 eeEafldKrEATs3TQlrLGro1RnmVEYbHp/MCpGaLDUiRMAlvyldi/ndP7r67gV+rigcMn ptVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737042891; x=1737647691; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lsIy1hwmOo/E5E4bQodyMN+5T0LtN8lt/FWTPRJwl3E=; b=tMEhqwfwdxKjpkHMTh+Y2MZo1HLnDXOLV7aeHAomCAQr9TJ0OprsLNlL3awXwLcVA7 Y1TBPgyjHX/hbYw5lJw0AshYG1YQ3eYr4YygzNlG9+vOzG6G09r20gDapxEl8fcT3M6B SFNAFjPGiJqh9UcOMAN/J2gryOnAv2LTOa/0colUb9L5jzauDMAedBZSCwLgyazel7tF N5wFe96/X0j1Gz0SqfXidBktb1bLyYTOjWQxHjksKQ2I5jyyXTW9FuQ8EksMDpN1OoDJ B45x7h8QpqVot4t9HuvHnkFn5JL5gH8QQCfE1BGZqpcrDrUAvVutxp8QwdmnQatQ9v80 /YTQ== X-Forwarded-Encrypted: i=1; AJvYcCWmbsPI9vADyR9uuIe5ko1HI67vT/J8qLaakGL4BYwAkM7nUmEBIIJ/IksuxW0Lj81wrI3BILn0jO+8E9A=@vger.kernel.org X-Gm-Message-State: AOJu0YxUNSg4yP+/ebvDovIu72misSZdO5pm4pX2xhCoEQnk8xRPXjyw +nvQJQ1EBdazQ6zIdDswK0OlwIYijZzOJok3FBdCeoOGK+0oS3mk X-Gm-Gg: ASbGncvj8aG6Xvfd8NFGN+0SUJEi+Vxt10/GW0DEYL34+J95YoiyGT/QGUc4vbe1fsq Xg5GIiIk2vFfcrp7Kus1k77pLeV0nbQHgvgUCfUgZfiLqKkXlljNQ+2emx6JdOGSbluC+PXq1pQ /KGAoTDG4ipVxvgWJDvij+2PaNjMuOP2tKdXXXce1xtCfICWE/TtrCxEu42byhilPHtuS1dGIxc VY4ffaVpliQ11acn1ET/jcUlI0p9J5f0QqU233rUZy7gy+uq8wNwb72uA== X-Google-Smtp-Source: AGHT+IFiwv9j0YjjKuCRjEMarnyqoxBeR54uC4o8HVB2+kJRsjIqAm+8OIc9//IXvsApwoAwjdVFog== X-Received: by 2002:a05:6000:178a:b0:38a:4184:1529 with SMTP id ffacd0b85a97d-38a872d2aa5mr23704329f8f.12.1737042891492; Thu, 16 Jan 2025 07:54:51 -0800 (PST) Received: from fedora.. ([94.73.34.116]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-437c16c4c12sm43533845e9.3.2025.01.16.07.54.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Jan 2025 07:54:50 -0800 (PST) From: =?UTF-8?q?Jos=C3=A9=20Exp=C3=B3sito?= To: louis.chauvet@bootlin.com Cc: airlied@gmail.com, arthurgrillo@riseup.net, dri-devel@lists.freedesktop.org, hamohammed.sa@gmail.com, jeremie.dautheribes@bootlin.com, linux-kernel@vger.kernel.org, maarten.lankhorst@linux.intel.com, mairacanal@riseup.net, mcanal@igalia.com, melissa.srw@gmail.com, miquel.raynal@bootlin.com, mripard@kernel.org, nicolejadeyee@google.com, rodrigosiqueiramelo@gmail.com, seanpaul@google.com, simona.vetter@ffwll.ch, simona@ffwll.ch, thomas.petazzoni@bootlin.com, tzimmermann@suse.de, =?UTF-8?q?Jos=C3=A9=20Exp=C3=B3sito?= Subject: [PATCH v8 1/8] drm/vkms: Switch to managed for connector Date: Thu, 16 Jan 2025 16:54:44 +0100 Message-ID: <20250116155446.3461-1-jose.exposito89@gmail.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20250114-google-vkms-managed-v8-1-da4254aa3dd5@bootlin.com> References: <20250114-google-vkms-managed-v8-1-da4254aa3dd5@bootlin.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit > The current VKMS driver uses non-managed function to create connectors. It > is not an issue yet, but in order to support multiple devices easily, > convert this code to use drm and device managed helpers. > > Reviewed-by: Maxime Ripard > Reviewed-by: Maíra Canal > Reviewed-by: Thomas Zimmermann > Signed-off-by: Louis Chauvet Reviewed-by: José Expósito Thanks! > --- > drivers/gpu/drm/vkms/vkms_output.c | 12 ++++-------- > 1 file changed, 4 insertions(+), 8 deletions(-) > > diff --git a/drivers/gpu/drm/vkms/vkms_output.c b/drivers/gpu/drm/vkms/vkms_output.c > index 8f4bd5aef087b459d37d0cbbf90fe0145090917a..570823ecb28f589e6323036590ec05a2f633bc9b 100644 > --- a/drivers/gpu/drm/vkms/vkms_output.c > +++ b/drivers/gpu/drm/vkms/vkms_output.c > @@ -3,11 +3,11 @@ > #include "vkms_drv.h" > #include > #include > +#include > #include > > static const struct drm_connector_funcs vkms_connector_funcs = { > .fill_modes = drm_helper_probe_single_connector_modes, > - .destroy = drm_connector_cleanup, > .reset = drm_atomic_helper_connector_reset, > .atomic_duplicate_state = drm_atomic_helper_connector_duplicate_state, > .atomic_destroy_state = drm_atomic_helper_connector_destroy_state, > @@ -75,8 +75,8 @@ int vkms_output_init(struct vkms_device *vkmsdev) > } > } > > - ret = drm_connector_init(dev, connector, &vkms_connector_funcs, > - DRM_MODE_CONNECTOR_VIRTUAL); > + ret = drmm_connector_init(dev, connector, &vkms_connector_funcs, > + DRM_MODE_CONNECTOR_VIRTUAL, NULL); > if (ret) { > DRM_ERROR("Failed to init connector\n"); > return ret; > @@ -88,7 +88,7 @@ int vkms_output_init(struct vkms_device *vkmsdev) > DRM_MODE_ENCODER_VIRTUAL, NULL); > if (ret) { > DRM_ERROR("Failed to init encoder\n"); > - goto err_encoder; > + return ret; > } > encoder->possible_crtcs = drm_crtc_mask(crtc); > > @@ -110,9 +110,5 @@ int vkms_output_init(struct vkms_device *vkmsdev) > > err_attach: > drm_encoder_cleanup(encoder); > - > -err_encoder: > - drm_connector_cleanup(connector); > - > return ret; > } >