public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Thorsten Leemhuis <regressions@leemhuis.info>
Cc: Bruno Gravato <bgravato@gmail.com>, Stefan <linux-kernel@simg.de>,
	Keith Busch <kbusch@kernel.org>,
	bugzilla-daemon@kernel.org, Adrian Huang <ahuang12@lenovo.com>,
	Linux kernel regressions list <regressions@lists.linux.dev>,
	linux-nvme@lists.infradead.org, Jens Axboe <axboe@fb.com>,
	"iommu@lists.linux.dev" <iommu@lists.linux.dev>,
	LKML <linux-kernel@vger.kernel.org>,
	Christoph Hellwig <hch@lst.de>
Subject: Re: [Bug 219609] File corruptions on SSD in 1st M.2 socket of AsRock X600M-STX + Ryzen 8700G
Date: Fri, 17 Jan 2025 09:05:07 +0100	[thread overview]
Message-ID: <20250117080507.GA25953@lst.de> (raw)
In-Reply-To: <3b693647-5e82-4c39-8017-22cada56eb55@leemhuis.info>

On Wed, Jan 15, 2025 at 09:40:04AM +0100, Thorsten Leemhuis wrote:
> What does it mean that disabling the NVMe devices's write cache often
> but apparently not always helps? It it just reducing the chance of the
> problem occurring or accidentally working around it?

For consumer NAND device you basically can't disable the volatile
write cache.  If you do disable it, that just means it gets flushed
after every write, meaning you have to write the entire NAND
(super)block for every write, causing a huge slowdown (and a lot of
media wear).  This will change timings a lot obviously.  If it doesn't
change the timing the driver just fakes it, which reputable vendors
shouldn't be doing, but I would not be entirely surprised about
for noname devices.

> hch initially brought up that swiotlb seems to be used. Are there any
> BIOS setup settings we should try? I tried a few changes yesterday, but
> I still get the "PCI-DMA: Using software bounce buffering for IO
> (SWIOTLB)" message in the log and not a single line mentioning DMAR.

The real question would be to figure out why it is used.

Do you see the

	pci_dbg(dev, "marking as untrusted\n");

message in the commit log if enabling the pci debug output?
(I though we had a sysfs file for that, but I can't find it).


  parent reply	other threads:[~2025-01-17  8:05 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-08 14:38 [Regression] File corruptions on SSD in 1st M.2 socket of AsRock X600M-STX Thorsten Leemhuis
2025-01-08 15:07 ` Keith Busch
2025-01-09  8:28   ` Christoph Hellwig
2025-01-09  8:52     ` Thorsten Leemhuis
2025-01-09 15:44       ` [Bug 219609] File corruptions on SSD in 1st M.2 socket of AsRock X600M-STX + Ryzen 8700G Stefan
2025-01-10 11:17         ` Bruno Gravato
2025-01-15  6:37         ` Bruno Gravato
2025-01-15  8:40           ` Thorsten Leemhuis
2025-01-16 17:29             ` Thorsten Leemhuis
2025-01-17  8:05             ` Christoph Hellwig [this message]
2025-01-17  9:51               ` Thorsten Leemhuis
2025-01-17  9:55                 ` Christoph Hellwig
2025-01-17 10:30                   ` Thorsten Leemhuis
2025-02-04  6:26                     ` Christoph Hellwig
2025-01-17 13:36                 ` Bruno Gravato
2025-01-20 14:31                 ` Thorsten Leemhuis
2025-01-28  7:41                   ` Christoph Hellwig
2025-01-28 12:00                     ` Stefan
2025-01-28 12:52                       ` Dr. David Alan Gilbert
2025-01-28 14:24                         ` Stefan
2025-02-02  8:32                           ` Bruno Gravato
2025-02-04  6:12                             ` Christoph Hellwig
2025-02-04  9:12                               ` Bruno Gravato
2025-02-03 18:48                           ` Stefan
2025-02-06 15:58                             ` Stefan
2025-01-17 21:31               ` Stefan
2025-01-18  1:03                 ` Keith Busch
2025-01-15 10:47           ` Stefan
2025-01-15 13:14             ` Bruno Gravato
2025-01-15 16:26               ` Stefan
2025-01-10  0:10     ` [Regression] File corruptions on SSD in 1st M.2 socket of AsRock X600M-STX Keith Busch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250117080507.GA25953@lst.de \
    --to=hch@lst.de \
    --cc=ahuang12@lenovo.com \
    --cc=axboe@fb.com \
    --cc=bgravato@gmail.com \
    --cc=bugzilla-daemon@kernel.org \
    --cc=iommu@lists.linux.dev \
    --cc=kbusch@kernel.org \
    --cc=linux-kernel@simg.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=regressions@leemhuis.info \
    --cc=regressions@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox