* [PATCH v1 1/3] selftests: pidfd: add missing sys/mount.h include in pidfd_fdinfo_test.c
@ 2025-01-15 10:52 Peter Seiderer
2025-04-30 16:20 ` T.J. Mercier
0 siblings, 1 reply; 4+ messages in thread
From: Peter Seiderer @ 2025-01-15 10:52 UTC (permalink / raw)
To: linux-kselftest
Cc: Shuah Khan, linux-kernel, Christian Brauner, Peter Seiderer
Fix compile on openSUSE Tumbleweed (gcc-14.2.1, glibc-2.40):
- add missing sys/mount.h include
Fixes:
pidfd_fdinfo_test.c: In function ‘child_fdinfo_nspid_test’:
pidfd_fdinfo_test.c:230:13: error: implicit declaration of function ‘mount’ [-Wimplicit-function-declaration]
230 | r = mount(NULL, "/", NULL, MS_REC | MS_PRIVATE, 0);
| ^~~~~
Signed-off-by: Peter Seiderer <ps.report@gmx.net>
---
tools/testing/selftests/pidfd/pidfd_fdinfo_test.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/testing/selftests/pidfd/pidfd_fdinfo_test.c b/tools/testing/selftests/pidfd/pidfd_fdinfo_test.c
index f062a986e382..f718aac75068 100644
--- a/tools/testing/selftests/pidfd/pidfd_fdinfo_test.c
+++ b/tools/testing/selftests/pidfd/pidfd_fdinfo_test.c
@@ -13,6 +13,7 @@
#include <syscall.h>
#include <sys/wait.h>
#include <sys/mman.h>
+#include <sys/mount.h>
#include "pidfd.h"
#include "../kselftest.h"
--
2.47.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH v1 1/3] selftests: pidfd: add missing sys/mount.h include in pidfd_fdinfo_test.c
@ 2025-01-17 14:14 Peter Seiderer
2025-01-17 14:20 ` Peter Seiderer
0 siblings, 1 reply; 4+ messages in thread
From: Peter Seiderer @ 2025-01-17 14:14 UTC (permalink / raw)
To: netdev
Cc: linux-kernel, linux-kselftest, David S . Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, Simon Horman, Shuah Khan,
Toke Høiland-Jørgensen, Frederic Weisbecker,
Artem Chernyshev, Nam Cao, Peter Seiderer
Fix compile on openSUSE Tumbleweed (gcc-14.2.1, glibc-2.40):
- add missing sys/mount.h include
Fixes:
pidfd_fdinfo_test.c: In function ‘child_fdinfo_nspid_test’:
pidfd_fdinfo_test.c:230:13: error: implicit declaration of function ‘mount’ [-Wimplicit-function-declaration]
230 | r = mount(NULL, "/", NULL, MS_REC | MS_PRIVATE, 0);
| ^~~~~
Signed-off-by: Peter Seiderer <ps.report@gmx.net>
---
tools/testing/selftests/pidfd/pidfd_fdinfo_test.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/testing/selftests/pidfd/pidfd_fdinfo_test.c b/tools/testing/selftests/pidfd/pidfd_fdinfo_test.c
index f062a986e382..f718aac75068 100644
--- a/tools/testing/selftests/pidfd/pidfd_fdinfo_test.c
+++ b/tools/testing/selftests/pidfd/pidfd_fdinfo_test.c
@@ -13,6 +13,7 @@
#include <syscall.h>
#include <sys/wait.h>
#include <sys/mman.h>
+#include <sys/mount.h>
#include "pidfd.h"
#include "../kselftest.h"
--
2.47.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v1 1/3] selftests: pidfd: add missing sys/mount.h include in pidfd_fdinfo_test.c
2025-01-17 14:14 [PATCH v1 1/3] selftests: pidfd: add missing sys/mount.h include in pidfd_fdinfo_test.c Peter Seiderer
@ 2025-01-17 14:20 ` Peter Seiderer
0 siblings, 0 replies; 4+ messages in thread
From: Peter Seiderer @ 2025-01-17 14:20 UTC (permalink / raw)
To: netdev
Cc: linux-kernel, linux-kselftest, David S . Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, Simon Horman, Shuah Khan,
Toke Høiland-Jørgensen, Frederic Weisbecker,
Artem Chernyshev, Nam Cao
Please ignore this e-mail (re-send by mistake of [1])..., sorry for the noise...
Regards,
Peter
[1] https://lore.kernel.org/linux-kselftest/20250115105211.390370-1-ps.report@gmx.net/
On Fri, 17 Jan 2025 15:14:48 +0100, Peter Seiderer <ps.report@gmx.net> wrote:
> Fix compile on openSUSE Tumbleweed (gcc-14.2.1, glibc-2.40):
> - add missing sys/mount.h include
>
> Fixes:
>
> pidfd_fdinfo_test.c: In function ‘child_fdinfo_nspid_test’:
> pidfd_fdinfo_test.c:230:13: error: implicit declaration of function ‘mount’ [-Wimplicit-function-declaration]
> 230 | r = mount(NULL, "/", NULL, MS_REC | MS_PRIVATE, 0);
> | ^~~~~
>
> Signed-off-by: Peter Seiderer <ps.report@gmx.net>
> ---
> tools/testing/selftests/pidfd/pidfd_fdinfo_test.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tools/testing/selftests/pidfd/pidfd_fdinfo_test.c b/tools/testing/selftests/pidfd/pidfd_fdinfo_test.c
> index f062a986e382..f718aac75068 100644
> --- a/tools/testing/selftests/pidfd/pidfd_fdinfo_test.c
> +++ b/tools/testing/selftests/pidfd/pidfd_fdinfo_test.c
> @@ -13,6 +13,7 @@
> #include <syscall.h>
> #include <sys/wait.h>
> #include <sys/mman.h>
> +#include <sys/mount.h>
>
> #include "pidfd.h"
> #include "../kselftest.h"
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1 1/3] selftests: pidfd: add missing sys/mount.h include in pidfd_fdinfo_test.c
2025-01-15 10:52 Peter Seiderer
@ 2025-04-30 16:20 ` T.J. Mercier
0 siblings, 0 replies; 4+ messages in thread
From: T.J. Mercier @ 2025-04-30 16:20 UTC (permalink / raw)
To: Peter Seiderer
Cc: linux-kselftest, Shuah Khan, linux-kernel, Christian Brauner
On Wed, Jan 15, 2025 at 2:52 AM Peter Seiderer <ps.report@gmx.net> wrote:
>
> Fix compile on openSUSE Tumbleweed (gcc-14.2.1, glibc-2.40):
> - add missing sys/mount.h include
>
> Fixes:
>
> pidfd_fdinfo_test.c: In function ‘child_fdinfo_nspid_test’:
> pidfd_fdinfo_test.c:230:13: error: implicit declaration of function ‘mount’ [-Wimplicit-function-declaration]
> 230 | r = mount(NULL, "/", NULL, MS_REC | MS_PRIVATE, 0);
> | ^~~~~
>
> Signed-off-by: Peter Seiderer <ps.report@gmx.net>
Reviewed-by: T.J. Mercier <tjmercier@google.com>
> ---
> tools/testing/selftests/pidfd/pidfd_fdinfo_test.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tools/testing/selftests/pidfd/pidfd_fdinfo_test.c b/tools/testing/selftests/pidfd/pidfd_fdinfo_test.c
> index f062a986e382..f718aac75068 100644
> --- a/tools/testing/selftests/pidfd/pidfd_fdinfo_test.c
> +++ b/tools/testing/selftests/pidfd/pidfd_fdinfo_test.c
> @@ -13,6 +13,7 @@
> #include <syscall.h>
> #include <sys/wait.h>
> #include <sys/mman.h>
> +#include <sys/mount.h>
>
> #include "pidfd.h"
> #include "../kselftest.h"
> --
> 2.47.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-04-30 16:21 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-01-17 14:14 [PATCH v1 1/3] selftests: pidfd: add missing sys/mount.h include in pidfd_fdinfo_test.c Peter Seiderer
2025-01-17 14:20 ` Peter Seiderer
-- strict thread matches above, loose matches on Subject: below --
2025-01-15 10:52 Peter Seiderer
2025-04-30 16:20 ` T.J. Mercier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox