From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f178.google.com (mail-qt1-f178.google.com [209.85.160.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9532819CC3A for ; Fri, 17 Jan 2025 16:48:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737132494; cv=none; b=H51+/BO8C1NdOuk8yFPk/XgiYN8g9nlMHz5+T5KECyIAw5UzCNpGmuTkwHIhcJmKwCbs6M9oaY9pwt5x/ak7i2EtiMlQLVhYbictZpboan3l7AEOeBPqV9HS0/t4/AlG9A4AkEx7/95oCz5/vKOKgycJnFqAVQGASlgFYfJQ8aI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737132494; c=relaxed/simple; bh=FQ2koMMWmX5cApEXH+IXNvtfu+A0E4n4juhen6ZDEwc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=u0T0VM9o0twLpwxi4Gr2Y0TJSEL14Eb7AG1NNleFLEK5YeFQK5xdMojA09NpXVN1JCR3mpD4OF1RlkDTfZskyAOkG6YjuzQiVY8f2A7lfMNwQnYI41YLI6Q16jlF/AhfBO9Sftpd4ZThHC+pHovz8jHtEnL/SrQFwQB1s2UaKrY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cmpxchg.org; spf=pass smtp.mailfrom=cmpxchg.org; dkim=pass (2048-bit key) header.d=cmpxchg-org.20230601.gappssmtp.com header.i=@cmpxchg-org.20230601.gappssmtp.com header.b=iWzZCpBy; arc=none smtp.client-ip=209.85.160.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cmpxchg.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cmpxchg.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cmpxchg-org.20230601.gappssmtp.com header.i=@cmpxchg-org.20230601.gappssmtp.com header.b="iWzZCpBy" Received: by mail-qt1-f178.google.com with SMTP id d75a77b69052e-4679eacf25cso14906491cf.3 for ; Fri, 17 Jan 2025 08:48:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20230601.gappssmtp.com; s=20230601; t=1737132491; x=1737737291; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=l8YaBSyWTZacAKpiBL4zeCVsLIUHz0xsGOJbxkKSeNE=; b=iWzZCpBycPwgly76N+/X9gZaqHpyottFLXN5Ap2JsLdHXvTom+TAeJr9pSQn+QviD4 SQk2wAfbGmMPCU4HLqcfnwndgxV+r0x9hiE40vkBjqLMO7l8WXTBOaXhht91AscT2FcQ VVdA3ySXZK3pHC3fMPGrBQ6tzEFwZLar19mOMYat4lw2l30cSJVc7lkKGTC0K7E+Mtuf T2pI4FsgSaCLTIIBha4v7bn/nUxoNkOP3OUdpuh6im1AwV5dfhxyLF4VgbMWJkDdfpOj mntWTJcLC5dyroyDHxcqE8DpB8JIfskKbMufJ5UDRtZgrJAZKQV7m5vGIC1arT4MOHl2 RLgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737132491; x=1737737291; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=l8YaBSyWTZacAKpiBL4zeCVsLIUHz0xsGOJbxkKSeNE=; b=GBasLkSMqf8L3Lo3vqQLhsRxuZ9Wh6laWhV0S/FzAQbGhvG2L1Cg7OQo7GjVh/aJ9I 01Ah64jmAeCAnMI55mkx7CIN8q0pYLkkqCkhAa/dtzWdwHNCH8aLNDUGgj6Z8VTgnrTZ MQ4UJqxVbysa1jR/DK2hCPtTMRMwWJ8mT4TnqDyLqKdkZ0RoEGADd8idy9SFmm1rWhRK OjD3oe97VGvZmPKnAK1dM19F62TRtKOZLlqpvzFtpBvOPZ6W6gR66C4xdxy30yfaqI9Q Fb91UEPa9eLpKqNcTys7lPEymcP3stY3AiFXzJE5PBWqjWI4jJm7M9CLag8KwmxRsMCk FLOg== X-Forwarded-Encrypted: i=1; AJvYcCWQqG6L24pJaSez5Nn6E2rN50Ut+HvG3g7GRMmmZcNhZcHjdw8HeMrVbX61+cQyvjHLgmuL12VgjeGg0lw=@vger.kernel.org X-Gm-Message-State: AOJu0Yx1Mt+I22V0RqeiPBJ65pNL8TsVLfOLRcAS8FHoY9MSBwFJ1BP1 WHk2WYacZw6S1lNowx3g4OsAXsmTxnbwBX1DQLEtqhNzLJhYMeFRZ8YEhMuhIcQ= X-Gm-Gg: ASbGncvl//1gw3pLkHsw6jn2zdkKE14kwuADMRchbtOO8L4hUml5P0xkNMCwBRLodPX OzB8oY7H5/SqDfZcLaKBYXldS7xS/fBcE7m9tLF3/Wrbv4vpjCHie/tuP7kzIvaMkc8PAk0iUO+ FTVB+/tdl/ejtEedUiiTap6P+EFcv7Aq7pC0U3etyrYNPih8y7E7epLRy+RVfeKM3T1rBy0pxLt SsIfHeITaQMV6VKOobvl3Kmmu3MXF2+LSvFjE6LpqMRTCzlNd8xAUM= X-Google-Smtp-Source: AGHT+IHnKmujOhexofpW2cCRKOdVd4mgH+9RWl0NrA2BUuwjZsr+vt7twxWRa+WyYfI3I0Pnq20sFQ== X-Received: by 2002:a05:622a:229e:b0:467:8797:29f1 with SMTP id d75a77b69052e-46e12bb3aaemr46795911cf.45.1737132491435; Fri, 17 Jan 2025 08:48:11 -0800 (PST) Received: from localhost ([2603:7000:c01:2716:f0c4:bf28:3737:7c34]) by smtp.gmail.com with UTF8SMTPSA id d75a77b69052e-46e10323c3fsm13162711cf.48.2025.01.17.08.48.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jan 2025 08:48:10 -0800 (PST) Date: Fri, 17 Jan 2025 11:48:10 -0500 From: Johannes Weiner To: Chen Ridong Cc: akpm@linux-foundation.org, mhocko@kernel.org, yosryahmed@google.com, roman.gushchin@linux.dev, shakeel.butt@linux.dev, muchun.song@linux.dev, davidf@vimeo.com, vbabka@suse.cz, mkoutny@suse.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, chenridong@huawei.com, wangweiyang2@huawei.com Subject: Re: [PATCH v3 next 3/5] memcg: factor out the replace_stock_objcg function Message-ID: <20250117164810.GE182896@cmpxchg.org> References: <20250117014645.1673127-1-chenridong@huaweicloud.com> <20250117014645.1673127-4-chenridong@huaweicloud.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250117014645.1673127-4-chenridong@huaweicloud.com> On Fri, Jan 17, 2025 at 01:46:43AM +0000, Chen Ridong wrote: > From: Chen Ridong > > Factor out the 'replace_stock_objcg' function to make the code more > cohesive. > > Signed-off-by: Chen Ridong > Reviewed-by: Roman Gushchin > Acked-by: Shakeel Butt Acked-by: Johannes Weiner