From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A72967DA88 for ; Sat, 18 Jan 2025 18:09:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737223762; cv=none; b=uiSFeTxpTmgX+ABgzI/ic+ciZT+pQbjJwTOz8x+Np9ArQWtfi28juCd51Yogdp3LkMurUOHPIx8t2J0RdpTSIB0f6cZxkQpSnZtlvMZ9CtTa0/2UVu4bJ2K89hb0XfpMA5CoIXpY8CmsuCDnws3mgAyfm7slaNNFMbQjPiQLM/g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737223762; c=relaxed/simple; bh=fNNLyuSlelf/7/QNzJPydgBjl3BLgK1X4Av7Dzt2Los=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=qU55F3MIPcVSoqzENS9Xd1rrE7o50gt+6y3Yc1niC+XJQQij06jNnXH5ADF3Q4snnjg+YxmQj/1+Ibwm0dRK1EkfB04R6Sf+BepNBZi5GkXW1RPAQWOOaS+PBHGp92GK8IUUu1AsFX6bwgCXTXAhPNPEfxqzD9balGnbMw5I6rk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Ux4rojZm; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Ux4rojZm" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-4361c705434so21371665e9.3 for ; Sat, 18 Jan 2025 10:09:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1737223759; x=1737828559; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=4BA/IJCpYsGVXt7I5m+H4A9gd0VSnYvzZ/4qWQWWRxQ=; b=Ux4rojZmCglg1LuDm829HuFdXZb7bjIEnQh/F350zU77xdZxY8ZWvJr4madFvNv0Tn yygB0FndKV5TXQq/3EEDw9WPC0nS7+3mX7IqEk//AD/Smbknuwjr0p19vGNReCu5vWGT sH0LPGpVVHoYZIFcv7a5uUS6JebvYVrS34z5N9Y5SgUDTjmLd+4cQfa3tC3HuJBbxf88 ux0mv4T7uyca5ggjDyTdAA/BlpaJBDsomUnZEcJJcUuQGBlW+chZ6fGP626egUvAdU9e vbliSkNit2QfLWKyJFbnwulTcTFfSFY794ctBfO06dvIAznV49IGteWj2BcYQohEA6lj exLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737223759; x=1737828559; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4BA/IJCpYsGVXt7I5m+H4A9gd0VSnYvzZ/4qWQWWRxQ=; b=l/lxMe/cgv41K42Eit67zJpF6Uhwx2HZwF0BuyhciZypyjHEjIseyoSjQYMyhe+WmY 6OqG0W6AbrsokIj0gNbK68dk07KlFg4YKFp2GJoTly8eqDm0wk0FdZKd5iQKGkBiIGNU DlPh6/njyZ/XNyfoVvKxb8BA5kW73qZqlzuIhiYjYdYmAyX+B2EYIW7wfBV5EMsgXidN Yja4aerov3qZzIF0V7rjEuBPHAsGwBEjG/Owo2bjyydfotS8htZ0IU4nb7SukwAFTDtU MKCVzhFNLa6tnJ2FKu7g5mwSkW5z1ILS/aNiq6Qu7ouVfGy8eDqHCmSXQZRVmEClmtfg Ns0A== X-Forwarded-Encrypted: i=1; AJvYcCUFgZnNlN/5rojbPdgTU4atwP5Xa1ism6ZpN7PGH8p23lQOEOzrJVL37Q/ySakngs9dEvSXOausmYMGq0A=@vger.kernel.org X-Gm-Message-State: AOJu0Ywaz9H7qVO2U7sNes12C6oz/xdGUsADeJ8W6JM9l2ysJfgszutm TQGmswFE/MMBMG2vtx07N9cqheccPJAaVWtqQIBv3WM7Cybz/zIk X-Gm-Gg: ASbGncv8ticXI5P6EEltInuHTFbSwUKUU/9Ube7XmeWoLRl/63JFxifK1uMZx4BTA2U T6rW7lxoo1j5elBcQdxauoruF+doWPguqw6NIt3ETvrgPBuOQgqsBiQP8Bke7g5OVyV+7KUB8jb bwnLCrMK8q7GlQV3c91iyTCQTyB4uTmDEiagDji80aPPa0hGHNpgy/Owxsv9oREM+sphYdJwz/n mZMJI6PLYvlRGNIRv4JsITQ83DEDxMQO0d1W3WcKkpUHhf0eaT8HMlirSw4rdMpLt2AyB1Ux+XX 0HTOo6kRYjYelEEUi2IpjfTJeVMFriI8 X-Google-Smtp-Source: AGHT+IHVwNkjw3fCrBEKyLXBvBiUL2k60KcVoV9cy6dZqzV7+/qO4ENIlaaFUStajLUdjSOHJHd/GA== X-Received: by 2002:a05:600c:4e4f:b0:434:f767:68ea with SMTP id 5b1f17b1804b1-438913bf92cmr81103605e9.5.1737223758584; Sat, 18 Jan 2025 10:09:18 -0800 (PST) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4389040854bsm77741645e9.7.2025.01.18.10.09.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Jan 2025 10:09:17 -0800 (PST) Date: Sat, 18 Jan 2025 18:09:16 +0000 From: David Laight To: Guenter Roeck Cc: David Laight , Linus Torvalds , 'Arnd Bergmann' , "'linux-kernel@vger.kernel.org'" , 'Jens Axboe' , 'Matthew Wilcox' , 'Christoph Hellwig' , 'Andrew Morton' , 'Andy Shevchenko' , 'Dan Carpenter' , "'Jason A . Donenfeld'" , "'pedro.falcato@gmail.com'" , 'Mateusz Guzik' , "'linux-mm@kvack.org'" , 'Lorenzo Stoakes' , intel-xe@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, David Airlie , Simona Vetter , Jani Nikula , Rodrigo Vivi Subject: Re: Buiild error in i915/xe (was: [PATCH next 4/7] minmax.h: Use BUILD_BUG_ON_MSG() for the lo < hi test in clamp()) Message-ID: <20250118180916.433bb73c@pumpkin> In-Reply-To: <29ef57a1-e4dd-4d5d-8726-f1f79c698b66@roeck-us.net> References: <34d53778977747f19cce2abb287bb3e6@AcuMS.aculab.com> <20250118170959.3aa56f4d@pumpkin> <29ef57a1-e4dd-4d5d-8726-f1f79c698b66@roeck-us.net> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Sat, 18 Jan 2025 09:49:21 -0800 Guenter Roeck wrote: > On Sat, Jan 18, 2025 at 05:09:59PM +0000, David Laight wrote: > > On Sat, 18 Jan 2025 08:13:06 -0800 > > Guenter Roeck wrote: > > > > > Hi, > > > > > > On Mon, Nov 18, 2024 at 07:13:31PM +0000, David Laight wrote: > > > > Use BUILD_BUG_ON_MSG(statically_true(ulo > uhi), ...) for the sanity > > > > check of the bounds in clamp(). > > > > Gives better error coverage and one less expansion of the arguments. > > > > > > > > Signed-off-by: David Laight > > > > > > This patch triggers a build error when trying to build parisc:allmodconfig. > > > See error message and bisect log below. > > > > > > I don't think there is anything wrong with the patch. The underlying > > > problem seems to be that parisc:allmodconfig enables CONFIG_DRM_XE which > > > tries to build the affected file even though CONFIG_DRM_I915 is not > > > enabled/supported on parisc. > > > > This has appeared before. > > Any idea which inlined copy of scale() is causing the problem. > > On the face of it they all look ok. > > > > If you can reproduce it maybe try commenting out some of the calls. > > > > See diff below. All three changes are needed. > No idea why the compiler would know that the values are invalid. Maybe it isn't even an inlining issue. Perhaps that compiler just doesn't like the function ? What happens without the 'static' (and an extra prototype)? David > > Guenter > > --- > diff --git a/drivers/gpu/drm/i915/display/intel_backlight.c b/drivers/gpu/drm/i915/display/intel_backlight.c > index fc1e517e074a..3b2c8bdfcf8d 100644 > --- a/drivers/gpu/drm/i915/display/intel_backlight.c > +++ b/drivers/gpu/drm/i915/display/intel_backlight.c > @@ -76,10 +76,14 @@ static u32 clamp_user_to_hw(struct intel_connector *connector, > static u32 scale_hw_to_user(struct intel_connector *connector, > u32 hw_level, u32 user_max) > { > +#if 0 > struct intel_panel *panel = &connector->panel; > > return scale(hw_level, panel->backlight.min, panel->backlight.max, > 0, user_max); > +#else > + return 0; > +#endif > } > > u32 intel_backlight_invert_pwm_level(struct intel_connector *connector, u32 val) > @@ -119,8 +123,10 @@ u32 intel_backlight_level_to_pwm(struct intel_connector *connector, u32 val) > drm_WARN_ON_ONCE(&i915->drm, > panel->backlight.max == 0 || panel->backlight.pwm_level_max == 0); > > +#if 0 > val = scale(val, panel->backlight.min, panel->backlight.max, > panel->backlight.pwm_level_min, panel->backlight.pwm_level_max); > +#endif > > return intel_backlight_invert_pwm_level(connector, val); > } > @@ -138,8 +144,12 @@ u32 intel_backlight_level_from_pwm(struct intel_connector *connector, u32 val) > intel_has_quirk(display, QUIRK_INVERT_BRIGHTNESS))) > val = panel->backlight.pwm_level_max - (val - panel->backlight.pwm_level_min); > > +#if 0 > return scale(val, panel->backlight.pwm_level_min, panel->backlight.pwm_level_max, > panel->backlight.min, panel->backlight.max); > +#else > + return 0; > +#endif > } > > static u32 lpt_get_backlight(struct intel_connector *connector, enum pipe unused)