Re: [PATCH v5 00/14] platform/x86: alienware-wmi driver rework

Kurt Borja
2025-01-25T03:27:52Z

On Fri Jan 24, 2025 at 4:18 PM -05, Armin Wolf wrote:
> Am 19.01.25 um 23:05 schrieb Kurt Borja:
>
>> Hi!
>>
>> Based on pdx86/for-next branch. Tested on an Alienware x15 R1.
>
> Nice work!
>
> I think the whole series is now ready to be merged.

Hi Armin,

Thank you so much again for helping me get these series into shape. Your
feedback is very appreciated!

I'm going to rebase this one more time to pick up the fixes branch merge
and this should be ready.

Also, I already have an HWMON support and manual fan control patchset
ready, that I'll submit once this gets accepted.

~ Kurt

>
> Thanks,
> Armin Wolf
>
>>
>> ~ Kurt
>> ---
>> v4 -> v5:
>>
>> [01/14]
>> - Remove mention to visibility methods in commit message
>>
>> [02/14]
>> - Register driver during module initialization
>> - Make wmi_device_id tables const
>> - Add .no_singleton = true to WMI drivers
>>
>> [04/14]
>> - Return -ENOMESG if out_data is true but obj is NULL or not of
>> ACPI_TYPE_INTEGER.
>>
>> v4: https://lore.kernel.org/platform-driver-x86/20250117081347.8573-1-kuurtb@gmail.com/
>>
>> Kurt Borja (14):
>> platform/x86: alienware-wmi: Add a state container for LED control
>> feature
>> platform/x86: alienware-wmi: Add WMI Drivers
>> platform/x86: alienware-wmi: Add a state container for thermal control
>> methods
>> platform/x86: alienware-wmi: Refactor LED control methods
>> platform/x86: alienware-wmi: Refactor hdmi, amplifier, deepslp methods
>> platform/x86: alienware-wmi: Refactor thermal control methods
>> platform/x86: alienware-wmi: Split DMI table
>> MAINTAINERS: Update ALIENWARE WMI DRIVER entry
>> platform/x86: Rename alienware-wmi.c
>> platform/x86: Add alienware-wmi.h
>> platform/x86: Split the alienware-wmi driver
>> platform/x86: dell: Modify Makefile alignment
>> platform/x86: Update alienware-wmi config entries
>> platform/x86: alienware-wmi: Update header and module information
>>
>> MAINTAINERS | 4 +-
>> drivers/platform/x86/dell/Kconfig | 30 +-
>> drivers/platform/x86/dell/Makefile | 45 +-
>> .../platform/x86/dell/alienware-wmi-base.c | 488 +++++++
>> .../platform/x86/dell/alienware-wmi-legacy.c | 101 ++
>> .../platform/x86/dell/alienware-wmi-wmax.c | 774 +++++++++++
>> drivers/platform/x86/dell/alienware-wmi.c | 1235 -----------------
>> drivers/platform/x86/dell/alienware-wmi.h | 102 ++
>> 8 files changed, 1517 insertions(+), 1262 deletions(-)
>> create mode 100644 drivers/platform/x86/dell/alienware-wmi-base.c
>> create mode 100644 drivers/platform/x86/dell/alienware-wmi-legacy.c
>> create mode 100644 drivers/platform/x86/dell/alienware-wmi-wmax.c
>> delete mode 100644 drivers/platform/x86/dell/alienware-wmi.c
>> create mode 100644 drivers/platform/x86/dell/alienware-wmi.h
>>
>>
>> base-commit: 4055e18bfbb7cf077da2bfd74615604b6ca51c6f