From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 88B227E1 for ; Mon, 20 Jan 2025 08:45:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.158.5 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737362720; cv=none; b=cgSWsbEvdfFhf+AVWQswwHnDZAMOPSv7H5Fv50m5r+7U0QMq8W57f48Bykev0TNFNoRj2YJLs7L7/gUYF2k4NUmlEvr10n3MXrUiZLN79481hzQRRLhUUJWJbfsrIvbqGXFFv1/ut7pn9wIuxKyBoVQyTfGQRJ8322uPuqcClYA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737362720; c=relaxed/simple; bh=ZwPHt3SAS1s/ym+TUeN6yO1+HC8+CcCATUtq+WojTj4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=q7DOp330m+uecPl+EVhU+RnZQQ/GmYkOmGi8AX3V0huXGRsY+rNYp5LLoCYBWvKiGXji/382Uodza1SHRfMj9TOFf06EXjotkNOh2geaeZXTZwwtMlKsuLI0/YeVHsqic5oRKUs2D01invDZqto1mZJijR55voUYqHDJKTaNTk0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=f04EnQ5W; arc=none smtp.client-ip=148.163.158.5 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="f04EnQ5W" Received: from pps.filterd (m0356516.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 50JLoiI9027545; Mon, 20 Jan 2025 08:45:08 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=pp1; bh=ZwPHt3SAS1s/ym+TU eN6yO1+HC8+CcCATUtq+WojTj4=; b=f04EnQ5WGsB9ZmqEK67uBW7Ux2XIWXR+S waIRc+2eNUsjSt/V+h2/qL8ilnh5An+7fu8DLo1tL7pHe+icjKAGTTlGeFjY3old NF0JEXmZjXt7ykvRPR09+NNj273joENUT+o+dmtJhH4Sy+a1FyNf2iUzKGWjsCK5 0uoPwD5Af/HPRwEeYSg7agUlMkPmJw0ALhvo+KzvsbkBmySzSwNKzTFBBF1HdCzr 40MzeHnDHPMwfO8oXCeUr9GaqlEnIYbmIZFKBDwiaQBXOKETNPh9rETzWXCNuJi1 wnOlOkWrhtBFDyo9rnyH6uXdde+kqeIZUJ2jWyXFmkr4Hl91HGhWw== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 44947stww8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 20 Jan 2025 08:45:07 +0000 (GMT) Received: from m0356516.ppops.net (m0356516.ppops.net [127.0.0.1]) by pps.reinject (8.18.0.8/8.18.0.8) with ESMTP id 50K8eh9t003413; Mon, 20 Jan 2025 08:45:07 GMT Received: from ppma22.wdc07v.mail.ibm.com (5c.69.3da9.ip4.static.sl-reverse.com [169.61.105.92]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 44947stww6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 20 Jan 2025 08:45:07 +0000 (GMT) Received: from pps.filterd (ppma22.wdc07v.mail.ibm.com [127.0.0.1]) by ppma22.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 50K7494r024258; Mon, 20 Jan 2025 08:45:06 GMT Received: from smtprelay01.fra02v.mail.ibm.com ([9.218.2.227]) by ppma22.wdc07v.mail.ibm.com (PPS) with ESMTPS id 448q0xwmyd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 20 Jan 2025 08:45:06 +0000 Received: from smtpav02.fra02v.mail.ibm.com (smtpav02.fra02v.mail.ibm.com [10.20.54.101]) by smtprelay01.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 50K8j40757213196 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 20 Jan 2025 08:45:04 GMT Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 5F15F20043; Mon, 20 Jan 2025 08:45:04 +0000 (GMT) Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id CEAA520040; Mon, 20 Jan 2025 08:44:58 +0000 (GMT) Received: from li-fdfde5cc-27d0-11b2-a85c-e224154bf6d4.ibm.com.com (unknown [9.43.90.245]) by smtpav02.fra02v.mail.ibm.com (Postfix) with ESMTP; Mon, 20 Jan 2025 08:44:58 +0000 (GMT) From: Madadi Vineeth Reddy To: vineethr@linux.ibm.com Cc: bsegall@google.com, dietmar.eggemann@arm.com, gautham.shenoy@amd.com, juri.lelli@redhat.com, kprateek.nayak@amd.com, linux-kernel@vger.kernel.org, mgorman@suse.de, mingo@redhat.com, peterz@infradead.org, rostedt@goodmis.org, swapnil.sapkal@amd.com, vincent.guittot@linaro.org, vschneid@redhat.com Subject: Re: [PATCH] sched/fair: Fix inaccurate h_nr_runnable accounting with delayed dequeue Date: Mon, 20 Jan 2025 14:14:41 +0530 Message-ID: <20250120084441.17746-1-vineethr@linux.ibm.com> X-Mailer: git-send-email 2.47.0 In-Reply-To: <20250120050639.48966-1-vineethr@linux.ibm.com> References: <20250120050639.48966-1-vineethr@linux.ibm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: tLfjXA1X19HnJ_7fdsFNR5uj1ZkjF5Jk X-Proofpoint-ORIG-GUID: Pec-BTnXENRyJPF3VeE_5h3U6LkwW4_q X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1057,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-01-20_01,2025-01-20_02,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=999 malwarescore=0 lowpriorityscore=0 bulkscore=0 priorityscore=1501 clxscore=1015 impostorscore=0 phishscore=0 adultscore=0 spamscore=0 suspectscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2411120000 definitions=main-2501200070 > However, I was unable to trigger the WARN_ON by running hackbench in a > cgroup without the patch. Could you please share the specific test > scenario or configuration you used to reproduce it? My mistake: SCHED_WARN_ON is a WARN_ONCE, so I had to clear it before running hackbench to ensure the WARN_ON could be triggered again. Now I am able to trigger the WARN_ON in the unpatched kernel while running hackbench after executing `echo 1 > /sys/kernel/debug/clear_warn_once` following the initial warning during the boot process. I have verified that the patched kernel fixes the issue. Thanks, Madadi Vineeth Reddy