From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 252D9199EB7 for ; Mon, 20 Jan 2025 21:39:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737409187; cv=none; b=i2XaSFvibaoxqT1xqVCL0H9OoKiWrOUtF4xwUerBnyE4XQNjPUe6MZdHRXNWmyfGrTLXKrvyRrJeM0V/d1Gtv/K1S/JydBmuDNwlI/4+uX5lavOzAdVwSAiAQ99NupNSwxH7mNy1ksDc4QnT6xuJO/8MJpZq1sJOaafq1CA/qDs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737409187; c=relaxed/simple; bh=KkG4pmRBZ3EjDPcOp+dvf6T5YqEODAZmHTGhKab06ec=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=nZ2rBQgQaGlVFLjaKy6c4Vu/ffqK//crZDPPOYOoe0LqQMjrVq3ueqpwtrrjyAtwIBIMNKkggC2da3/w/7gkPsJuPupxOrO0cI6C85jYPoBPrCa1iX4+63ZQwjY2c25n3/oGbyPnWtup9nbsDP5cNnxnJ35NBZnxDYGS8PpwIsk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=kR9LhukF; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="kR9LhukF" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 84D32C4CEDD; Mon, 20 Jan 2025 21:39:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1737409186; bh=KkG4pmRBZ3EjDPcOp+dvf6T5YqEODAZmHTGhKab06ec=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=kR9LhukFQ9XgsXiEqrG+f+2WKYra/TLTCZKVmBWSIpCxhRWegkOhRbFpzng6N1LJi 6XPnOh6U04TOJkAIIYxexGvhZSv5jn48qXIVL7s9WbiJMIY9Xv3KFEt3l8xo8VWD6N RH2RNO+sK1hZzTpUJ1oWulH9CLdFYEwmJ5cF8Pw3xxoOFH/vQHsOFkoATlbJjnmSbc PlbqKK/3IptoS51jfB0JTguu+4XGcY17B2sY2jXNfz4flTwj9YGUpeG9G4C/JCfGah h10UPRrabLaC3Ad6SGwqZy00f4N7Auca9Iy3kzThvyiUBwE3wsX1yL6rJ4tHafwJB3 1VRz8EDl6mM0A== Date: Mon, 20 Jan 2025 13:39:43 -0800 From: Kees Cook To: =?iso-8859-1?Q?Micka=EBl_Sala=FCn?= Cc: Sasha Levin , Linus Torvalds , linux-kernel@vger.kernel.org, Al Viro , Andy Lutomirski , Christian Brauner , =?iso-8859-1?Q?G=FCnther?= Noack , Jeff Xu , Mimi Zohar , =?iso-8859-1?Q?N=EDcolas_F=2E_R=2E_A=2E?= Prado , Paul Moore , Roberto Sassu , Serge Hallyn , Shuah Khan , Stefan Berger , Nathan Chancellor Subject: Re: [GIT PULL] AT_EXECVE_CHECK introduction for v6.14-rc1 Message-ID: <202501201338.0B67E054BA@keescook> References: <202501151612.CE6D0686@keescook> <20250120.kab5eeng5Yai@digikod.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20250120.kab5eeng5Yai@digikod.net> On Mon, Jan 20, 2025 at 10:03:07AM +0100, Mickaël Salaün wrote: > On Sun, Jan 19, 2025 at 07:08:54PM -0500, Sasha Levin wrote: > > On Wed, Jan 15, 2025 at 04:18:07PM -0800, Kees Cook wrote: > > > Hi Linus, > > > > > > Please pull the AT_EXECVE_CHECK introduction for v6.14-rc1. I split > > > this series from the core execve tree since it's had a life of its own > > > as it has progressed from O_MAY_EXEC. :) This provides userspace with > > > a way to opt in to performing "execability" checks for things that are > > > executable but don't pass through execve(2) (e.g. scripts, dlopen libs, > > > etc). It's seen quite a bit of discussion and review, and has lived in > > > -next for the entire dev cycle. Included is documentation, samples, and > > > extensive selftests. > > > > > > Thanks! > > > > > > -Kees > > > > > > The following changes since commit fac04efc5c793dccbd07e2d59af9f90b7fc0dca4: > > > > > > Linux 6.13-rc2 (2024-12-08 14:03:39 -0800) > > > > > > are available in the Git repository at: > > > > > > https://git.kernel.org/pub/scm/linux/kernel/git/kees/linux.git tags/AT_EXECVE_CHECK-v6.14-rc1 > > > > Hey Kees, > > > > LKFT has caught a build error with one of the samples: > > > > /builds/linux/samples/check-exec/inc.c: In function 'interpret_stream': > > /builds/linux/samples/check-exec/inc.c:81:8: warning: implicit declaration of function 'execveat'; did you mean 'execve'? [-Wimplicit-function-declaration] > > err = execveat(fileno(script), "", script_argv, envp, > > ^~~~~~~~ > > execve > > > > The full log is here: https://qa-reports.linaro.org/lkft/sashal-linus-next/build/v6.13-rc7-511-g109a8e0fa9d6/testrun/26809210/suite/build/test/gcc-8-allyesconfig/log > > Hi Sasha, > > Nathan caught this sample build issue last week too. The fix is here: > https://lore.kernel.org/r/20250115144753.311152-1-mic@digikod.net I intend to get the fix to Linus as soon as he looks at the original PR. I don't want to create churn here. If it gets pulled, I'll send the fix. If it gets dropped, we can add the fix to the tree and see where we stand. -- Kees Cook