From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f170.google.com (mail-qk1-f170.google.com [209.85.222.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 781DF1E2854 for ; Mon, 20 Jan 2025 13:59:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737381577; cv=none; b=OplYVYXvfM+atFJJBirYh7cmO2FQLgoFttHguL3xlmoOalym6c4WkpM04UiR0jUoG87U4AR/+7wDyaotlSJEVkMw+pfGfvhWJMV06e9NriaU6lIgV63Hes4wXTnW8Ni1p4OeQKOX4hhvvC9RucWm0V5sOTiHufcg46zF01l1inw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737381577; c=relaxed/simple; bh=R9UuZ10091tIn/30XWCOiokJdfB+dwU6cOauDpgnyh8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=u/eon2qgaFXg3uZfMF5Tly9UgmvN7X++aHqk3ZFhva+3/2tpcIfAGUazyf3JyZ57T+4/N92PQXT5RFLIZ5ufkMySPCqRLYvIpMiQgB9MREIuCRftfTtFkKFIqUttVPiZ5jGBBbSlSaPgtzBmbj/lqhDxyCpTPRvcdqx3t/reRzs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca; spf=pass smtp.mailfrom=ziepe.ca; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b=U9HvL4uf; arc=none smtp.client-ip=209.85.222.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="U9HvL4uf" Received: by mail-qk1-f170.google.com with SMTP id af79cd13be357-7be3f230436so418684085a.3 for ; Mon, 20 Jan 2025 05:59:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1737381574; x=1737986374; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=R9UuZ10091tIn/30XWCOiokJdfB+dwU6cOauDpgnyh8=; b=U9HvL4ufaziM4xBx9X6TtqaEa54oXNBS7Ns8+Oi9BBc3Q0MESOn+3/rsSo3lq0ObtI +BKth8MThNEZYPdBzopGZaIbAka8qgFOhLBEXjGg+Kg98F+sCIT10Y1tqGWTXFszWijM 95W224szQL6yRN3mcO2yVtcY+vbA0d/SzCjPF1FBh6qRS/FdX8yBnODV19uC9dA1ZOfT ECF4ztg4+pc/fGEJ7oNvVBlZg8hHyRIAFbplGcu8pO/AX1EI7TQt7ynCNUkFV1IgLEqu TmaZg0BDqY07W8IOQ1kYV3wsxGOx/WuIMV9ebS+ZVQ13u+sz3f3MmxLkBK9Q9OIfwpJJ pykQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737381574; x=1737986374; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=R9UuZ10091tIn/30XWCOiokJdfB+dwU6cOauDpgnyh8=; b=WfSU1FpR5FV9VlF/3qpFWVjh2F4ZsE0OZALnS0vE6ZM1jyBGm9DvekfXJuCNsmdJWO P50UD8OooXYzEjq/nGZJ0KxOSA+itiKsJVtNFy2KfpsE4negoEglm9dGHyyrv6/gS0p8 H5hPdEr+sVuRB7t/mtAGziVvdzWdW3uaV6e/3NsUoF00+NeShYPs9IyZ2gEb+rRm7ULg 8/dPxft5YGdj0S8rsE5XjYqu8uBprDSRy96BmxVLYxFAa9RRwAZdT1FXWtN7rexjFPOm kW3aaZEJIzUfcuP4/EsWxThrrQrZp/wUnSLKXQ9wSPtrsYByBXWBKi/vctAX0gdg9H47 iyBA== X-Forwarded-Encrypted: i=1; AJvYcCVl3c3PA2fh3gQgo3gj0t6OFBCjqf2xtM8JItDnJlCtc0SVGC51XAH4mZlZOkHoU/ppPGlgfmwFSZgsUfQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yw1NRcEOBWyF4qgdibAQDgkV3sV/mPTy1C9k8D1KYC4OctrvCpZ y5ppcTXUCJEM2aKONVYGorbzAS+ddaaDDHxG2fLwzahtJ81zN6ecVLIoAp2p+Pw= X-Gm-Gg: ASbGnctY2rhb5bJPEAPtkR1oYB9Z7Z0WTBzBOaaVeqkupeuQ3J7WKPI4jSz33X5Agww ShIjoaKA0/Jp39FKzRVpYOpQmTYHoLV+5k93DGYUBdXu9ijk9xM1Kb4DIRs/XswfIHjNAavkDWW PCzS4frTfMqe6LTDIhlsh2kSkdwSkV9yMY8o5lZ0BdDtih1M1JG1gDBwhbjDZ4Z0GtEohmhrgQ7 3f2sy8duk0zSkD2wHjA7q/iHuJJ4KM8DJWPrQEn0Q5TA9lFHUVtI7QbKJKHuP8yHpJnnjUsslRJ M9kZpu9rZqhVAtgFIvxQFK4+uI85cErKbR5vcPB4uNc= X-Google-Smtp-Source: AGHT+IHXw5XwlAOVQM5DmvsT9Jphrpd/TgpL5J7UWvahF7YSM4NY2jfkZTX/ettpphOLDZrPgY8dFw== X-Received: by 2002:a05:620a:2849:b0:7b6:c2bf:3eeb with SMTP id af79cd13be357-7be6318021bmr2068444285a.0.1737381574398; Mon, 20 Jan 2025 05:59:34 -0800 (PST) Received: from ziepe.ca (hlfxns017vw-142-68-128-5.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.68.128.5]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-46e102fc99asm43201701cf.29.2025.01.20.05.59.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jan 2025 05:59:33 -0800 (PST) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1tZsJR-00000003PaH-1oaY; Mon, 20 Jan 2025 09:59:33 -0400 Date: Mon, 20 Jan 2025 09:59:33 -0400 From: Jason Gunthorpe To: Wencheng Yang Cc: Joerg Roedel , Suravee Suthikulpanit , Will Deacon , Robin Murphy , Alex Williamson , iommu@lists.linux.dev, linux-kernel@vger.kernel.org, kvm@vger.kernel.org Subject: Re: [PATCH v2] drviers/iommu/amd: support P2P access through IOMMU when SME is enabled Message-ID: <20250120135933.GJ674319@ziepe.ca> References: <20250117071423.469880-1-east.moutain.yang@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250117071423.469880-1-east.moutain.yang@gmail.com> On Fri, Jan 17, 2025 at 03:14:18PM +0800, Wencheng Yang wrote: > When SME is enabled, memory encryption bit is set in IOMMU page table > pte entry, it works fine if the pfn of the pte entry is memory. > However, if the pfn is MMIO address, for example, map other device's mmio > space to its io page table, in such situation, setting memory encryption > bit in pte would cause P2P failure. This doesn't seem entirely right to me, the encrypted bit should flow in from the entity doing the map and be based on more detailed knowledge about what is happening. Not be guessed at inside the iommu. We have non-encrpyted CPU memory, and (someday) encrypted MMIO. Jason