public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Takashi Iwai <tiwai@suse.de>, Eric Biggers <ebiggers@kernel.org>
Cc: Baojun Xu <baojun.xu@ti.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Linux Next Mailing List <linux-next@vger.kernel.org>
Subject: linux-next: build failure after merge of the crc and sound trees
Date: Mon, 20 Jan 2025 18:17:44 +1100	[thread overview]
Message-ID: <20250120181744.6433557e@canb.auug.org.au> (raw)

[-- Attachment #1: Type: text/plain, Size: 1976 bytes --]

Hi all,

After merging the crc tree, today's linux-next build (x86_64
allmodconfig) failed like this:

In file included from lib/gen_crc32table.c:5:
lib/crc32defs.h:13:10: warning: "CRC_LE_BITS" redefined
   13 | # define CRC_LE_BITS 8
      |          ^~~~~~~~~~~
lib/crc32defs.h:5:10: note: this is the location of the previous definition
    5 | # define CRC_LE_BITS 64
      |          ^~~~~~~~~~~
lib/crc32defs.h:14:10: warning: "CRC_BE_BITS" redefined
   14 | # define CRC_BE_BITS 8
      |          ^~~~~~~~~~~
lib/crc32defs.h:6:10: note: this is the location of the previous definition
    6 | # define CRC_BE_BITS 64
      |          ^~~~~~~~~~~
In file included from lib/crc32.c:34:
lib/crc32defs.h:13:10: error: "CRC_LE_BITS" redefined [-Werror]
   13 | # define CRC_LE_BITS 8
      |          ^~~~~~~~~~~
lib/crc32defs.h:5:10: note: this is the location of the previous definition
    5 | # define CRC_LE_BITS 64
      |          ^~~~~~~~~~~
lib/crc32defs.h:14:10: error: "CRC_BE_BITS" redefined [-Werror]
   14 | # define CRC_BE_BITS 8
      |          ^~~~~~~~~~~
lib/crc32defs.h:6:10: note: this is the location of the previous definition
    6 | # define CRC_BE_BITS 64
      |          ^~~~~~~~~~~
cc1: all warnings being treated as errors

Probably caused by commit

  bb5f86ea50ff ("ALSA: hda/tas2781: Add tas2781 hda SPI driver")

from the sound tree - it selects CRC32_SARWATE.

$ grep CONFIG_CRC32_ .config
CONFIG_CRC32_IMPL_ARCH_PLUS_SLICEBY8=y
# CONFIG_CRC32_IMPL_ARCH_PLUS_SLICEBY1 is not set
# CONFIG_CRC32_IMPL_SLICEBY8 is not set
# CONFIG_CRC32_IMPL_SLICEBY4 is not set
# CONFIG_CRC32_IMPL_SLICEBY1 is not set
# CONFIG_CRC32_IMPL_BIT is not set
CONFIG_CRC32_ARCH=y
CONFIG_CRC32_SLICEBY8=y
CONFIG_CRC32_SARWATE=y

It looks like lib/crc32defs.h does not expect these last 2 to be enabled
at the same time.

I have reverted the above sound tree commit for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

             reply	other threads:[~2025-01-20  7:18 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-20  7:17 Stephen Rothwell [this message]
2025-01-20  7:28 ` linux-next: build failure after merge of the crc and sound trees Eric Biggers
2025-01-20  7:42   ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250120181744.6433557e@canb.auug.org.au \
    --to=sfr@canb.auug.org.au \
    --cc=baojun.xu@ti.com \
    --cc=ebiggers@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox