RE: [EXT] Re: [PATCH v12 4/5] firmware: imx: add driver for NXP EdgeLock Enclave

Pankaj Gupta
2025-01-22T12:55:27Z

[-- Attachment #1: Type: text/plain, Size: 2243 bytes --]

> You got comment on this, more than once.

> Rest of the email is poorly formatted, so I am just skimming through it.
> Fix your email program to send readable content if you want some answers for
> stuff I missed. I expect all my comments fully addressed, not just some of
> them.

There is a bug in the outlook.
I will remove these lines in my replies.

>>>> + +static int se_if_probe(struct platform_device *pdev) { +
>>>> const struct se_if_node_info_list *info_list; + const struct
>>>> se_if_node_info *info; + struct device *dev = &pdev->>dev;
>>>> + struct se_fw_load_info *load_fw; + struct se_if_priv
>>>> *priv; + u32 idx; + int ret; +q + idx =
>>>> GET_IDX_FROM_DEV_NODE_NAME(dev->>of_node);
>
>> NAK. Node can be called firmware and your entire driver collapes.
> The macro is updated to verify the correct-ness of node-name.

> NAK, do you understand the term? I provided the reasons for NAK.
Your suggestion is to enable the driver for all allowed node names.
1. firmware
2. secure
3. secure-enclave

Understood, will allow these names for the driver.

>
> + (!memcmp(dev_of_node->full_name, NODE_NAME,
> strlen(NODE_NAME)) ?\ ((strlen(dev_of_node->full_name) >
> strlen(NODE_NAME)) ?\ GET_ASCII_TO_U8((strlen(dev_of_node-
> >full_name) - strlen(NODE_NAME)),\ dev_of_node-
> >full_name[strlen(NODE_NAME) + 1], \ -
> dev_of_node->full_name[strlen(NODE_NAME) + 2]) : 0)
> + dev_of_node-
> >full_name[strlen(NODE_NAME) + 2]) : 0) : -EINVAL)
>
>>>> + info_list = device_get_match_data(dev); + if (idx >>=
>>>> info_list->>num_mu) { + dev_err(dev,
>>>> + "Incorrect node name :%s\n",
>>>> + dev->>of_node->>full_name);
>>
>>> Nope. "firmware" or "secure" are correct node names.
>> New check is added to validate the correctness of the node name for
>> this driver. Replaced the message of " Incorrect node name..", with
>> the help message.

> You did not resolve the NAK.
> 1. You cannot reject correct names.
Ok, Understood.
>2. You cannot add undocumented ABI. You could try to document it, but it will
>not solve the first problem.
Ok. Will not add the ABI document.

Best regards,
Krzysztof

[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 11094 bytes --]