Re: [EXT] Re: [PATCH v12 2/5] dt-bindings: arm: fsl: add imx-se-fw binding doc

Frank Li
2025-01-22T19:46:42Z

On Wed, Jan 22, 2025 at 06:26:55PM +0000, Conor Dooley wrote:
> On Wed, Jan 22, 2025 at 11:35:50AM +0100, Krzysztof Kozlowski wrote:
> > On 20/01/2025 16:01, Krzysztof Kozlowski wrote:
> > > On 20/01/2025 14:07, Pankaj Gupta wrote:
> > >>> Driver configures multiple misc-device on the MU, for multiple
> > >>> user-space applications, to be able to communicate over single MU.
> > >>>
> > >>> It exists on some i.MX processors. e.g. i.MX8ULP, i.MX93 etc.
> > >>>
> > >>> Signed-off-by: Pankaj Gupta <pankaj.gupta@nxp.com>
> > >>> Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
> > >>> Reviewed-by: Conor Dooley <conor@kernel.org>
> > >>
> > >>> Where Conor's review tag was actually given?
> > >> On v6.
> > >
> > > I already looked there. No trace for tag. Please point to the message.
> >
> >
> > Still no answer from you, except that evading answer, so let's be clear:
> > don't create fake tags.
> >
> > Clean your patchset from all fake tags and keep only the ones which were
> > real.
>
> Ye, I don't see that R-b given either. My guess is that somehow "go for
> it :+1: was interpreted as one, but it certainly was not meant to be
> one. Converting that to a tag is definitely not okay. Seems it appeared
> in v9 after Rob prompted about /his/ missing review from v8. I never use
> my k.org email in tags, so that is an immediate red flag. I think I never
> re-opened this thread after seeing that Rob had approved it back in v8,
> so I never noticed. Only by chance that I opened in now.
>
> Thanks for spotting it :)

Pankaj Gupta:

Please use 'b4.sh trailers --update' to avoid this problem in
future.

Frank