Re: [PATCH V10 4/4] perf/x86/intel: Support PEBS counters snapshotting

Liang, Kan
2025-02-04T21:09:13Z

Hi Peter,

On 2025-01-27 10:51 a.m., Peter Zijlstra wrote:
> On Tue, Jan 21, 2025 at 07:23:03AM -0800, kan.liang@linux.intel.com wrote:
>
>> @@ -471,6 +477,15 @@ struct pebs_xmm {
>>
>> #define IBS_CPUID_FEATURES 0x8000001b
>>
>> +struct pebs_cntr_header {
>> + u32 cntr;
>> + u32 fixed;
>> + u32 metrics;
>> + u32 reserved;
>> +};
>> +
>> +#define INTEL_CNTR_METRICS 0x3
>
> I've moved this up a little, so that all the adaptive pebs crud is
> together.
>
> Other than that, I've picked up these patches and will merge the lot
> past -rc1.
>

We found a bug when testing with some non-precise events in freq mode.
I've submitted a patch to fix it.
https://lore.kernel.org/lkml/20250204210514.4089680-1-kan.liang@linux.intel.com/

Could you please fold it into the patch ("perf/x86/intel: Support PEBS
counters snapshotting")?

Sorry for any inconvenience.

Thanks,
Kan