From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f182.google.com (mail-qk1-f182.google.com [209.85.222.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2929BECF for ; Wed, 22 Jan 2025 00:08:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737504511; cv=none; b=T8JxssPDKct0XSzUoNKQ/j+C/qLnyRiw7idBxrvrB9G7ci7l8iMP3xrRhyL2g+iHiBXOWv/9roIElURZKQTMsI01PjKTU4UYTV2fd/UGwqiJaKa2HpIXy+PBjlh67XHx1AWthfQjaWHAhJ0ba236g7kNWgmXJphW3u4hslar1g8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737504511; c=relaxed/simple; bh=+ZC5sXaNDLr05BnhSvh2Hwr095nazmaxT/b8OpYJ8q4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=q77pmX3T+9IOPXZArB0hDduryIkxaCM0ykgf/+bSKGqbrVsRQr0XYLg9PrFCtMCFFegRaWp3lybEE8a3lhmjD+jHLSmVM5hRCM2IorLDKNHHbaZBSp/EzXuHRK6c8KomGacr+jbkh83wVOl+BGyhOPZf9lHGog4gZKIbDd1AJl0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=konsulko.com; spf=pass smtp.mailfrom=konsulko.com; dkim=pass (1024-bit key) header.d=konsulko.com header.i=@konsulko.com header.b=mQkA+V4L; arc=none smtp.client-ip=209.85.222.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=konsulko.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=konsulko.com header.i=@konsulko.com header.b="mQkA+V4L" Received: by mail-qk1-f182.google.com with SMTP id af79cd13be357-7b6e8814842so624666485a.0 for ; Tue, 21 Jan 2025 16:08:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; t=1737504509; x=1738109309; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=DFtEywxzwLn/5hY1Yp58SHzzolHb4GO9rJXvLL/rCW4=; b=mQkA+V4L2FqabpphhfEZVuROveXfEergecwomloGKG94mE3nX2eKNfPBZh4DPVk1gM cVXWz8JZRoda1iSjUQ0aDHnXaAC6hcklFc6RnhT5o4iQCcTLdOWQ6qwjkIexVNeMnbQR /Dy45WDfSGU8U516wzbrSr+wczJhV1GTLvkTU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737504509; x=1738109309; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=DFtEywxzwLn/5hY1Yp58SHzzolHb4GO9rJXvLL/rCW4=; b=tMmmuS12jUgbG+OLmFUxEMkEmJm4rxa+/1o57khjTUlRQ03duCYuf2xRQbXH754C1a jRo18VsucfYO70gbsZ8f+PahVm1drSzRhDEPhFfBKcZ8wDwA66BWSxbAaQea0mRzbi+n RvzDLoXaK9UZR5KP9cJPxPg8mbNDUPBYYGVYsWPOsAXbTa4gtzeTR0XqeaZqmLSPnixG LXmjHmNXAWT3t5HT6/65hNdwnPS1TfSrYHPjpETpkMk8UydWSe+U4a53F9polna6TasZ Mdxr1cey5vVCs7ek47G4BGUHZjkuhLV7fktOFkpNadnsKMVvKhgn8tq9n0BtO6xyJ83J uwVw== X-Gm-Message-State: AOJu0YwWf1lv2nG1JJ0oC1KVpuTVlQbzupaEFG4paw0foxXha3kKclYC w4jrfOiGvZoQVsw0dnLXRPwlLBIPvNO6/RbqZHPTBwo2X7eyiNW8SVeloFFQLmJHz4snxU1lMPs I X-Gm-Gg: ASbGncve7HyuK9cLOzuS/Cxd8YUzkGbw07YHH/unwi9X5FiRljYbeZrLikzPfC0nAcK 6LQRrFeebtXFQWCYdQixhD5xY99Yiqkn9KHZxRoW4RtObYdhogZ5nX8Wx+grSfMDtNAN+YQKbQk 9tcX5511XepCgRJdvmuMfnqjBHJe1IKVGF3+v5bKI4MxfmQ0nglNL/FCMXBrCQ25Lqlsz4B0QL6 KZ5rE0AVnNib+kopC4GFfOwr5iAOfQDYhRj+oaDtN7qMC/5mKotU3R5KK/tPOw7XTk= X-Google-Smtp-Source: AGHT+IFCOLUgFwqrCBgadGAInk+tW1W40iTqcVVVuwmHUvEcBdGhd7yiaD9Mxpuotd0LXZxxSMwvdw== X-Received: by 2002:a05:620a:400d:b0:7b7:1118:907e with SMTP id af79cd13be357-7be632761aamr2908732885a.52.1737504508895; Tue, 21 Jan 2025 16:08:28 -0800 (PST) Received: from bill-the-cat ([187.144.16.9]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7be614ef2d7sm606517885a.96.2025.01.21.16.08.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Jan 2025 16:08:27 -0800 (PST) Date: Tue, 21 Jan 2025 18:08:24 -0600 From: Tom Rini To: Kevin Hilman Cc: linux-kernel@vger.kernel.org, Nishanth Menon , Tony Lindgren , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-omap@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH] ARM: dts: omap4-panda-a4: Add missing model and compatible properties Message-ID: <20250122000824.GJ3476@bill-the-cat> References: <20250121200749.4131923-1-trini@konsulko.com> <7hmsfjn5mm.fsf@baylibre.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="bPCTNTKKZLjl67oG" Content-Disposition: inline In-Reply-To: <7hmsfjn5mm.fsf@baylibre.com> X-Clacks-Overhead: GNU Terry Pratchett --bPCTNTKKZLjl67oG Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jan 21, 2025 at 02:50:41PM -0800, Kevin Hilman wrote: > Hi Tom, >=20 > Tom Rini writes: >=20 > > When moving the model and compatible properties out of the common > > Pandaboard files and in to the specific boards, the omap4-panda-a4 > > file wasn't updated as well and so has lacked a model and compatible > > entry ever since. > > > > Fixes: a1a57abaaf82 ("ARM: dts: omap4-panda: Fix model and SoC family d= etails") > > Signed-off-by: Tom Rini > > --- >=20 > Checkpatch tells me: >=20 > WARNING: DT compatible string "ti,omap4-panda-a4" appears un-documented >=20 > So I think Documentation/devicetree/bindings/arm/ti/omap.yaml needs an > update too. (and note the binding update should be a separate patch[1]) Regular panda is there, so yeah, it's easy enough to add the a4 variant. I assume if I post that they'll get merged in the right order? > > Given how long this has been broken it's entirely plausible no a4 > > hardware even exists anymore and so dropping this file instead makes > > sense. I only found this because scripts/make_fit.py crashed on these > > properties being missing. >=20 > If keeping it is just this binding update, then I'd say we keep it, but > if it gets any more paninful to maintain, I'm also not going to argue > very hard to keep it. I'm not in the position to see if any of the Pandaboards work at this point, so I don't know if they're otherwise functional or a huge pile of problems. --=20 Tom --bPCTNTKKZLjl67oG Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmeQNvQACgkQFHw5/5Y0 tyyBbgv/brHvHtQZc6qTgaRbq45kaXrC87/5zJZKBVuwIVeXNLBk6dl6Rp+o8ZtM Tru0I5MxrhF/jRAlwnLhRu+aT4/H9F853EOWbxEn2zxl+jI4h6qHNovprQNFMuDg KygD/OKzgRwRizuXmS6BPtXSAa0MSDOSAG136iAGC9IEBmAzIrtqJR5XTo+mZGwV iwoI+KvxZBqErWGT89Q5Fbczv/M59rFVaNyOAv6Rhpx0Dr+gzc+M564Z/L9fwpLV LJ0jfvV12cRNA67iAzmXYVmSn4vudR77NyqsdCAHEhTFxem57tqkzHiv9VACGJgh NLGXxd5tTqdqaaxvyb4jjfFUgysTJlN+QOulncpx4SR0uB7FFaWzPpotsNK60kHB iQf3LPDSDmldS0Ue21Mb+Sl9M2DV6gMQo7Cnrw/Y6+PnpEuXiEItgvRA38wrZQt5 /IfUY5BRy4MQHmZnngrCIPK+U5ri41WZLnZP0eVvGfk0o/Y1wYvgvducEzaJe2Qo wt/at/Oz =Tq/Z -----END PGP SIGNATURE----- --bPCTNTKKZLjl67oG--