* [PATCH] ASoC: fsl_asrc_m2m: select CONFIG_DMA_SHARED_BUFFER
@ 2025-01-22 6:53 Arnd Bergmann
2025-01-22 8:24 ` Daniel Baluta
2025-01-23 11:29 ` Mark Brown
0 siblings, 2 replies; 3+ messages in thread
From: Arnd Bergmann @ 2025-01-22 6:53 UTC (permalink / raw)
To: Mark Brown, Shengjiu Wang
Cc: Arnd Bergmann, Liam Girdwood, Jaroslav Kysela, Takashi Iwai,
Sudeep Holla, Elinor Montmasson, Piotr Wojtaszczyk, linux-sound,
linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
Randconfig builds without dmabuf result in this link error from
the fasl-asrc driver:
ERROR: modpost: "dma_buf_put" [sound/core/snd-compress.ko] undefined!
ERROR: modpost: "dma_buf_export" [sound/soc/fsl/snd-soc-fsl-asrc.ko] undefined!
Add the missing 'select' statement.
Fixes: 24a01710f627 ("ASoC: fsl_asrc_m2m: Add memory to memory function")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
sound/soc/fsl/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/soc/fsl/Kconfig b/sound/soc/fsl/Kconfig
index e5fbf5305ea2..c4cf3cff58de 100644
--- a/sound/soc/fsl/Kconfig
+++ b/sound/soc/fsl/Kconfig
@@ -6,6 +6,7 @@ comment "Common SoC Audio options for Freescale CPUs:"
config SND_SOC_FSL_ASRC
tristate "Asynchronous Sample Rate Converter (ASRC) module support"
depends on HAS_DMA
+ select DMA_SHARED_BUFFER
select REGMAP_MMIO
select SND_SOC_GENERIC_DMAENGINE_PCM
select SND_COMPRESS_ACCEL
--
2.39.5
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] ASoC: fsl_asrc_m2m: select CONFIG_DMA_SHARED_BUFFER
2025-01-22 6:53 [PATCH] ASoC: fsl_asrc_m2m: select CONFIG_DMA_SHARED_BUFFER Arnd Bergmann
@ 2025-01-22 8:24 ` Daniel Baluta
2025-01-23 11:29 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Daniel Baluta @ 2025-01-22 8:24 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Mark Brown, Shengjiu Wang, Arnd Bergmann, Liam Girdwood,
Jaroslav Kysela, Takashi Iwai, Sudeep Holla, Elinor Montmasson,
Piotr Wojtaszczyk, linux-sound, linux-kernel
On Wed, Jan 22, 2025 at 8:53 AM Arnd Bergmann <arnd@kernel.org> wrote:
>
> From: Arnd Bergmann <arnd@arndb.de>
>
> Randconfig builds without dmabuf result in this link error from
> the fasl-asrc driver:
>
> ERROR: modpost: "dma_buf_put" [sound/core/snd-compress.ko] undefined!
> ERROR: modpost: "dma_buf_export" [sound/soc/fsl/snd-soc-fsl-asrc.ko] undefined!
>
> Add the missing 'select' statement.
>
> Fixes: 24a01710f627 ("ASoC: fsl_asrc_m2m: Add memory to memory function")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Daniel Baluta <daniel.baluta@nxp.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] ASoC: fsl_asrc_m2m: select CONFIG_DMA_SHARED_BUFFER
2025-01-22 6:53 [PATCH] ASoC: fsl_asrc_m2m: select CONFIG_DMA_SHARED_BUFFER Arnd Bergmann
2025-01-22 8:24 ` Daniel Baluta
@ 2025-01-23 11:29 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2025-01-23 11:29 UTC (permalink / raw)
To: Shengjiu Wang, Arnd Bergmann
Cc: Arnd Bergmann, Liam Girdwood, Jaroslav Kysela, Takashi Iwai,
Sudeep Holla, Elinor Montmasson, Piotr Wojtaszczyk, linux-sound,
linux-kernel
On Wed, 22 Jan 2025 07:53:17 +0100, Arnd Bergmann wrote:
> Randconfig builds without dmabuf result in this link error from
> the fasl-asrc driver:
>
> ERROR: modpost: "dma_buf_put" [sound/core/snd-compress.ko] undefined!
> ERROR: modpost: "dma_buf_export" [sound/soc/fsl/snd-soc-fsl-asrc.ko] undefined!
>
> Add the missing 'select' statement.
>
> [...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[1/1] ASoC: fsl_asrc_m2m: select CONFIG_DMA_SHARED_BUFFER
commit: a2cd92185db0586f2136feae84d98cc54580f381
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-01-23 11:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-01-22 6:53 [PATCH] ASoC: fsl_asrc_m2m: select CONFIG_DMA_SHARED_BUFFER Arnd Bergmann
2025-01-22 8:24 ` Daniel Baluta
2025-01-23 11:29 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox