public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ian Rogers <irogers@google.com>
To: Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	 Arnaldo Carvalho de Melo <acme@kernel.org>,
	Namhyung Kim <namhyung@kernel.org>,
	 Mark Rutland <mark.rutland@arm.com>,
	 Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Jiri Olsa <jolsa@kernel.org>,  Ian Rogers <irogers@google.com>,
	Adrian Hunter <adrian.hunter@intel.com>,
	 Kan Liang <kan.liang@linux.intel.com>,
	Nathan Chancellor <nathan@kernel.org>,
	 Nick Desaulniers <ndesaulniers@google.com>,
	Bill Wendling <morbo@google.com>,
	 Justin Stitt <justinstitt@google.com>,
	Aditya Gupta <adityag@linux.ibm.com>,
	 "Steinar H. Gunderson" <sesse@google.com>,
	Charlie Jenkins <charlie@rivosinc.com>,
	 Changbin Du <changbin.du@huawei.com>,
	"Masami Hiramatsu (Google)" <mhiramat@kernel.org>,
	 James Clark <james.clark@linaro.org>,
	Kajol Jain <kjain@linux.ibm.com>,
	 Athira Rajeev <atrajeev@linux.vnet.ibm.com>,
	Li Huafei <lihuafei1@huawei.com>,
	 Dmitry Vyukov <dvyukov@google.com>,
	Andi Kleen <ak@linux.intel.com>,
	 Chaitanya S Prakash <chaitanyas.prakash@arm.com>,
	linux-kernel@vger.kernel.org,  linux-perf-users@vger.kernel.org,
	llvm@lists.linux.dev,  Song Liu <song@kernel.org>,
	bpf@vger.kernel.org
Subject: [PATCH v3 17/18] perf disasm: Make ins__scnprintf and ins__is_nop static
Date: Wed, 22 Jan 2025 09:43:07 -0800	[thread overview]
Message-ID: <20250122174308.350350-18-irogers@google.com> (raw)
In-Reply-To: <20250122174308.350350-1-irogers@google.com>

Reduce the scope of ins__scnprintf and ins__is_nop that aren't used
outside of disasm.c.

Signed-off-by: Ian Rogers <irogers@google.com>
---
 tools/perf/util/disasm.c | 6 +++---
 tools/perf/util/disasm.h | 3 ---
 2 files changed, 3 insertions(+), 6 deletions(-)

diff --git a/tools/perf/util/disasm.c b/tools/perf/util/disasm.c
index ebd86691acf8..b2dfd40588ef 100644
--- a/tools/perf/util/disasm.c
+++ b/tools/perf/util/disasm.c
@@ -246,8 +246,8 @@ static int ins__raw_scnprintf(struct ins *ins, char *bf, size_t size,
 	return scnprintf(bf, size, "%-*s %s", max_ins_name, ins->name, ops->raw);
 }
 
-int ins__scnprintf(struct ins *ins, char *bf, size_t size,
-		   struct ins_operands *ops, int max_ins_name)
+static int ins__scnprintf(struct ins *ins, char *bf, size_t size,
+			  struct ins_operands *ops, int max_ins_name)
 {
 	if (ins->ops->scnprintf)
 		return ins->ops->scnprintf(ins, bf, size, ops, max_ins_name);
@@ -824,7 +824,7 @@ static struct ins_ops ret_ops = {
 	.scnprintf = ins__raw_scnprintf,
 };
 
-bool ins__is_nop(const struct ins *ins)
+static bool ins__is_nop(const struct ins *ins)
 {
 	return ins->ops == &nop_ops;
 }
diff --git a/tools/perf/util/disasm.h b/tools/perf/util/disasm.h
index 2cb4e1a6bd30..09c86f540f7f 100644
--- a/tools/perf/util/disasm.h
+++ b/tools/perf/util/disasm.h
@@ -110,13 +110,10 @@ struct arch *arch__find(const char *name);
 bool arch__is(struct arch *arch, const char *name);
 
 struct ins_ops *ins__find(struct arch *arch, const char *name, struct disasm_line *dl);
-int ins__scnprintf(struct ins *ins, char *bf, size_t size,
-		   struct ins_operands *ops, int max_ins_name);
 
 bool ins__is_call(const struct ins *ins);
 bool ins__is_jump(const struct ins *ins);
 bool ins__is_fused(struct arch *arch, const char *ins1, const char *ins2);
-bool ins__is_nop(const struct ins *ins);
 bool ins__is_ret(const struct ins *ins);
 bool ins__is_lock(const struct ins *ins);
 
-- 
2.48.1.262.g85cc9f2d1e-goog


  parent reply	other threads:[~2025-01-22 17:43 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-22 17:42 [PATCH v3 00/18] Support dynamic opening of capstone/llvm remove BUILD_NONDISTRO Ian Rogers
2025-01-22 17:42 ` [PATCH v3 01/18] perf build: Remove libtracefs configuration Ian Rogers
2025-01-22 17:42 ` [PATCH v3 02/18] perf map: Constify objdump offset/address conversion APIs Ian Rogers
2025-01-22 17:42 ` [PATCH v3 03/18] perf capstone: Move capstone functionality into its own file Ian Rogers
2025-01-24 21:58   ` Namhyung Kim
2025-01-25  0:59     ` Ian Rogers
2025-01-28 20:56       ` Namhyung Kim
2025-01-28 22:16         ` Ian Rogers
2025-01-22 17:42 ` [PATCH v3 04/18] perf llvm: Move llvm " Ian Rogers
2025-01-24 22:04   ` Namhyung Kim
2025-01-22 17:42 ` [PATCH v3 05/18] perf capstone: Remove open_capstone_handle Ian Rogers
2025-01-22 17:42 ` [PATCH v3 06/18] perf capstone: Support for dlopen-ing libcapstone.so Ian Rogers
2025-01-24 22:22   ` Namhyung Kim
2025-01-25  5:20     ` Ian Rogers
2025-01-28 20:58       ` Namhyung Kim
2025-01-28 22:13         ` Ian Rogers
2025-01-22 17:42 ` [PATCH v3 07/18] perf llvm: Support for dlopen-ing libLLVM.so Ian Rogers
2025-01-24 22:54   ` Namhyung Kim
2025-01-25  1:21     ` Ian Rogers
2025-01-22 17:42 ` [PATCH v3 08/18] perf llvm: Mangle libperf-llvm.so function names Ian Rogers
2025-01-22 17:42 ` [PATCH v3 09/18] perf dso: Move read_symbol from llvm/capstone to dso Ian Rogers
2025-01-22 17:43 ` [PATCH v3 10/18] perf dso: Support BPF programs in dso__read_symbol Ian Rogers
2025-03-25 17:44   ` Ian Rogers
2025-01-22 17:43 ` [PATCH v3 11/18] perf llvm: Disassemble cleanup Ian Rogers
2025-01-22 17:43 ` [PATCH v3 12/18] perf dso: Clean up read_symbol error handling Ian Rogers
2025-01-22 17:43 ` [PATCH v3 13/18] perf build: Remove libbfd support Ian Rogers
2025-01-29  0:31   ` Daniel Xu
2025-01-29  1:40     ` Ian Rogers
2025-01-29 16:46       ` Daniel Xu
2025-01-29 19:36         ` Ian Rogers
2025-01-22 17:43 ` [PATCH v3 14/18] perf build: Remove libiberty support Ian Rogers
2025-01-22 17:43 ` [PATCH v3 15/18] perf build: Remove unused defines Ian Rogers
2025-01-22 17:43 ` [PATCH v3 16/18] perf disasm: Remove disasm_bpf Ian Rogers
2025-01-22 17:43 ` Ian Rogers [this message]
2025-01-22 17:43 ` [PATCH v3 18/18] perf srcline: Fallback between addr2line implementations Ian Rogers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250122174308.350350-18-irogers@google.com \
    --to=irogers@google.com \
    --cc=acme@kernel.org \
    --cc=adityag@linux.ibm.com \
    --cc=adrian.hunter@intel.com \
    --cc=ak@linux.intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=atrajeev@linux.vnet.ibm.com \
    --cc=bpf@vger.kernel.org \
    --cc=chaitanyas.prakash@arm.com \
    --cc=changbin.du@huawei.com \
    --cc=charlie@rivosinc.com \
    --cc=dvyukov@google.com \
    --cc=james.clark@linaro.org \
    --cc=jolsa@kernel.org \
    --cc=justinstitt@google.com \
    --cc=kan.liang@linux.intel.com \
    --cc=kjain@linux.ibm.com \
    --cc=lihuafei1@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=llvm@lists.linux.dev \
    --cc=mark.rutland@arm.com \
    --cc=mhiramat@kernel.org \
    --cc=mingo@redhat.com \
    --cc=morbo@google.com \
    --cc=namhyung@kernel.org \
    --cc=nathan@kernel.org \
    --cc=ndesaulniers@google.com \
    --cc=peterz@infradead.org \
    --cc=sesse@google.com \
    --cc=song@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox