From: Willy Tarreau <w@1wt.eu>
To: "Thomas Weißschuh" <linux@weissschuh.net>
Cc: Shuah Khan <shuah@kernel.org>,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/5] selftests/nolibc: always keep test kernel configuration up to date
Date: Wed, 22 Jan 2025 19:52:06 +0100 [thread overview]
Message-ID: <20250122185206.GF2867@1wt.eu> (raw)
In-Reply-To: <20250122-nolibc-config-v1-5-a697db968b49@weissschuh.net>
Hi Thomas!
On Wed, Jan 22, 2025 at 07:41:48PM +0100, Thomas Weißschuh wrote:
> @@ -173,7 +170,7 @@ test_arch() {
> exit 1
> esac
> printf '%-15s' "$arch:"
> - swallow_output "${MAKE[@]}" CFLAGS_EXTRA="$CFLAGS_EXTRA" "$test_target" V=1
> + swallow_output "${MAKE[@]}" CFLAGS_EXTRA="$CFLAGS_EXTRA" defconfig "$test_target" V=1
Just a question, are you certain that dependencies between $test_target
and defconfig are always properly handled ? I'm asking because "make -j"
is something valid, and we wouldn't want defconfig to run in parallel
with test_target. For real sequencing (and making sure targets run in the
correct order), I normally prefer to run them one at a time. Here you could
simply prepend the defconfig line before the original one and get these
guarantees (and also make them explicit). That's also less edit when
copy-pasting from the terminal to the shell when trying to debug.
Just my few cents ;-)
Willy
next prev parent reply other threads:[~2025-01-22 19:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-22 18:41 [PATCH 0/5] selftests/nolibc: test kernel configuration cleanups Thomas Weißschuh
2025-01-22 18:41 ` [PATCH 1/5] selftests/nolibc: drop custom EXTRACONFIG functionality Thomas Weißschuh
2025-01-22 18:41 ` [PATCH 2/5] selftests/nolibc: drop call to prepare target Thomas Weißschuh
2025-01-22 18:41 ` [PATCH 3/5] selftests/nolibc: drop call to mrproper target Thomas Weißschuh
2025-01-22 18:41 ` [PATCH 4/5] selftests/nolibc: execute defconfig before other targets Thomas Weißschuh
2025-01-22 18:41 ` [PATCH 5/5] selftests/nolibc: always keep test kernel configuration up to date Thomas Weißschuh
2025-01-22 18:52 ` Willy Tarreau [this message]
2025-01-22 19:00 ` Thomas Weißschuh
2025-01-22 22:14 ` Willy Tarreau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250122185206.GF2867@1wt.eu \
--to=w@1wt.eu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux@weissschuh.net \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox