From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yb1-f201.google.com (mail-yb1-f201.google.com [209.85.219.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E1CC520B807 for ; Thu, 23 Jan 2025 07:47:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737618428; cv=none; b=h+wAuzEZfOaxy7GCfziiWyUdwTqJtVTqxEidCXaX1XxpvLNkXuQf+4N7wgniefbPWPrKI9ep5YvFmEcgEzRlLT040+THXCH9zgeMjNswCIDLaEC2gLV0gjzfbbtPCUYBs8gky6XPcv38Q5AkQ3uQhGVPoS3WHOMbM98Nkb2hh9s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737618428; c=relaxed/simple; bh=AuTsH0YHOa++0a0gEpAflS+m3ZAbu91QpN5DGy2CKOY=; h=Date:In-Reply-To:Message-Id:Mime-Version:References:Subject:From: To:Content-Type; b=mOYr0sdtdv1+uG9yvQ/zzhIV3/RMRVxWtOgyyU4MLtT5LqqlIYeTnEGWQvhQxgmPWYBXvB0Mnumq3fma1FBomhAWAS0npZz+4dDuWV4XGEYMetNwfKVTjHUUPuf1nMmssFZpFUEHICVieJgRSNjO9Th7yGSvLunuK480RI/PoIQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=d0n6VckD; arc=none smtp.client-ip=209.85.219.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="d0n6VckD" Received: by mail-yb1-f201.google.com with SMTP id 3f1490d57ef6-e54da6701d2so1765588276.0 for ; Wed, 22 Jan 2025 23:47:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1737618425; x=1738223225; darn=vger.kernel.org; h=to:from:subject:references:mime-version:message-id:in-reply-to:date :from:to:cc:subject:date:message-id:reply-to; bh=I/EdS3qTY+09X5JRTcKpgEWVJ9FaQ49oSPLBxs6KryA=; b=d0n6VckDOmVUjBwJ9wbfU4ZId0T4/SkFqtcB70evFI5v6qf6k2t++kzLhr3b0u9iOT RDoQBwrQSRJ9rDt0HliXagRNmeJBmilu7dfFJ/y9/EISW2Uo31rn2cZElMFJ1k17J172 S/o32wvUmQBUZ/zDtfpkARe1L806MmQP22YcsiPy8fy7HZd6AovgFmncGMFis5YxPUvj gCgk9GkDde3t+p+QAq3OSYXQ3wmqAOkPI3/+sp2V7QiVctvD1eHG4JP5N6g9QVYGmlJG iFIGeuxtMtkKY3qFWiq6nOjYUuYLJ+AAB204iDMaMmzkeNsvJ4Kzx1ksDCkQY3mzjQmc owIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737618425; x=1738223225; h=to:from:subject:references:mime-version:message-id:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=I/EdS3qTY+09X5JRTcKpgEWVJ9FaQ49oSPLBxs6KryA=; b=Ptr12vRk4si4DONPqOQrj3DmdZ9ggVee/Ekt0snO8jC+Es9nPaHUBV2SQhtbsGazIy HN/9V6Zck9yW22L73sCBHn9g4V3JVEV1PA3OC2fp1uyENoPfVa9PiVOtXDfy8B6SAZq7 iBLmmACGfUCdm9iozm7FmakgM+eu2LBgCEpZgSj50wTrOBreQh2n8+8bJvJXZdLnFO7R j8YpknvFI8dNT4lj/pVohktfnLvzB3E5WOvevflWMACEcLkIzWJqC7mbuCKz0nG3etmC Um+HqWu3IEU7o0tHn56B9yaO0VQFUjatwATr4YZ3leAzkwysIb6qrcbjN/OWOjKtn8Jl 5ZUg== X-Forwarded-Encrypted: i=1; AJvYcCVIQZVjNtaHXQW+Pg7xVWHQ7zikjjT11LzH17F1R7CCNgwVZt/bdoQt6Z7Ucs2e9lqxCrUnbmu6HJ9qv1U=@vger.kernel.org X-Gm-Message-State: AOJu0Yz5jpF6+AgiL45V8opdVAXdl+z/8kiuNfPtjbmrqSyNMiq3S5kj 9BpkjMxoiU6PNFjKhdHhkZPdDFHamAvI+6ubRIZrfw1K/A+QNn/RHtNGvkMGN/NIkx1Io7aRkYt J3CeCzg== X-Google-Smtp-Source: AGHT+IHMAQdwdbEHDozJ5QOQVR6FPmtsPooPKLG29MtxeD9qLiFGcCi8tX3yvDrPEqCugmxty5Z+mz7wStTg X-Received: from irogers.svl.corp.google.com ([2620:15c:2c5:11:2fda:d811:ae83:77e0]) (user=irogers job=sendgmr) by 2002:a81:a884:0:b0:6ee:b693:f752 with SMTP id 00721157ae682-6f6eb519f22mr487327b3.0.1737618424725; Wed, 22 Jan 2025 23:47:04 -0800 (PST) Date: Wed, 22 Jan 2025 23:46:55 -0800 In-Reply-To: <20250123074659.698123-1-irogers@google.com> Message-Id: <20250123074659.698123-2-irogers@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250123074659.698123-1-irogers@google.com> X-Mailer: git-send-email 2.48.1.262.g85cc9f2d1e-goog Subject: [PATCH v2 1/5] perf evsel: Reduce scanning core PMUs in is_hybrid From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Kan Liang , James Clark , Ze Gao , Weilin Wang , Jean-Philippe Romain , Junhao He , Yicong Yang , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" evsel__is_hybrid returns true if there are multiple core PMUs and the evsel is for a core PMU. Determining the number of core PMUs can require loading/scanning PMUs. There's no point doing the scanning if evsel for the is_hybrid test isn't core so reorder the tests to reduce PMU scanning. Signed-off-by: Ian Rogers --- tools/perf/util/evsel.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c index bc144388f892..ae20691bbfae 100644 --- a/tools/perf/util/evsel.c +++ b/tools/perf/util/evsel.c @@ -3856,10 +3856,10 @@ void evsel__zero_per_pkg(struct evsel *evsel) */ bool evsel__is_hybrid(const struct evsel *evsel) { - if (perf_pmus__num_core_pmus() == 1) + if (!evsel->core.is_pmu_core) return false; - return evsel->core.is_pmu_core; + return perf_pmus__num_core_pmus() > 1; } struct evsel *evsel__leader(const struct evsel *evsel) -- 2.48.1.262.g85cc9f2d1e-goog