From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F022E186A for ; Thu, 23 Jan 2025 10:31:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.176.79.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737628298; cv=none; b=IcmBaZHvX1RVNlxCVk3tlo3yipQhATRMICk/T+BEcQpzCJdUKUPNz8on3Z+8WpS1wRzSHc1DJEEhwb5M41W8948D40c06Z0TKKDl4BfwbxLmxIneD4+F5GC2yfg1r7W3b1u3z7D7sbdukX3UKr2CtwOKkuriyxIgC8wOhXOKlh0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737628298; c=relaxed/simple; bh=U6DBOySvHngcaHeHU+AI4jyFcENbFVszbM2S4h8LRtc=; h=Date:From:To:CC:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=ZM8fmggS06e5ZH7PnrRnDdAFcWOSPqCI+HcuPddZ0OTmtzit4tpWKwT1audt5GJSk41Fs/0rYFzDU/DQEoHWN1BlAHlAxp6nZ9CbQFETw2QgnzDYfW9UJPy25izvyi6jbqsttFA2DCGgir5I0ghJr4Iy6xYsfzrk+QL8gxK7G1g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=185.176.79.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.18.186.231]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4YdxyS5SV4z6M4NF; Thu, 23 Jan 2025 18:29:36 +0800 (CST) Received: from frapeml500008.china.huawei.com (unknown [7.182.85.71]) by mail.maildlp.com (Postfix) with ESMTPS id B1A92140519; Thu, 23 Jan 2025 18:31:33 +0800 (CST) Received: from localhost (10.203.177.66) by frapeml500008.china.huawei.com (7.182.85.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Thu, 23 Jan 2025 11:31:33 +0100 Date: Thu, 23 Jan 2025 10:31:31 +0000 From: Jonathan Cameron To: Mauro Carvalho Chehab CC: Igor Mammedov , "Michael S . Tsirkin" , Shiju Jose , , , Ani Sinha , Subject: Re: [PATCH 04/11] acpi/generic_event_device: Update GHES migration to cover hest addr Message-ID: <20250123103131.0000393d@huawei.com> In-Reply-To: <6b79da0dbd8d735e93c15c4673bf2af61e8c34a2.1737560101.git.mchehab+huawei@kernel.org> References: <6b79da0dbd8d735e93c15c4673bf2af61e8c34a2.1737560101.git.mchehab+huawei@kernel.org> X-Mailer: Claws Mail 4.3.0 (GTK 3.24.42; x86_64-w64-mingw32) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: lhrpeml500001.china.huawei.com (7.191.163.213) To frapeml500008.china.huawei.com (7.182.85.71) On Wed, 22 Jan 2025 16:46:21 +0100 Mauro Carvalho Chehab wrote: > The GHES migration logic at GED should now support HEST table > location too. > > Signed-off-by: Mauro Carvalho Chehab I'm not an expert on migration logic, but with that in mind, this looks fine to me. Reviewed-by: Jonathan Cameron > --- > hw/acpi/generic_event_device.c | 29 +++++++++++++++++++++++++++++ > 1 file changed, 29 insertions(+) > > diff --git a/hw/acpi/generic_event_device.c b/hw/acpi/generic_event_device.c > index c85d97ca3776..5346cae573b7 100644 > --- a/hw/acpi/generic_event_device.c > +++ b/hw/acpi/generic_event_device.c > @@ -386,6 +386,34 @@ static const VMStateDescription vmstate_ghes_state = { > } > }; > > +static const VMStateDescription vmstate_hest = { > + .name = "acpi-hest", > + .version_id = 1, > + .minimum_version_id = 1, > + .fields = (const VMStateField[]) { > + VMSTATE_UINT64(hest_addr_le, AcpiGhesState), > + VMSTATE_END_OF_LIST() > + }, > +}; > + > +static bool hest_needed(void *opaque) > +{ > + AcpiGedState *s = opaque; > + return s->ghes_state.hest_addr_le; > +} > + > +static const VMStateDescription vmstate_hest_state = { > + .name = "acpi-ged/hest", > + .version_id = 1, > + .minimum_version_id = 1, > + .needed = hest_needed, > + .fields = (const VMStateField[]) { > + VMSTATE_STRUCT(ghes_state, AcpiGedState, 1, > + vmstate_hest, AcpiGhesState), > + VMSTATE_END_OF_LIST() > + } > +}; > + > static const VMStateDescription vmstate_acpi_ged = { > .name = "acpi-ged", > .version_id = 1, > @@ -398,6 +426,7 @@ static const VMStateDescription vmstate_acpi_ged = { > &vmstate_memhp_state, > &vmstate_cpuhp_state, > &vmstate_ghes_state, > + &vmstate_hest_state, > NULL > } > };