public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Eric Biggers <ebiggers@kernel.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Theodore Ts'o <tytso@mit.edu>,
	linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
	Ard Biesheuvel <ardb@kernel.org>, Chao Yu <chao@kernel.org>,
	"Darrick J. Wong" <djwong@kernel.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Kent Overstreet <kent.overstreet@linux.dev>,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Vinicius Peixoto <vpeixoto@lkcamp.dev>,
	WangYuli
	<wangyuli@grjsls0nwwnnilyahiblcmlmlcaoki5s.yundunwaf1.com>
Subject: Re: [GIT PULL] CRC updates for 6.14
Date: Thu, 23 Jan 2025 13:22:13 -0800	[thread overview]
Message-ID: <20250123212213.GC88607@sol.localdomain> (raw)
In-Reply-To: <CAHk-=wgmda2CvAiOrg+zznFroPTo2TrdjnHo9f4_Kv1Pwn5iOA@mail.gmail.com>

On Thu, Jan 23, 2025 at 01:16:57PM -0800, Linus Torvalds wrote:
> On Thu, 23 Jan 2025 at 13:13, Eric Biggers <ebiggers@kernel.org> wrote:
> >
> > x86 unfortunately only has an instruction for crc32c
> 
> Yeah, but isn't that like 90% of the uses?
> 
> IOW, if you'd make the "select" statements a bit more specific, and
> make ext4 (and others) do "select CRC32C" instead, the other ones
> wouldn't even get selected?
> 
>               Linus

There's quite a lot unfortunately.  Try this which finds the regular crc32 (not
crc32c):

    git grep -E '\<(crc32|crc32_le|__crc32_le)\(|"crc32"'

- Eric

  reply	other threads:[~2025-01-23 21:22 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-19 22:51 [GIT PULL] CRC updates for 6.14 Eric Biggers
2025-01-23  4:13 ` Linus Torvalds
2025-01-23  5:16   ` Eric Biggers
2025-01-23  7:46     ` Eric Biggers
2025-01-23 14:07       ` Theodore Ts'o
2025-01-23 18:18         ` Eric Biggers
2025-01-23 20:52           ` Linus Torvalds
2025-01-23 21:13             ` Eric Biggers
2025-01-23 21:16               ` Linus Torvalds
2025-01-23 21:22                 ` Eric Biggers [this message]
2025-01-23 20:58         ` David Laight
2025-01-23 21:16           ` Eric Biggers
2025-01-23 23:17             ` David Laight
2025-01-23 22:36       ` Kent Overstreet
2025-01-23 23:42         ` Eric Biggers
2025-01-24  0:32           ` Kent Overstreet
2025-01-23  8:16     ` Geert Uytterhoeven
2025-01-23  8:19       ` Geert Uytterhoeven
2025-01-23  8:26         ` Eric Biggers
2025-01-23  8:22       ` Eric Biggers
2025-01-23  4:49 ` pr-tracker-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250123212213.GC88607@sol.localdomain \
    --to=ebiggers@kernel.org \
    --cc=ardb@kernel.org \
    --cc=chao@kernel.org \
    --cc=djwong@kernel.org \
    --cc=geert@linux-m68k.org \
    --cc=kent.overstreet@linux.dev \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=mpe@ellerman.id.au \
    --cc=torvalds@linux-foundation.org \
    --cc=tytso@mit.edu \
    --cc=vpeixoto@lkcamp.dev \
    --cc=wangyuli@grjsls0nwwnnilyahiblcmlmlcaoki5s.yundunwaf1.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox