Re: [PATCH 0/2] lib/crc: simplify choice of CRC implementations

Ard Biesheuvel
2025-01-29T16:12:12Z

On Sat, 25 Jan 2025 at 01:37, Eric Biggers <ebiggers@kernel.org> wrote:
>
> On Thu, Jan 23, 2025 at 01:29:02PM -0800, Eric Biggers wrote:
> > This series simplifies the choice of CRC implementations, as requested
> > by Linus at
> > https://lore.kernel.org/linux-crypto/CAHk-=wgqAZf7Sdyrka5RQQ2MVC1V_C1Gp68KrN=mHjPiRw70Jg@mail.gmail.com/
> >
> > Eric Biggers (2):
> > lib/crc: simplify the kconfig options for CRC implementations
> > lib/crc32: remove other generic implementations
> >
> > lib/Kconfig | 118 +++--------------------
> > lib/crc32.c | 225 ++-----------------------------------------
> > lib/crc32defs.h | 59 ------------
> > lib/gen_crc32table.c | 113 ++++++----------------
> > 4 files changed, 53 insertions(+), 462 deletions(-)
> > delete mode 100644 lib/crc32defs.h
>
> FYI, I am tentatively planning a pull request next week with this, and this is
> now in linux-next (via my crc-next tree). Reviews / acks appreciated!
>

For the series,

Reviewed-by: Ard Biesheuvel <ardb@kernel.org>