From: Alexander Shiyan <eagle.alexander923@gmail.com>
To: linux-rockchip@lists.infradead.org
Cc: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Heiko Stuebner <heiko@sntech.de>,
Sebastian Reichel <sebastian.reichel@collabora.com>,
Alexey Charkov <alchark@gmail.com>,
Cristian Ciocaltea <cristian.ciocaltea@collabora.com>,
Dragan Simic <dsimic@manjaro.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Alexander Shiyan <eagle.alexander923@gmail.com>,
stable@vger.kernel.org
Subject: [PATCH] arm64: dts: rockchip: Fix broken tsadc pinctrl binding for rk3588
Date: Fri, 24 Jan 2025 08:26:11 +0300 [thread overview]
Message-ID: <20250124052611.3705-1-eagle.alexander923@gmail.com> (raw)
There is no pinctrl "gpio" and "otpout" (probably designed as "output")
handling in the tsadc driver.
Let's use proper binding "default" and "sleep".
Fixes: 32641b8ab1a5 ("arm64: dts: rockchip: add rk3588 thermal sensor")
Cc: stable@vger.kernel.org
Signed-off-by: Alexander Shiyan <eagle.alexander923@gmail.com>
---
arch/arm64/boot/dts/rockchip/rk3588-base.dtsi | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/arm64/boot/dts/rockchip/rk3588-base.dtsi b/arch/arm64/boot/dts/rockchip/rk3588-base.dtsi
index a337f3fb8377..f141065eb69d 100644
--- a/arch/arm64/boot/dts/rockchip/rk3588-base.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3588-base.dtsi
@@ -2667,9 +2667,9 @@ tsadc: tsadc@fec00000 {
rockchip,hw-tshut-temp = <120000>;
rockchip,hw-tshut-mode = <0>; /* tshut mode 0:CRU 1:GPIO */
rockchip,hw-tshut-polarity = <0>; /* tshut polarity 0:LOW 1:HIGH */
- pinctrl-0 = <&tsadc_gpio_func>;
- pinctrl-1 = <&tsadc_shut>;
- pinctrl-names = "gpio", "otpout";
+ pinctrl-0 = <&tsadc_shut>;
+ pinctrl-1 = <&tsadc_gpio_func>;
+ pinctrl-names = "default", "sleep";
#thermal-sensor-cells = <1>;
status = "disabled";
};
--
2.39.1
next reply other threads:[~2025-01-24 5:26 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-24 5:26 Alexander Shiyan [this message]
2025-01-24 8:33 ` [PATCH] arm64: dts: rockchip: Fix broken tsadc pinctrl binding for rk3588 Alexey Charkov
2025-01-24 10:06 ` Dragan Simic
2025-01-24 10:25 ` Alexey Charkov
2025-01-24 10:37 ` Dragan Simic
2025-01-24 10:45 ` Dragan Simic
2025-01-24 17:23 ` Alexey Charkov
2025-01-24 19:44 ` Alexey Charkov
2025-01-26 6:10 ` Dragan Simic
2025-01-26 14:25 ` Alexander Shiyan
2025-01-28 9:24 ` Dragan Simic
2025-01-28 10:30 ` Alexey Charkov
2025-01-28 10:44 ` Dragan Simic
2025-10-03 13:33 ` Laurent Pinchart
2025-10-03 14:13 ` Alexey Charkov
2025-10-03 14:55 ` Alexey Charkov
2025-10-03 23:28 ` Laurent Pinchart
2025-10-04 11:41 ` Alexey Charkov
2025-10-04 22:03 ` Laurent Pinchart
2025-10-05 10:55 ` Alexey Charkov
2025-10-05 18:29 ` Laurent Pinchart
2025-10-03 23:52 ` Laurent Pinchart
2025-01-26 6:09 ` Dragan Simic
2025-01-24 10:38 ` Dragan Simic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250124052611.3705-1-eagle.alexander923@gmail.com \
--to=eagle.alexander923@gmail.com \
--cc=alchark@gmail.com \
--cc=conor+dt@kernel.org \
--cc=cristian.ciocaltea@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=dsimic@manjaro.org \
--cc=heiko@sntech.de \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh@kernel.org \
--cc=sebastian.reichel@collabora.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox