Re: [PATCH v3 3/4] PCI: dwc: Reduce DT reads by allocating host bridge via DWC glue driver

Manivannan Sadhasivam
2025-01-24T09:36:49Z

On Fri, Jan 24, 2025 at 01:56:25PM +0530, Krishna Chaitanya Chundru wrote:
>
>
> On 1/24/2025 11:48 AM, Manivannan Sadhasivam wrote:
> > On Tue, Jan 21, 2025 at 02:32:21PM +0530, Krishna Chaitanya Chundru wrote:
> > > Allow DWC glue drivers to allocate the host bridge, avoiding redundant
> > > device tree reads primarily in dw_pcie_ecam_supported().
> > >
> >
> > I don't understand what you mean by 'redundant device tree reads'. Please
> > explain.
> >
> In dw_pcie_ecam_supported () we are trying to read bus-range to find
> maximum bus range value. devm_pci_alloc_host_bridge() is already reading
> bus range it. If we move devm_pci_alloc_host_bridge() to start of the
> controller probe we can avoid reading the dt and use values stored in the
> host bridge.

This is the exact information you should put into the description. Do not assume
that the readers will have the background.

> This was recommended by bjorn in the v2.
>

Then you should add 'Suggested-by' tag.

- Mani

--
மணிவண்ணன் சதாசிவம்