public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Dave Penkler <dpenkler@gmail.com>
To: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
	linux-kernel@vger.kernel.org
Cc: Dave Penkler <dpenkler@gmail.com>
Subject: [PATCH 3/3] staging: gpib: Remove depends on BROKEN
Date: Fri, 24 Jan 2025 11:59:00 +0100	[thread overview]
Message-ID: <20250124105900.27592-4-dpenkler@gmail.com> (raw)
In-Reply-To: <20250124105900.27592-1-dpenkler@gmail.com>

The build of drivers/staging/gpib/hp_82341 driver was failing
with:

ERROR: modpost: "isapnp_read_byte"
[drivers/staging/gpib/hp_82341/hp_82341.ko] undefined!

The driver was marked BROKEN to fix this issue
Link: https://lore.kernel.org/all/2024101412-outsider-icing-052e@gregkh/

Remove the dependency on BROKEN

Signed-off-by: Dave Penkler <dpenkler@gmail.com>
---
 drivers/staging/gpib/Kconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/staging/gpib/Kconfig b/drivers/staging/gpib/Kconfig
index 81510db3072e..2bf11df122e2 100644
--- a/drivers/staging/gpib/Kconfig
+++ b/drivers/staging/gpib/Kconfig
@@ -169,7 +169,6 @@ config GPIB_HP82341
        tristate "HP82341x"
        select GPIB_COMMON
        select GPIB_TMS9914
-       depends on BROKEN
        depends on ISA_BUS || EISA
        help
          GPIB driver for HP82341 A/B/C/D boards
-- 
2.47.1


  parent reply	other threads:[~2025-01-24 11:01 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-24 10:58 [PATCH 0/3] staging: gpib: Fix CONFIG_GPIB_HP82341 build failure Dave Penkler
2025-01-24 10:58 ` [PATCH 1/3] staging: gpib: Fix pr_err format warning Dave Penkler
2025-01-24 10:58 ` [PATCH 2/3] pnp: isapnp: Export isapnp_read_byte again Dave Penkler
2025-01-24 10:59 ` Dave Penkler [this message]
2025-01-25 11:39   ` [PATCH 3/3] staging: gpib: Remove depends on BROKEN kernel test robot
2025-01-25 14:16   ` kernel test robot
2025-01-26 18:13     ` Dave Penkler
2025-01-25 14:47   ` kernel test robot
2025-01-26 18:18     ` Dave Penkler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250124105900.27592-4-dpenkler@gmail.com \
    --to=dpenkler@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox