From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lelvem-ot02.ext.ti.com (lelvem-ot02.ext.ti.com [198.47.23.235]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3EAE8FBF6 for ; Fri, 24 Jan 2025 22:08:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.47.23.235 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737756520; cv=none; b=S/UowaJGssLXo9ic10j2WS9uq/+56Vtib7KWbtHJglyTK7WGXVwujqZUDkWoYP1CO6JOUiJ71pm/DIvs/Tp8R/R5Djfojm1vhjC1CslWZqNeURzkv0ssgvjEVV9USmfXBONy7hJI2Njj6GnDqZkYgLbjeAN+d3wFT8UO5dNAmPE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737756520; c=relaxed/simple; bh=CsY536cWskGG0um+CJ8FdaB556FAdA5FO6tC6CfVjNs=; h=Date:From:To:CC:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=AOEMe2rJ0uYoPxZCVPW6Ax19MNzxhoiXYGGo4JP5u20FZ2g2kmijw2AcXyO13HyBPAGNJ+jq/gECFMgviNpiD5aovxMlPtqANnufq2Gef3AyDwrugXH6jeDOK9wtvOuZxJjjsaq9+nhhIMbHG9rFw0wTuVfqoHLR0p+PReDjIpQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=teIbU//B; arc=none smtp.client-ip=198.47.23.235 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="teIbU//B" Received: from fllv0035.itg.ti.com ([10.64.41.0]) by lelvem-ot02.ext.ti.com (8.15.2/8.15.2) with ESMTPS id 50OM8DTp633373 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 24 Jan 2025 16:08:13 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1737756493; bh=LftE35hyy2otS4YAJZjS6DqO6tb+MdyV2iZyl27bCWw=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=teIbU//BouDbA3AbfFe+1b1Xn4F/RwJIvNs+F1I8E+brZHJqJaWn5VSuau1BOmROV FJP5Wsny1uNXaUgLwQj+gi9yV9f1hvb/bC7pxIPkC03dUg9a3gbplQ75gzdMCoZw2M Zu47elnyDQzKVAse1pXzN5LJAnaqjOV/2XffoNyo= Received: from DFLE113.ent.ti.com (dfle113.ent.ti.com [10.64.6.34]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 50OM8DBB091600 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 24 Jan 2025 16:08:13 -0600 Received: from DFLE103.ent.ti.com (10.64.6.24) by DFLE113.ent.ti.com (10.64.6.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Fri, 24 Jan 2025 16:08:12 -0600 Received: from lelvsmtp5.itg.ti.com (10.180.75.250) by DFLE103.ent.ti.com (10.64.6.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Fri, 24 Jan 2025 16:08:13 -0600 Received: from localhost (uda0133052.dhcp.ti.com [128.247.81.232]) by lelvsmtp5.itg.ti.com (8.15.2/8.15.2) with ESMTP id 50OM8Djd106339; Fri, 24 Jan 2025 16:08:13 -0600 Date: Fri, 24 Jan 2025 16:08:13 -0600 From: Nishanth Menon To: "Rob Herring (Arm)" CC: Lee Jones , Arnd Bergmann , Krzysztof Kozlowski , Pankaj Dubey , Will McVicker , John Madieu , Vaishnav Achath , Subject: Re: [PATCH] mfd: syscon: Restore device_node_to_regmap() for non-syscon nodes Message-ID: <20250124220813.higrv36o7m77hsyk@unable> References: <20250124191644.2309790-1-robh@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20250124191644.2309790-1-robh@kernel.org> X-C2ProcessedOrg: 333ef613-75bf-4e12-a4b1-8e3623f5dcea On 13:16-20250124, Rob Herring wrote: > Commit ba5095ebbc7a ("mfd: syscon: Allow syscon nodes without a > "syscon" compatible") broke drivers which call device_node_to_regmap() > on nodes without a "syscon" compatible. Restore the prior behavior for > device_node_to_regmap(). > > This also makes using device_node_to_regmap() incompatible with > of_syscon_register_regmap() again, so add kerneldoc for > device_node_to_regmap() and syscon_node_to_regmap() to make it clear > how and when each one should be used. > > Fixes: ba5095ebbc7a ("mfd: syscon: Allow syscon nodes without a "syscon" compatible") > Cc: Will McVicker > Cc: John Madieu > Cc: Nishanth Menon > Reported-by: Vaishnav Achath > Signed-off-by: Rob Herring (Arm) Thanks Rob. Tested with next-20250124 on TI K3 platforms Tested-by: Nishanth Menon -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D