From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9F08E15CD4A; Sun, 26 Jan 2025 14:48:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737902926; cv=none; b=gKP6ML8CTagnZwR74k5NpCRJOozqqgrtKUGZIejci5vZB/m7N1SMOJ4oladpquVLIKuLLMwSNu2VTlU8NQ+U0TN5oKK3JNbYIGsRuEkiPq/xxZA6Dt2bojvFdRBEMcYMBQ+jl3UGKTW3evBck3swUB70mdXdVSWTDKLcGbgftxM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737902926; c=relaxed/simple; bh=uYNSd7HZWd79B6SkTzkI0BmE60u6OMnA8ioZz/homSc=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=A6ejpWnb+iqFAx5tV2mmqTPRf6QGsDCcgUsRabD9gtdUpOlBWqScEWfbKO1ctazGgeShRP5JNDR7ZDpUcHQ8yYE9BwLI6jBYkSEcGG6U5hWfrdx8aLnYNL6QYpvz1xYd9sxNOoC8Y8AvZhKmZgvTH0ugKlXVGP//DwyGPJ1CUC8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=eliujxza; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="eliujxza" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 080A0C4CEE4; Sun, 26 Jan 2025 14:48:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1737902926; bh=uYNSd7HZWd79B6SkTzkI0BmE60u6OMnA8ioZz/homSc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=eliujxza/OJnPFGMMnnIzu29/VHLYSm1tMsqXx6BTQabd7iuL3T6XFl9A/VNd7bxe TMVnBjes0DEyYgA8WnkSIBYQ3dYp0o8KUdHWCz1qKtprVkfldw82243/CupVELmbVY /Z8dzTazDMdR34NIivzbkTPR4+7JKa9xQU5zBP4nbFrHR4mBGhlAumpgSL/p4rUhJ+ wASxk0Rm93OIGJH2HwRN/4ETfriOiYDIr2K71qcrvMjmt4YnGIxVBop9oNvhalieLL BafdJn5wJMnPm0r9/FDMrfJYIGrNZBL6ZAAqxIZSr5MXV5FRgI0R8p1RE2mdi5PMxV Cvy61TDzXuzag== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Christoph Hellwig , Ming Lei , Nilay Shroff , "Martin K . Petersen" , Jens Axboe , Sasha Levin , linux-block@vger.kernel.org Subject: [PATCH AUTOSEL 6.13 3/7] block: check BLK_FEAT_POLL under q_usage_count Date: Sun, 26 Jan 2025 09:48:34 -0500 Message-Id: <20250126144839.925271-3-sashal@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250126144839.925271-1-sashal@kernel.org> References: <20250126144839.925271-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.13 Content-Transfer-Encoding: 8bit From: Christoph Hellwig [ Upstream commit 958148a6ac061a9a80a184ea678a5fa872d0c56f ] Otherwise feature reconfiguration can race with I/O submission. Also drop the bio_clear_polled in the error path, as the flag does not matter for instant error completions, it is a left over from when we allowed polled I/O to proceed unpolled in this case. Signed-off-by: Christoph Hellwig Reviewed-by: Ming Lei Reviewed-by: Nilay Shroff Reviewed-by: Martin K. Petersen Link: https://lore.kernel.org/r/20250110054726.1499538-4-hch@lst.de Signed-off-by: Jens Axboe Signed-off-by: Sasha Levin --- block/blk-core.c | 22 ++++++++++++---------- block/blk-mq.c | 12 ++++++++++-- 2 files changed, 22 insertions(+), 12 deletions(-) diff --git a/block/blk-core.c b/block/blk-core.c index 666efe8fa2020..6309b3f5a89dc 100644 --- a/block/blk-core.c +++ b/block/blk-core.c @@ -629,8 +629,14 @@ static void __submit_bio(struct bio *bio) blk_mq_submit_bio(bio); } else if (likely(bio_queue_enter(bio) == 0)) { struct gendisk *disk = bio->bi_bdev->bd_disk; - - disk->fops->submit_bio(bio); + + if ((bio->bi_opf & REQ_POLLED) && + !(disk->queue->limits.features & BLK_FEAT_POLL)) { + bio->bi_status = BLK_STS_NOTSUPP; + bio_endio(bio); + } else { + disk->fops->submit_bio(bio); + } blk_queue_exit(disk->queue); } @@ -805,12 +811,6 @@ void submit_bio_noacct(struct bio *bio) } } - if (!(q->limits.features & BLK_FEAT_POLL) && - (bio->bi_opf & REQ_POLLED)) { - bio_clear_polled(bio); - goto not_supported; - } - switch (bio_op(bio)) { case REQ_OP_READ: break; @@ -935,7 +935,7 @@ int bio_poll(struct bio *bio, struct io_comp_batch *iob, unsigned int flags) return 0; q = bdev_get_queue(bdev); - if (cookie == BLK_QC_T_NONE || !(q->limits.features & BLK_FEAT_POLL)) + if (cookie == BLK_QC_T_NONE) return 0; blk_flush_plug(current->plug, false); @@ -951,7 +951,9 @@ int bio_poll(struct bio *bio, struct io_comp_batch *iob, unsigned int flags) */ if (!percpu_ref_tryget(&q->q_usage_counter)) return 0; - if (queue_is_mq(q)) { + if (!(q->limits.features & BLK_FEAT_POLL)) { + ret = 0; + } else if (queue_is_mq(q)) { ret = blk_mq_poll(q, cookie, iob, flags); } else { struct gendisk *disk = q->disk; diff --git a/block/blk-mq.c b/block/blk-mq.c index 8ac19d4ae3c0a..0137a995b9f37 100644 --- a/block/blk-mq.c +++ b/block/blk-mq.c @@ -3092,14 +3092,22 @@ void blk_mq_submit_bio(struct bio *bio) } /* - * Device reconfiguration may change logical block size, so alignment - * check has to be done with queue usage counter held + * Device reconfiguration may change logical block size or reduce the + * number of poll queues, so the checks for alignment and poll support + * have to be done with queue usage counter held. */ if (unlikely(bio_unaligned(bio, q))) { bio_io_error(bio); goto queue_exit; } + if ((bio->bi_opf & REQ_POLLED) && + !(q->limits.features & BLK_FEAT_POLL)) { + bio->bi_status = BLK_STS_NOTSUPP; + bio_endio(bio); + goto queue_exit; + } + bio = __bio_split_to_limits(bio, &q->limits, &nr_segs); if (!bio) goto queue_exit; -- 2.39.5