From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ED87B1DB153; Sun, 26 Jan 2025 15:00:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737903643; cv=none; b=GsNQnRzEJygDXTVL3tsDQzYiJf97xNsDedJui2wX/AydJwkCQlTrkzYCxXcMuhf45NmCMkRdVQ71/7ZV5Eiw1ognf5q8lFFJnhxDzZ+Z/3ClqFzpV+1b/N/xtp757LBUgokb/by5sQWY+VG3R/lJyjJlAFoQOJhdnxtd0+NMRLI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737903643; c=relaxed/simple; bh=HXqL78sZik6H23vTIxYvBkLpixgaBLaFsq92U1yLzak=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version:Content-Type; b=ShMd45rLmAbvonfWFLINpV++uFzl8rBNc0DI4U/Zo7JEvACMx/qoNUjd3prpubmqqEJt5qSl+W5wkGpLRbAef6EFXDrPXq9Ifz8TqivWelrt+GHUJl1QIUpw2KDIFYZ+kdCyBpPa6p3xUp9+GWoW1nGeEpSq6y1TvFweLri2I30= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=EV3c+3KP; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="EV3c+3KP" Received: by smtp.kernel.org (Postfix) with ESMTPSA id BF9AFC4CED3; Sun, 26 Jan 2025 15:00:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1737903642; bh=HXqL78sZik6H23vTIxYvBkLpixgaBLaFsq92U1yLzak=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=EV3c+3KPlUimxYfWehixWfIZgKA1/KxkS/WmMLFJOloWTAoMFkh9ytNtOn8j21kpt pUX4t7MXpng8mK3D85yqjaZZGtHzI2MTfJlpC7/HRES0QxYj+xcMBwdIntCRK70kd0 eUnyhdLrWl2Jy9gXj33+zXzM3V2rrDP6H+FoqdiX6ezmUUi3TA2R6RT8eNXt6mo90S das4bWYaIcZ+/Or8oC2rxBxHJAeJRXIf8T/5ti4NEv9B4oJRc8AYITjX4xhSN8/dII VDtEWDhhXiKXRxGScr5kPBkTLnBtB3iO6aF8hvUce2ZP/2AMu49fDP+yVWwwCxKsU9 McQYICTG7Etww== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Jiri Kosina , =?UTF-8?q?Ulrich=20M=C3=BCller?= , WangYuli , Sasha Levin , jikos@kernel.org, bentiss@kernel.org, linux-input@vger.kernel.org Subject: [PATCH AUTOSEL 6.13 07/35] Revert "HID: multitouch: Add support for lenovo Y9000P Touchpad" Date: Sun, 26 Jan 2025 10:00:01 -0500 Message-Id: <20250126150029.953021-7-sashal@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250126150029.953021-1-sashal@kernel.org> References: <20250126150029.953021-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.13 Content-Transfer-Encoding: 8bit From: Jiri Kosina [ Upstream commit 3d88ba86ba6f35a0467f25a88c38aa5639190d04 ] This reverts commit 251efae73bd46b097deec4f9986d926813aed744. Quoting Wang Yuli: "The 27C6:01E0 touchpad doesn't require the workaround and applying it would actually break functionality. The initial report came from a BBS forum, but we suspect the information provided by the forum user may be incorrect which could happen sometimes. [1] Further investigation showed that the Lenovo Y9000P 2024 doesn't even use a Goodix touchpad. [2] For the broader issue of 27c6:01e0 being unusable on some devices, it just need to address it with a libinput quirk. In conclusion, we should revert this commit, which is the best solution." Reported-by: Ulrich Müller Reported-by: WangYuli Link: https://lore.kernel.org/all/uikt4wwpw@gentoo.org/ Signed-off-by: Jiri Kosina Signed-off-by: Sasha Levin --- drivers/hid/hid-ids.h | 1 - drivers/hid/hid-multitouch.c | 8 ++------ 2 files changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h index 1f47fda809b9a..d1d479ca50a21 100644 --- a/drivers/hid/hid-ids.h +++ b/drivers/hid/hid-ids.h @@ -506,7 +506,6 @@ #define USB_DEVICE_ID_GENERAL_TOUCH_WIN8_PIT_E100 0xe100 #define I2C_VENDOR_ID_GOODIX 0x27c6 -#define I2C_DEVICE_ID_GOODIX_01E0 0x01e0 #define I2C_DEVICE_ID_GOODIX_01E8 0x01e8 #define I2C_DEVICE_ID_GOODIX_01E9 0x01e9 #define I2C_DEVICE_ID_GOODIX_01F0 0x01f0 diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c index 785743036647c..65023bfe30ed2 100644 --- a/drivers/hid/hid-multitouch.c +++ b/drivers/hid/hid-multitouch.c @@ -1460,8 +1460,7 @@ static const __u8 *mt_report_fixup(struct hid_device *hdev, __u8 *rdesc, { if (hdev->vendor == I2C_VENDOR_ID_GOODIX && (hdev->product == I2C_DEVICE_ID_GOODIX_01E8 || - hdev->product == I2C_DEVICE_ID_GOODIX_01E9 || - hdev->product == I2C_DEVICE_ID_GOODIX_01E0)) { + hdev->product == I2C_DEVICE_ID_GOODIX_01E9)) { if (rdesc[607] == 0x15) { rdesc[607] = 0x25; dev_info( @@ -2085,10 +2084,7 @@ static const struct hid_device_id mt_devices[] = { I2C_DEVICE_ID_GOODIX_01E8) }, { .driver_data = MT_CLS_WIN_8_FORCE_MULTI_INPUT_NSMU, HID_DEVICE(BUS_I2C, HID_GROUP_ANY, I2C_VENDOR_ID_GOODIX, - I2C_DEVICE_ID_GOODIX_01E9) }, - { .driver_data = MT_CLS_WIN_8_FORCE_MULTI_INPUT_NSMU, - HID_DEVICE(BUS_I2C, HID_GROUP_ANY, I2C_VENDOR_ID_GOODIX, - I2C_DEVICE_ID_GOODIX_01E0) }, + I2C_DEVICE_ID_GOODIX_01E8) }, /* GoodTouch panels */ { .driver_data = MT_CLS_NSMU, -- 2.39.5