Re: [PATCH] s390: Add '-std=gnu11' to decompressor and purgatory CFLAGS

Heiko Carstens
2025-01-28T07:53:38Z

On Mon, Jan 27, 2025 at 02:09:36PM -0700, Nathan Chancellor wrote:
> On Thu, Jan 23, 2025 at 11:40:40AM +0100, Alexander Gordeev wrote:
> > > Add '-std=gnu11' to the decompressor and purgatory CFLAGS to eliminate
> > > these errors and make the C standard version of these areas match the
> > > rest of the kernel.
> > >
> > > Cc: stable@vger.kernel.org
> > > Signed-off-by: Nathan Chancellor <nathan@kernel.org>
> > ...
> > > ---
> > > arch/s390/Makefile | 2 +-
> > > arch/s390/purgatory/Makefile | 2 +-
> > > 2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > Applied, thanks!
>
> I noticed that a Fixes tag got added to this change in the s390 tree but
> I do not think it is correct, as I would expect this issue to be visible
> prior to that change. I think this will need to go back to all supported
> stable versions to allow building with GCC 15. It seems like maybe the
> tags from the parent commit (0a89123deec3) made it into my change?

Yes, looks like b4 picked up the tags from my inline patch I sent as
reply to your patch. The following tags shouldn't have been added:

+ Closes: https://lore.kernel.org/r/20250122-s390-fix-std-for-gcc-15-v1-1-8b00cadee083@kernel.org
+ Fixes: b2bc1b1a77c0 ("s390/bitops: Provide optimized arch_test_bit()")
+ Signed-off-by: Heiko Carstens <hca@linux.ibm.com>

Alexander?