Re: [PATCH] s390: Add '-std=gnu11' to decompressor and purgatory CFLAGS

Nathan Chancellor
2025-01-29T00:16:25Z

On Tue, Jan 28, 2025 at 09:25:47AM +0100, Alexander Gordeev wrote:
> > > I noticed that a Fixes tag got added to this change in the s390 tree but
> > > I do not think it is correct, as I would expect this issue to be visible
> > > prior to that change. I think this will need to go back to all supported
> > > stable versions to allow building with GCC 15. It seems like maybe the
> > > tags from the parent commit (0a89123deec3) made it into my change?
> >
> > Yes, looks like b4 picked up the tags from my inline patch I sent as
> > reply to your patch. The following tags shouldn't have been added:
> >
> > + Closes: https://lore.kernel.org/r/20250122-s390-fix-std-for-gcc-15-v1-1-8b00cadee083@kernel.org
> > + Fixes: b2bc1b1a77c0 ("s390/bitops: Provide optimized arch_test_bit()")
> > + Signed-off-by: Heiko Carstens <hca@linux.ibm.com>
> >
> > Alexander?
>
> Yes, I think that is exactly what happened.
>
> @Nathan, thanks a lot for pointing this out!

Aha, that definitely makes sense. The result looks good to me now,
thanks for the quick fix!

Cheers,
Nathan