From: Lothar Rubusch <l.rubusch@gmail.com>
To: lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org
Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
eraretuya@gmail.com, l.rubusch@gmail.com
Subject: [PATCH v1 00/12] iio: accel: adxl345: add interrupt based sensor events
Date: Tue, 28 Jan 2025 12:00:48 +0000 [thread overview]
Message-ID: <20250128120100.205523-1-l.rubusch@gmail.com> (raw)
Add several interrupt based sensor detection events:
- single tap
- double tap
- free fall
- activity
- inactivity
All the needed parameters for each and methods of adjusting them, and
forward a resulting IIO event for each to the IIO channel.
The sensor has further features still not covered:
- g-ranges scaled by different ODRs, especially for activity / inactivity
threshold is not covered so far. There seems to be a particularity with
the ADXL345 as annotated on some analog FAQ.
- Various thinks like low power, sleep mode, etc. are (still) not covered
here, others (ACDC bit, selftest, etc.) currently are hard coded or not
covered.
Signed-off-by: Lothar Rubusch <l.rubusch@gmail.com>
---
Questions:
- Do I need a mutex/lock protection as this is the case e.g. in the ADXL367
or the ADXL380?
Actually, I understand those cases as protecting access to the state
object by different channels, temperature and accelerometer. I'm unsure
if this is a correct understanding, where for the ADXL345 there should
not be any issue. At most, a currently displayed value on sysfs is
(still) not updated. So, IMHO I can rely on the internal protections in
regmap no further mutex is needed. Please, can you give me a feedback
here?
- FIELD_PREP/FIELD_GET: I'd like to use arrays of enum indexed elements
to allow for more generic function implementation passing just a "type"
field, e.g. at single tap/double tap or activity/inactivity handling.
When it comes to filtering out bits using FIELD_GET/FIELD_PREP, it says
that this enum array element is not "const enough". Is there a
work-around?
Lothar Rubusch (12):
iio: accel: adxl345: migrate constants to core
iio: accel: adxl345: reorganize measurement enable
iio: accel: adxl345: add debug register access
iio: accel: adxl345: reorganize irq handler
iio: accel: adxl345: improve access to the interrupt enable register
iio: accel: adxl345: add single tap feature
iio: accel: adxl345: show tap status and direction
iio: accel: adxl345: add double tap feature
iio: accel: adxl345: add double tap suppress bit
iio: accel: adxl345: add freefall feature
iio: accel: adxl345: add activity feature
iio: accel: adxl345: add inactivity feature
drivers/iio/accel/adxl345.h | 86 ---
drivers/iio/accel/adxl345_core.c | 1150 ++++++++++++++++++++++++++++--
2 files changed, 1099 insertions(+), 137 deletions(-)
--
2.39.5
next reply other threads:[~2025-01-28 12:01 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-28 12:00 Lothar Rubusch [this message]
2025-01-28 12:00 ` [PATCH v1 01/12] iio: accel: adxl345: migrate constants to core Lothar Rubusch
2025-02-01 16:35 ` Jonathan Cameron
2025-02-04 14:13 ` Lothar Rubusch
2025-02-04 14:46 ` Jonathan Cameron
2025-01-28 12:00 ` [PATCH v1 02/12] iio: accel: adxl345: reorganize measurement enable Lothar Rubusch
2025-02-01 16:37 ` Jonathan Cameron
2025-01-28 12:00 ` [PATCH v1 03/12] iio: accel: adxl345: add debug register access Lothar Rubusch
2025-01-28 12:00 ` [PATCH v1 04/12] iio: accel: adxl345: reorganize irq handler Lothar Rubusch
2025-02-01 16:43 ` Jonathan Cameron
2025-01-28 12:00 ` [PATCH v1 05/12] iio: accel: adxl345: improve access to the interrupt enable register Lothar Rubusch
2025-02-01 16:49 ` Jonathan Cameron
2025-01-28 12:00 ` [PATCH v1 06/12] iio: accel: adxl345: add single tap feature Lothar Rubusch
2025-02-01 17:02 ` Jonathan Cameron
2025-01-28 12:00 ` [PATCH v1 07/12] iio: accel: adxl345: show tap status and direction Lothar Rubusch
2025-02-01 17:09 ` Jonathan Cameron
2025-01-28 12:00 ` [PATCH v1 08/12] iio: accel: adxl345: add double tap feature Lothar Rubusch
2025-02-01 17:15 ` Jonathan Cameron
2025-01-28 12:00 ` [PATCH v1 09/12] iio: accel: adxl345: add double tap suppress bit Lothar Rubusch
2025-02-01 17:17 ` Jonathan Cameron
2025-01-28 12:00 ` [PATCH v1 10/12] iio: accel: adxl345: add freefall feature Lothar Rubusch
2025-02-01 17:22 ` Jonathan Cameron
2025-01-28 12:00 ` [PATCH v1 11/12] iio: accel: adxl345: add activity feature Lothar Rubusch
2025-02-01 17:27 ` Jonathan Cameron
2025-02-04 13:48 ` Lothar Rubusch
2025-01-28 12:01 ` [PATCH v1 12/12] iio: accel: adxl345: add inactivity feature Lothar Rubusch
2025-02-01 17:41 ` Jonathan Cameron
2025-02-01 17:48 ` [PATCH v1 00/12] iio: accel: adxl345: add interrupt based sensor events Jonathan Cameron
2025-02-04 13:40 ` Lothar Rubusch
2025-02-08 12:57 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250128120100.205523-1-l.rubusch@gmail.com \
--to=l.rubusch@gmail.com \
--cc=Michael.Hennerich@analog.com \
--cc=eraretuya@gmail.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox