From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1FE0D1AAE08 for ; Tue, 28 Jan 2025 13:39:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738071585; cv=none; b=a1mPxN5rsc+wbJN1ysffMwCV+WICL/6r2Yhw7SjH8KhkINnc12sTFwM2guhf+js7VJwOrAOjVfeAKsmVTlYGKBsNJkTu72L7hBS1s9mahjDT2+XIgLp9H1U/6AoFKa3Nd0WvjGn9IE2A2QsXdt23QLm0kWc/L4T4vnR5q8yLJwI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738071585; c=relaxed/simple; bh=8YwoeVS/XmIWopqyLGAYx78wP3cqW3SI6yiDMS7cgqk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=C1JjhvDwgYJg1yxviJPPoggEbKLCa8ycstquv2JM6RM9QZg2HhIDAXCk14ao2uS4AAwdSGPMb+QtA7MfXyXMapoeQN40wGEE3+K8NDkwdV1sblyjsGLbQnXM1H+3IVvc+wALHSjqsEMZnatCwDe2RpsftABW7WXGCKs0iIesU4o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ionos.com; spf=pass smtp.mailfrom=ionos.com; dkim=pass (2048-bit key) header.d=ionos.com header.i=@ionos.com header.b=fufaeNUN; arc=none smtp.client-ip=209.85.221.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ionos.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ionos.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ionos.com header.i=@ionos.com header.b="fufaeNUN" Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-3862d16b4f5so3478922f8f.0 for ; Tue, 28 Jan 2025 05:39:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ionos.com; s=google; t=1738071581; x=1738676381; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Z8ARVoEcuhaiyy7y8Dw3Fh+k6qruQ+ILlqwd0Qs/TsM=; b=fufaeNUN+R5yDmPzs0Ok6sn/vINkAu8P/DIB1csZmkax2fV5fZhiDUxY1hM2Oj+9Bg 2uvMUqBt7d+oi0dBabSMVoDE8Jcsav7xJtp6MZIVO/I9umY7Fsp2p9ZZnRIQbYYz1dsN GHxfx9n66iLu2qezrJtJ6rCxBv1PabhsBXpal/YhVHbsqewzcbd1sQMqm1miPlcQHeMp TwQRLZhvp8TKX5g0i+dZX9d79j7i9XjaPKDH8yLpNPYE2FGOOX4RSBLc9IACdqPgiBho GqOiIr792JpMKiVwd+kOdmxZaU1enzS/uTePBegMcQiBXCxWyej1iHS7Mm7/PWn+K64H elyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738071581; x=1738676381; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Z8ARVoEcuhaiyy7y8Dw3Fh+k6qruQ+ILlqwd0Qs/TsM=; b=xTfLV0lJyhlr2IysCCVvT3+feV6ikwj2GMnlzh6T32SwU9BYRGcJgCIsjY2Pp/Ua7l IIHK8ewRFh4TgDWAZ9xUdpeaQu5Dv4RB+DccV5MmbfWn9biv/vGOuhulWpSbA7Ckej+N SMW82K9EwHEacaSUH0QcZamMQQI6tZgL5nV5xCACVoSrkaUZoi61vL0ruhofUgzNX3cU P/09uN+GAfioz5SOdA3F3b2Gb4Z9bMsDx78ICGaAteR7ta/XrS2CNSc5XAk5o9kbsOZn dK9HD3Y1EqA2STzq8+Ofcq//3FZhLFAvZ8yJZFbkRyAGlZPoFwjuQa5r8lrkGNcva5md Ag9Q== X-Forwarded-Encrypted: i=1; AJvYcCXB4r3U047TPUmq/fUX1c59zAHtYSDjF7nsPjBbrenaOlszDTDKC3yBPb2rRtHnsub3DLLZTrYZc9Y7IG0=@vger.kernel.org X-Gm-Message-State: AOJu0YxZt0XBCwD4Kqf321mQrS9wgDT3zsuzLJKVbYv/2/PZbRPyhwJK 82CzmBedl9v/bRm0kAmtmRkKfj6HNZFPUNyTwRj9XeYLam7MafbhL1h9+Cccpd0= X-Gm-Gg: ASbGncssd8wGpaGdQnMWAbMUWCQW8Qd33sgGlDIcr9u2QkiHFG4aMggw2wzXKzkDcc0 ubAwkrMrVDdBjOO02FX5PhTdai14QszdlQyoJYz8eL4X20h9CfaAHCLmIo7jO2tCX7XIda18/dC 2J8mW1VU3Eafy3ZMxGXCGNSHQ51oH/re3t15v8nlB3/Z3jldRdKZQRH+pkx+MJFiWISJ+p1Xqq0 g5Z3sQPy+jrnpcdHPTkzGd1agNvpIUeWEx8RcAVv+4RHWV67ynv6YCJwS3EqQZH1FJsAGUieny+ MyxbhVc/te0s/VYcGFKox0cP6vGIiYVGgz9uCxc6cl/qxlZ+s3b/tFq2xleZtI74L7igStlAbuX Q3yFm9E/umo0PL2f2ee+ZO6XEEQ== X-Google-Smtp-Source: AGHT+IGul3WSFjDA3kUrmEFfTfFX20BTEU/HgvE7YsOUr9tBZ+dCaFW4q6pwq1qDAzOy8oJKT4N7WA== X-Received: by 2002:a5d:6daf:0:b0:38b:ee01:ae2 with SMTP id ffacd0b85a97d-38c49a27186mr2274103f8f.10.1738071581332; Tue, 28 Jan 2025 05:39:41 -0800 (PST) Received: from raven.intern.cm-ag (p200300dc6f2b6900023064fffe740809.dip0.t-ipconnect.de. [2003:dc:6f2b:6900:230:64ff:fe74:809]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38c2a1bb02dsm14160780f8f.70.2025.01.28.05.39.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Jan 2025 05:39:41 -0800 (PST) From: Max Kellermann To: axboe@kernel.dk, asml.silence@gmail.com, io-uring@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Max Kellermann Subject: [PATCH 6/8] io_uring/io-wq: pass io_wq to io_get_next_work() Date: Tue, 28 Jan 2025 14:39:25 +0100 Message-ID: <20250128133927.3989681-7-max.kellermann@ionos.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20250128133927.3989681-1-max.kellermann@ionos.com> References: <20250128133927.3989681-1-max.kellermann@ionos.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The only caller has already determined this pointer, so let's skip the redundant dereference. Signed-off-by: Max Kellermann --- io_uring/io-wq.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/io_uring/io-wq.c b/io_uring/io-wq.c index 6e31f312b61a..f7d328feb722 100644 --- a/io_uring/io-wq.c +++ b/io_uring/io-wq.c @@ -485,13 +485,12 @@ static bool io_wait_on_hash(struct io_wq *wq, unsigned int hash) } static struct io_wq_work *io_get_next_work(struct io_wq_acct *acct, - struct io_worker *worker) + struct io_wq *wq) __must_hold(acct->lock) { struct io_wq_work_node *node, *prev; struct io_wq_work *work, *tail; unsigned int stall_hash = -1U; - struct io_wq *wq = worker->wq; wq_list_for_each(node, prev, &acct->work_list) { unsigned int work_flags; @@ -576,7 +575,7 @@ static void io_worker_handle_work(struct io_wq_acct *acct, * can't make progress, any work completion or insertion will * clear the stalled flag. */ - work = io_get_next_work(acct, worker); + work = io_get_next_work(acct, wq); if (work) { /* * Make sure cancelation can find this, even before -- 2.45.2