From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1BB9719DF61 for ; Tue, 28 Jan 2025 14:10:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.176.79.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738073459; cv=none; b=hXS8fBB++C98b4q/16FkQUzNpqNnSrl3YdEj4fRQE8ar/vZUxrx15vH3DAOqZF8O83LBWTYFR0icje9IRbOgniXv7/MoDqkxAViqkKcFPSzDbY7WBT5bEx/35VffORNmVxKuQarpk9SIJoq/pgEVggCo+3nTHXk1q6Z5PX0SmRc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738073459; c=relaxed/simple; bh=wR70iL5MUGzD/BMurkUhbK+oUBxdGPQXrL1t4448PlQ=; h=Date:From:To:CC:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=uiIw7r/ORagXHCL0b3xLB57R5IdcUFuYTcgBeuKxqRkeUGoRPq9pi9hZjgu4Gb9GnQkalzE5WGB1pjXRoTiepR6t8fTfPYd1stK69ll/HjRYJzOB4BRZlyK9V1zP0iV4v5bRGqbWKdYXWXCpKsfyXLtf7QCgbaHxIdMwYI8SUHo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=185.176.79.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.18.186.31]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4Yj6cr5w1Kz6K8kL; Tue, 28 Jan 2025 22:10:20 +0800 (CST) Received: from frapeml500008.china.huawei.com (unknown [7.182.85.71]) by mail.maildlp.com (Postfix) with ESMTPS id 164C61402DB; Tue, 28 Jan 2025 22:10:54 +0800 (CST) Received: from localhost (10.195.245.182) by frapeml500008.china.huawei.com (7.182.85.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Tue, 28 Jan 2025 15:10:53 +0100 Date: Tue, 28 Jan 2025 14:10:51 +0000 From: Jonathan Cameron To: Mauro Carvalho Chehab CC: Igor Mammedov , "Michael S . Tsirkin" , Shiju Jose , , , Ani Sinha , Dongjiu Geng , Subject: Re: [PATCH 02/11] acpi/ghes: add a firmware file with HEST address Message-ID: <20250128141051.00000899@huawei.com> In-Reply-To: <20250128110034.650445fc@foz.lan> References: <20250123100217.00007373@huawei.com> <20250128110034.650445fc@foz.lan> X-Mailer: Claws Mail 4.3.0 (GTK 3.24.42; x86_64-w64-mingw32) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: lhrpeml100004.china.huawei.com (7.191.162.219) To frapeml500008.china.huawei.com (7.182.85.71) On Tue, 28 Jan 2025 11:00:34 +0100 Mauro Carvalho Chehab wrote: > Em Thu, 23 Jan 2025 10:02:17 +0000 > Jonathan Cameron escreveu: > > > On Wed, 22 Jan 2025 16:46:19 +0100 > > Mauro Carvalho Chehab wrote: > > > > > Store HEST table address at GPA, placing its content at > > > hest_addr_le variable. > > > > > > Signed-off-by: Mauro Carvalho Chehab > > > Reviewed-by: Jonathan Cameron > > > > > A few trivial things inline. > > > > Jonathan > > > > > --- > > > > > > Change from v8: > > > - hest_addr_lr is now pointing to the error source size and data. > > > > > > Signed-off-by: Mauro Carvalho Chehab > > Bonus. I guess you really like this patch :) > > > --- > > > hw/acpi/ghes.c | 17 ++++++++++++++++- > > > include/hw/acpi/ghes.h | 1 + > > > 2 files changed, 17 insertions(+), 1 deletion(-) > > > > > > diff --git a/hw/acpi/ghes.c b/hw/acpi/ghes.c > > > index 3f519ccab90d..34e3364d3fd8 100644 > > > --- a/hw/acpi/ghes.c > > > +++ b/hw/acpi/ghes.c > > > @@ -30,6 +30,7 @@ > > > > > > #define ACPI_HW_ERROR_FW_CFG_FILE "etc/hardware_errors" > > > #define ACPI_HW_ERROR_ADDR_FW_CFG_FILE "etc/hardware_errors_addr" > > > +#define ACPI_HEST_ADDR_FW_CFG_FILE "etc/acpi_table_hest_addr" > > > > > > /* The max size in bytes for one error block */ > > > #define ACPI_GHES_MAX_RAW_DATA_LENGTH (1 * KiB) > > > @@ -261,7 +262,7 @@ static void build_ghes_error_table(GArray *hardware_errors, BIOSLinker *linker, > > > } > > > > > > /* > > > - * tell firmware to write hardware_errors GPA into > > > + * Tell firmware to write hardware_errors GPA into > > > > Sneaky tidy up. No problem with it in general but adding noise here, so if there > > are others in the series maybe gather them up in a cleanup patch. > > There are no other cleanups pending. Besides, as you noticed, this > aligns with the comment below. So, I'm opting to add a note at the > patch's description. ok. > > > > + * once initialized. > > > + */ > > > + bios_linker_loader_write_pointer(linker, > > > + ACPI_HEST_ADDR_FW_CFG_FILE, 0, > > > > Could wrap less and stay under 80 chars as both lines above add up to 70 something > > Why? This follows QEMU coding style and lines aren't longer than 80 > columns. Besides, at least for my eyes and some experience doing maintainership > on other projects over the years, it is a lot quicker to identify function > parameters if they're properly aligned with the parenthesis. Ah. I didn't state this clearly enough. bios_linker_loader_write_pointer(linker, ACPI_HEST_ADDR_FW_CFG_FILE, 0, is also under 80 chars. > > Thanks, > Mauro