From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5D66ABE40 for ; Tue, 28 Jan 2025 14:20:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738074028; cv=none; b=XpLLbck7KKRNNE05bHs4H/+3ZWenj6RYqe7DBUaMDoRKJUeE0uiZlybvmKRuCAMUd+dAJGXn91hcz56K8Fm2NTbPEOJY8wCczO5H9eQMx9zud6CAOgBynpb0f+tsF+FHnu9HMUeriGRMiwkyairwNqmqgasWuYPKd9lwchfnyz0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738074028; c=relaxed/simple; bh=0MZs5idq0szx9AV9ILdGQMpK/KTQRHnhZ74NQ8sF/NY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=cOfv0lwh1wOI4ig2FF10q7auND/+QJArcNizEt5b6vlA9oHyzaXGdcDy+5G3Kkr3PcH3a5cWEViU1Q1cGBjM44beV1bqdVNWrqCxmELObXHiOUPI4ZcbLDIfnwnjFLluID4HghvvFN4zO5+Or1KjFfHhziQL4PFUqliU8STmyLg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=LIvS/djk; arc=none smtp.client-ip=209.85.214.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="LIvS/djk" Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-2166360285dso96744555ad.1 for ; Tue, 28 Jan 2025 06:20:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1738074024; x=1738678824; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=F3KCYjdWMMGDvOb9PKKoJ+9LqVtNjKtc1PkbXjIXAiM=; b=LIvS/djkUx6eBmJdqoahH+zD5vULNKX/uz3fUinRpjYSLgBOItTxF6wea5wWsznNXE hYg6/YYV/g87nfuUWbIrI2rot86NLm8Iyvl8c3fXoPK2gbt7By/qMWfF4cI1TRU9drbs A52YQAIseq6bwySxXg1l4m4iCuMLP0Fs8JXHw34jlrIKg5050dZWzG/0MrVVVSQ6M4z0 dGitJ377U/ZCz3RvjJuXhgMK+OKAHgNTnQlE5PmWc17/otWtMwNBqIMmDOewF3mtYj4E Py84gy/DghnfnO1vVRDXrydWsPnb6Hdamg/ptj9q/vJfK8yNZ/hGWmNHdYiNIqb1FERt 9XiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738074024; x=1738678824; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=F3KCYjdWMMGDvOb9PKKoJ+9LqVtNjKtc1PkbXjIXAiM=; b=VtJEx/ZKU37LKNln1rq8kxcEdusXecAnbYlkMgCbFSNTPzwt9h1baVc3tLJTTysgfE 70v255CBIMsmlJuhUrBodFoOACYyHKt/rYn0n/G8jgD1wkEDuL80vufuHjicJGRcZ786 Hi7fgHkeUion1KhVEimoPrAn9PZF/hcXgmUlk9g/6sBz4RggO1++L56IjDVdeS2M21M9 baN6hOAifWeV99AqCz/N9GtmoUPUBwmZ5fDElggs1NLxOxjifAVmCUBk3+ZK7r6VARGk 7Yt8AKU3S56pK9yATjkjJfG5pCSGxjwVuIHYAC+1vQFhU4rs4qiAGv0oXKP5lfnGKKDJ j/Qw== X-Forwarded-Encrypted: i=1; AJvYcCVA6Twm4TMKkTv8FcLpJ0+bVY2G1QcOXjhww6rjJXRMyPkmuVqDjSf+/NPI2E/cfrdd6ynVi11DnCoJMSg=@vger.kernel.org X-Gm-Message-State: AOJu0YzuFww/p9U3Uq6LvoZJ44cE9XLS+dXcgkpfoO0TZ6tylCe29Eb4 Bx/jjFse3slJ2ctoqjcCq5iu8NeQMhFYraAVwEDlo5ob4Z+iTLNJwNpyK4aq9Q== X-Gm-Gg: ASbGncuADsVQgO7J75bw7DIBaiYQODn+Y11SNZwtasyVbO3m5QKZlRiBRb6nEM9/ZIA UkSXaxtjyqebqBbCS6fVgMB42tt5mOuicgXQsIwxV1un3jndj72Tep4O59Yg9txeN+dwaAR6dNQ Z886/olkpo6yafUod36GaHiHqxekvvLwz7bB7+0qLRfm7wrPfL5RBWBA6HYEnMOK1HHUlprZ627 8TPa6f1tcm7GFfOm8MyAClWkDbVcJ+E5+EZ2w0RiZGw63dFSBaUZI2KChseXZKwqaO1SiAx+BwG xE2/VSXR4Gr4bgTL4dMYm77Q5tk= X-Google-Smtp-Source: AGHT+IE1wVU9w8+Wk88CIRXF+UdLrqy0+JwQsDxv9zxbMcNk1CdQIbSdxAv48cv6r/JMBAYdgV50sA== X-Received: by 2002:a05:6a21:32a2:b0:1e0:dcc5:164d with SMTP id adf61e73a8af0-1eb214650bfmr72004607637.8.1738074024634; Tue, 28 Jan 2025 06:20:24 -0800 (PST) Received: from thinkpad ([120.60.131.121]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-ac48e84e411sm8298835a12.2.2025.01.28.06.20.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Jan 2025 06:20:24 -0800 (PST) Date: Tue, 28 Jan 2025 19:50:17 +0530 From: Manivannan Sadhasivam To: Kunihiko Hayashi Cc: Krzysztof =?utf-8?B?V2lsY3p577+977+977+9c2tp?= , Kishon Vijay Abraham I , Arnd Bergmann , Greg Kroah-Hartman , Lorenzo Pieralisi , Gustavo Pimentel , Bjorn Helgaas , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH v2 2/3] misc: pci_endpoint_test: Fix disyplaying irq_type after request_irq error Message-ID: <20250128142017.hoq77lo3aybbbgqr@thinkpad> References: <20250122022446.2898248-1-hayashi.kunihiko@socionext.com> <20250122022446.2898248-3-hayashi.kunihiko@socionext.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20250122022446.2898248-3-hayashi.kunihiko@socionext.com> On Wed, Jan 22, 2025 at 11:24:45AM +0900, Kunihiko Hayashi wrote: > There are two variables that indicate the interrupt type to be used > in the next test execution, global "irq_type" and test->irq_type. > > The former is referenced from pci_endpoint_test_get_irq() to preserve > the current type for ioctl(PCITEST_GET_IRQTYPE). > > In pci_endpoint_test_request_irq(), since this global variable is > referenced when an error occurs, the unintended error message is > displayed. > > For example, the following message shows "MSI 3" even if the current > irq type becomes "MSI-X". > > # pcitest -i 2 > pci-endpoint-test 0000:01:00.0: Failed to request IRQ 30 for MSI 3 > SET IRQ TYPE TO MSI-X: NOT OKAY > > Fix this issue by using test->irq_type instead of global "irq_type". > > Cc: stable@vger.kernel.org > Fixes: b2ba9225e031 ("misc: pci_endpoint_test: Avoid using module parameter to determine irqtype") > Signed-off-by: Kunihiko Hayashi Reviewed-by: Manivannan Sadhasivam - Mani > --- > drivers/misc/pci_endpoint_test.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/misc/pci_endpoint_test.c b/drivers/misc/pci_endpoint_test.c > index 302955c20979..a342587fc78a 100644 > --- a/drivers/misc/pci_endpoint_test.c > +++ b/drivers/misc/pci_endpoint_test.c > @@ -235,7 +235,7 @@ static bool pci_endpoint_test_request_irq(struct pci_endpoint_test *test) > return true; > > fail: > - switch (irq_type) { > + switch (test->irq_type) { > case IRQ_TYPE_INTX: > dev_err(dev, "Failed to request IRQ %d for Legacy\n", > pci_irq_vector(pdev, i)); > -- > 2.25.1 > -- மணிவண்ணன் சதாசிவம்