From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from vmicros1.altlinux.org (vmicros1.altlinux.org [194.107.17.57]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D32981917D9; Tue, 28 Jan 2025 16:17:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=194.107.17.57 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738081060; cv=none; b=N8e+6MzkZqFw4CPMDBOkH0se1UD3vtw6BeOTcD9M0bM0G3jvDGX+8MWv6605jBTDj+7dLrknwa7WWrCEl3Xnx8vCzT1PjAbONRDBE7Imjq3R/H6P3mrh6OW01NsKt1LD3X9XXjKIFs9uFRVM0FNB3SG/6j6QrKC8Fzu49DsXHUI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738081060; c=relaxed/simple; bh=1rAnESrp98XX9zn6uey7DNA9KhLQZqbja+I9R0d1iyg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=DbXj+tzvwhIfJ/URP67Sf1lTFPRQLiFFaeie8S9NK5OZGzpr2lLZGjhGf4bOadRbJxWHK8AXWLoFmtTnkQWXirE40MGf9O0O/jjVfHU+nm1oNS3f1fTkdPdGDzGaRdJ0jS5mKwH+eMqJRCe3oRkZLIjynCqGCn6DAKeI+MAhVyw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=strace.io; spf=pass smtp.mailfrom=altlinux.org; arc=none smtp.client-ip=194.107.17.57 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=strace.io Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=altlinux.org Received: from mua.local.altlinux.org (mua.local.altlinux.org [192.168.1.14]) by vmicros1.altlinux.org (Postfix) with ESMTP id CDC6672C97D; Tue, 28 Jan 2025 19:17:37 +0300 (MSK) Received: by mua.local.altlinux.org (Postfix, from userid 508) id B9EE97CCB3A; Tue, 28 Jan 2025 18:17:37 +0200 (IST) Date: Tue, 28 Jan 2025 18:17:37 +0200 From: "Dmitry V. Levin" To: Christophe Leroy Cc: Oleg Nesterov , linux-snps-arc@lists.infradead.org, Rich Felker , Thomas Gleixner , Andreas Larsson , John Paul Adrian Glaubitz , x86@kernel.org, Arnd Bergmann , linux-mips@vger.kernel.org, "James E.J. Bottomley" , Guo Ren , "H. Peter Anvin" , sparclinux@vger.kernel.org, linux-hexagon@vger.kernel.org, WANG Xuerui , Will Deacon , Eugene Syromyatnikov , Anton Ivanov , Jonas Bonn , linux-s390@vger.kernel.org, Alexander Gordeev , Madhavan Srinivasan , Vasily Gorbik , Yoshinori Sato , linux-sh@vger.kernel.org, Michael Ellerman , Helge Deller , Huacai Chen , Russell King , linux-csky@vger.kernel.org, Dave Hansen , Ingo Molnar , Vineet Gupta , Christian Borntraeger , strace-devel@lists.strace.io, linux-arch@vger.kernel.org, Albert Ou , Mike Frysinger , Davide Berardi , Renzo Davoli , linux-um@lists.infradead.org, Heiko Carstens , Charlie Jenkins , Naveen N Rao , Nicholas Piggin , Stefan Kristiansson , Borislav Petkov , loongarch@lists.linux.dev, Paul Walmsley , Stafford Horne , linux-arm-kernel@lists.infradead.org, Brian Cain , Thomas Bogendoerfer , linux-parisc@vger.kernel.org, linux-openrisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, Dinh Nguyen , linux-riscv@lists.infradead.org, Palmer Dabbelt , Sven Schnelle , Richard Weinberger , Johannes Berg , Alexey Gladkov , "David S. Miller" Subject: Re: [PATCH v3 2/6] syscall.h: add syscall_set_arguments() and syscall_set_return_value() Message-ID: <20250128161737.GD11869@strace.io> References: <20250128091626.GB8601@strace.io> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Tue, Jan 28, 2025 at 04:04:34PM +0100, Christophe Leroy wrote: > Le 28/01/2025 à 10:16, Dmitry V. Levin a écrit : > > These functions are going to be needed on all HAVE_ARCH_TRACEHOOK > > architectures to implement PTRACE_SET_SYSCALL_INFO API. > > The subject is misleading. syscall_set_return_value() already exists on > most architectures and was not addressed by commit 7962c2eddbfe. > > Maybe it would be better to handle syscall_set_return_value() in a > separate commit. syscall_set_return_value() is being added only on hexagon. I didn't think it worth a separate commit, but it's certainly possible to split this commit into two. -- ldv