From: Nathan Chancellor <nathan@kernel.org>
To: Alexander Gordeev <agordeev@linux.ibm.com>
Cc: Heiko Carstens <hca@linux.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
Christian Borntraeger <borntraeger@linux.ibm.com>,
Sven Schnelle <svens@linux.ibm.com>,
linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH] s390: Add '-std=gnu11' to decompressor and purgatory CFLAGS
Date: Tue, 28 Jan 2025 17:16:21 -0700 [thread overview]
Message-ID: <20250129001621.GA149925@ax162> (raw)
In-Reply-To: <Z5iUi9EdsPPMqlRB@li-008a6a4c-3549-11b2-a85c-c5cc2836eea2.ibm.com>
On Tue, Jan 28, 2025 at 09:25:47AM +0100, Alexander Gordeev wrote:
> > > I noticed that a Fixes tag got added to this change in the s390 tree but
> > > I do not think it is correct, as I would expect this issue to be visible
> > > prior to that change. I think this will need to go back to all supported
> > > stable versions to allow building with GCC 15. It seems like maybe the
> > > tags from the parent commit (0a89123deec3) made it into my change?
> >
> > Yes, looks like b4 picked up the tags from my inline patch I sent as
> > reply to your patch. The following tags shouldn't have been added:
> >
> > + Closes: https://lore.kernel.org/r/20250122-s390-fix-std-for-gcc-15-v1-1-8b00cadee083@kernel.org
> > + Fixes: b2bc1b1a77c0 ("s390/bitops: Provide optimized arch_test_bit()")
> > + Signed-off-by: Heiko Carstens <hca@linux.ibm.com>
> >
> > Alexander?
>
> Yes, I think that is exactly what happened.
>
> @Nathan, thanks a lot for pointing this out!
Aha, that definitely makes sense. The result looks good to me now,
thanks for the quick fix!
Cheers,
Nathan
prev parent reply other threads:[~2025-01-29 0:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-23 2:54 [PATCH] s390: Add '-std=gnu11' to decompressor and purgatory CFLAGS Nathan Chancellor
2025-01-23 8:29 ` Heiko Carstens
2025-01-23 10:40 ` Alexander Gordeev
2025-01-27 21:09 ` Nathan Chancellor
2025-01-28 7:53 ` Heiko Carstens
2025-01-28 8:25 ` Alexander Gordeev
2025-01-29 0:16 ` Nathan Chancellor [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250129001621.GA149925@ax162 \
--to=nathan@kernel.org \
--cc=agordeev@linux.ibm.com \
--cc=borntraeger@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=svens@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox