From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D9FDE19AD8C; Wed, 29 Jan 2025 07:59:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738137598; cv=none; b=PwWkpUh+Cx1s3ogN51IMO+/Ifbb0f8jZhzRE80MXMV6k56SkQENvEojEXgn6uqVUIcLZ1htAiW825KORV2RQRb03av4FeTDIJQcr3ouSMNgRHajiUvfgRnis9Y94T83isxmENeWYDg9bsNkSIZg7IUkCnC1HDQWX++pJwkErre0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738137598; c=relaxed/simple; bh=nL0TTQtq4gD/ROKa9lhyxiBPOLnQoLFl6/akVgzIKJU=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=neTcsCryICyLWyzQbm/qDd6oIUqtY7o0WvXfeFQkdmP58nk/T+3dIu+x6B4YG7trQVjNDV8JixK7SWoyZu0bQM1w2kUThJyyZmE3DJv0xuyuqr8q7OuVZqQE6tMYY0oRn+nGE1kWVoKnb8f3l3+ytI9WbB2uNoBqxTnp4pB51FI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=AWkLzdHh; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="AWkLzdHh" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1738137594; bh=nL0TTQtq4gD/ROKa9lhyxiBPOLnQoLFl6/akVgzIKJU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=AWkLzdHhcpG+P+emxJ33qjiIXsOdHkZjFZ5t8MlnATlGHZ1pxJ9JO2jJDuelpG7eK GztXnDeB+r1xB7ReDJ45is59RCpk06uG2/wnCgtXk7LaS44Lv22L7QsBxIB+AxSZnw HE6k9VGNUILnzdS3rMVmDGH+i0igR7NlMmIV4lDC+2Rb9rfwlwR3hMAsqx5C2Qa+2F Xf88SwKOv8KLBDlxsM6J4RiftfvuUnf2m+ml1uj0wnp2h9ga7J5k5tbvg66hrAWfsh 1u75N87rA1MD03z9aMpYPIeTNMaeIaIxW96GaAWRcUqu582tRU8h3xdGnAZEPTMC57 QZkRFsHTTL2Eg== Received: from localhost (unknown [IPv6:2a01:e0a:2c:6930:5cf4:84a1:2763:fe0d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: bbrezillon) by bali.collaboradmins.com (Postfix) with ESMTPSA id 3DA8C17E0FCA; Wed, 29 Jan 2025 08:59:53 +0100 (CET) Date: Wed, 29 Jan 2025 08:59:46 +0100 From: Boris Brezillon To: Philipp Stanner Cc: Alex Deucher , Christian =?UTF-8?B?S8O2bmln?= , Xinhui Pan , David Airlie , Simona Vetter , Lucas Stach , Russell King , Christian Gmeiner , Frank Binns , Matt Coster , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Qiang Yu , Rob Clark , Sean Paul , Konrad Dybcio , Abhinav Kumar , Dmitry Baryshkov , Marijn Suijten , Karol Herbst , Lyude Paul , Danilo Krummrich , Rob Herring , Steven Price , Liviu Dudau , Matthew Brost , Melissa Wen , =?UTF-8?B?TWHDrXJh?= Canal , Lucas De Marchi , Thomas =?UTF-8?B?SGVsbHN0csO2bQ==?= , Rodrigo Vivi , Sunil Khatri , Lijo Lazar , Hawking Zhang , Mario Limonciello , Ma Jun , Yunxiang Li , amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, etnaviv@lists.freedesktop.org, lima@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, nouveau@lists.freedesktop.org, intel-xe@lists.freedesktop.org Subject: Re: [PATCH v2] drm/sched: Use struct for drm_sched_init() params Message-ID: <20250129085946.69e5ebf2@collabora.com> In-Reply-To: <20250128142927.103290-2-phasta@kernel.org> References: <20250128142927.103290-2-phasta@kernel.org> Organization: Collabora X-Mailer: Claws Mail 4.3.0 (GTK 3.24.43; x86_64-redhat-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Tue, 28 Jan 2025 15:29:27 +0100 Philipp Stanner wrote: > drm_sched_init() has a great many parameters and upcoming new > functionality for the scheduler might add even more. Generally, the > great number of parameters reduces readability and has already caused > one missnaming in: >=20 > commit 6f1cacf4eba7 ("drm/nouveau: Improve variable name in nouveau_sched= _init()"). >=20 > Introduce a new struct for the scheduler init parameters and port all > users. >=20 > Signed-off-by: Philipp Stanner > --- > Changes in v2: > - Point out that the hang-limit is deprecated. (Christian) > - Initialize the structs to 0 at declaration. (Planet Earth) > - Don't set stuff explicitly to 0 / NULL. (Tvrtko) > - Make the structs const where possible. (Boris) > - v3d: Use just 1, universal, function for sched-init. (Ma=C3=ADra) > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 18 ++++-- > drivers/gpu/drm/etnaviv/etnaviv_sched.c | 20 +++---- > drivers/gpu/drm/imagination/pvr_queue.c | 18 ++++-- > drivers/gpu/drm/lima/lima_sched.c | 16 +++-- > drivers/gpu/drm/msm/msm_ringbuffer.c | 17 +++--- > drivers/gpu/drm/nouveau/nouveau_sched.c | 15 +++-- > drivers/gpu/drm/panfrost/panfrost_job.c | 20 ++++--- > drivers/gpu/drm/panthor/panthor_mmu.c | 16 +++-- > drivers/gpu/drm/panthor/panthor_sched.c | 29 +++++---- Panfrost and panthor changes are Reviewed-by: Boris Brezillon > drivers/gpu/drm/scheduler/sched_main.c | 50 ++++++---------- > drivers/gpu/drm/v3d/v3d_sched.c | 68 +++++++++------------- > drivers/gpu/drm/xe/xe_execlist.c | 16 +++-- > drivers/gpu/drm/xe/xe_gpu_scheduler.c | 17 +++++- > include/drm/gpu_scheduler.h | 37 ++++++++++-- > 14 files changed, 206 insertions(+), 151 deletions(-)