Re: [PATCH 01/13] drm/vkms: Extract vkms_connector header

José Expósito
2025-02-11T10:37:57Z

Hi Louis,

First of all, thanks a lot for the review.

I applied all changes you suggested and, especially thanks to the
iterators you suggested, the code is way cleaner and simpler now.

I'll send v2 in a bit, but first I'll comment on some of your
reviews to clarify some porints:

On Thu, Jan 30, 2025 at 02:48:10PM +0100, Louis Chauvet wrote:
> On 29/01/25 - 12:00, José Expósito wrote:
> > Up until now, the logic to manage connectors was in vkms_output.c.
> >
> > Since more options will be added to connectors in the future, extract
> > the code to its own file.
> >
> > Refactor, no functional changes.
> >
> > Signed-off-by: José Expósito <jose.exposito89@gmail.com>
>
> Non blocking issue: Do you think it is possible to split this in two
> different commits: one to create vkms_connector.h/c and one to create
> struct vkms_connector?

Done, I split this patch in 2 in v2.

>
> Reviewed-by: Louis Chauvet <louis.chauvet@bootlin.com>
>
> …