From: Halil Pasic <pasic@linux.ibm.com>
To: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
Cc: Thorsten Blum <thorsten.blum@linux.dev>,
Tony Krowiak <akrowiak@linux.ibm.com>,
Jason Herne <jjherne@linux.ibm.com>,
Harald Freudenberger <freude@linux.ibm.com>,
Holger Dengler <dengler@linux.ibm.com>,
Heiko Carstens <hca@linux.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
Alexander Gordeev <agordeev@linux.ibm.com>,
Christian Borntraeger <borntraeger@linux.ibm.com>,
Sven Schnelle <svens@linux.ibm.com>,
linux-hardening@vger.kernel.org, linux-s390@vger.kernel.org,
linux-kernel@vger.kernel.org, Halil Pasic <pasic@linux.ibm.com>
Subject: Re: [PATCH] s390/vfio-ap: Replace one-element array with flexible array member
Date: Thu, 30 Jan 2025 11:46:15 +0100 [thread overview]
Message-ID: <20250130114615.6f591882.pasic@linux.ibm.com> (raw)
In-Reply-To: <85863d7a-2d8b-4c1b-b76a-e2f40834a7a8@embeddedor.com>
On Thu, 30 Jan 2025 10:30:30 +1030
"Gustavo A. R. Silva" <gustavo@embeddedor.com> wrote:
> On 30/01/25 07:08, Halil Pasic wrote:
> > On Thu, 16 Jan 2025 14:18:59 +0100
> > Thorsten Blum <thorsten.blum@linux.dev> wrote:
> >
> >> Replace the deprecated one-element array with a modern flexible array
> >> member in the struct ap_matrix_dev.
> >>
> >
> > I'm not sure I understand the value of this. What we have here is not
> > a flexible array but a one element array. Something that in the generic
> > case could be many but particularly for vfio-ap is always one.
>
> You are correct. Only fake flexible arrays should be transformed into
> C99 flex-array members [1].
>
> Thanks
> -Gustavo
>
> [1] https://lwn.net/Articles/908817/
>
Thanks! Alex, what do we do with this then? I think you picked it up
yesterday late. And I think, it might make sense to make this look
less like a fake flex-array...
next prev parent reply other threads:[~2025-01-30 10:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-16 13:18 [PATCH] s390/vfio-ap: Replace one-element array with flexible array member Thorsten Blum
2025-01-28 13:56 ` Alexander Gordeev
2025-01-29 14:27 ` Anthony Krowiak
2025-01-29 15:53 ` Alexander Gordeev
2025-01-29 20:38 ` Halil Pasic
2025-01-30 0:00 ` Gustavo A. R. Silva
2025-01-30 10:46 ` Halil Pasic [this message]
2025-01-30 11:37 ` Alexander Gordeev
2025-01-30 12:46 ` Heiko Carstens
2025-01-31 8:06 ` Halil Pasic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250130114615.6f591882.pasic@linux.ibm.com \
--to=pasic@linux.ibm.com \
--cc=agordeev@linux.ibm.com \
--cc=akrowiak@linux.ibm.com \
--cc=borntraeger@linux.ibm.com \
--cc=dengler@linux.ibm.com \
--cc=freude@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=gustavo@embeddedor.com \
--cc=hca@linux.ibm.com \
--cc=jjherne@linux.ibm.com \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=svens@linux.ibm.com \
--cc=thorsten.blum@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox