From: Easwar Hariharan <eahariha@linux.microsoft.com>
To: Thomas Gleixner <tglx@linutronix.de>,
Anna-Maria Behnsen <anna-maria@linutronix.de>,
Easwar Hariharan <eahariha@linux.microsoft.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Luiz Augusto von Dentz <luiz.von.dentz@intel.com>,
Miguel Ojeda <ojeda@kernel.org>,
linux-kernel@vger.kernel.org (open list)
Cc: stable@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>,
kernel test robot <lkp@intel.com>
Subject: [PATCH v2] jiffies: Cast to unsigned long for secs_to_jiffies() conversion
Date: Thu, 30 Jan 2025 19:26:58 +0000 [thread overview]
Message-ID: <20250130192701.99626-1-eahariha@linux.microsoft.com> (raw)
While converting users of msecs_to_jiffies(), lkp reported that some
range checks would always be true because of the mismatch between the
implied int value of secs_to_jiffies() vs the unsigned long
return value of the msecs_to_jiffies() calls it was replacing. Fix this
by casting secs_to_jiffies() values as unsigned long.
Fixes: b35108a51cf7ba ("jiffies: Define secs_to_jiffies()")
CC: stable@vger.kernel.org # 6.13+
CC: Andrew Morton <akpm@linux-foundation.org>
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202501301334.NB6NszQR-lkp@intel.com/
Signed-off-by: Easwar Hariharan <eahariha@linux.microsoft.com>
---
include/linux/jiffies.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/jiffies.h b/include/linux/jiffies.h
index ed945f42e064..0ea8c9887429 100644
--- a/include/linux/jiffies.h
+++ b/include/linux/jiffies.h
@@ -537,7 +537,7 @@ static __always_inline unsigned long msecs_to_jiffies(const unsigned int m)
*
* Return: jiffies value
*/
-#define secs_to_jiffies(_secs) ((_secs) * HZ)
+#define secs_to_jiffies(_secs) (unsigned long)((_secs) * HZ)
extern unsigned long __usecs_to_jiffies(const unsigned int u);
#if !(USEC_PER_SEC % HZ)
--
2.43.0
next reply other threads:[~2025-01-30 19:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-30 19:26 Easwar Hariharan [this message]
2025-01-31 7:06 ` [PATCH v2] jiffies: Cast to unsigned long for secs_to_jiffies() conversion Jiri Slaby
2025-01-31 8:30 ` Thomas Gleixner
2025-01-31 8:52 ` Jiri Slaby
2025-01-31 17:52 ` Easwar Hariharan
2025-01-31 8:43 ` [tip: timers/urgent] jiffies: Cast to unsigned long in " tip-bot2 for Easwar Hariharan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250130192701.99626-1-eahariha@linux.microsoft.com \
--to=eahariha@linux.microsoft.com \
--cc=akpm@linux-foundation.org \
--cc=anna-maria@linutronix.de \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=luiz.von.dentz@intel.com \
--cc=ojeda@kernel.org \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox