Re: [PATCH v3] riscv: Fix the PAUSE Opcode for MIPS P8700.

[Andrew Jones <ajones@ventanamicro.com>]

On Thu, Jan 30, 2025 at 04:59:16PM -0800, Charlie Jenkins wrote:
> On Fri, Jan 31, 2025 at 12:43:12AM +0000, Conor Dooley wrote:
> > On Thu, Jan 30, 2025 at 02:58:49PM -0800, Charlie Jenkins wrote:
> > > On Wed, Jan 29, 2025 at 04:19:58PM +0000, Conor Dooley wrote:
...
> > > > Why don't you use the same implementation as the !tools
> > > > copy of the header? (I'm not sure why they're different in the first
> > > > place).
> > > 
> > > It is different because the headers in tools are userspace so it doesn't
> > > make sense to have alternatives.
> > 
> > I assume that's an answer to the first part, and not the bit in
> > brackets since the "first place" difference is about using the .4byte
> > versus having an ifdef/else and you're talking about alternatives.
> > That looks to have been some sort of sync issue or oversight in
> > 6da111574baff, no?
> 
> Yeah it was a response to the first part.
> 
> As for the second part, yes it look it was a syncing issue.
>

I just forgot to update the tools copy at the time of 6da111574baff. We
should first sync it (but with s/RISCV_PAUSE/0x100000f/ to avoid the
need to include insn-def.h) before modifying it with this patch.

Thanks,
drew