From: Artur Weber <aweber.kernel@gmail.com>
To: Lee Jones <lee@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Florian Fainelli <florian.fainelli@broadcom.com>,
Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>
Cc: Stanislav Jakubek <stano.jakubek@gmail.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
~postmarketos/upstreaming@lists.sr.ht,
Artur Weber <aweber.kernel@gmail.com>
Subject: [PATCH v3 4/7] mfd: bcm590xx: Add compatible for BCM59054
Date: Fri, 31 Jan 2025 19:13:52 +0100 [thread overview]
Message-ID: <20250131-bcm59054-v3-4-bbac52a84787@gmail.com> (raw)
In-Reply-To: <20250131-bcm59054-v3-0-bbac52a84787@gmail.com>
The BCM59056 supported by the bcm590xx driver is similar to the
BCM59054 MFD. Add a compatible for it in the driver, in preparation
for extending support of this chip in the bcm590xx regulator driver.
Signed-off-by: Artur Weber <aweber.kernel@gmail.com>
---
Changes in v3:
- Fix compilation warning about device_type pointer cast type
- Name the device types enum and use it as the type in the MFD struct
---
drivers/mfd/bcm590xx.c | 6 +++++-
include/linux/mfd/bcm590xx.h | 7 +++++++
2 files changed, 12 insertions(+), 1 deletion(-)
diff --git a/drivers/mfd/bcm590xx.c b/drivers/mfd/bcm590xx.c
index 8b56786d85d0182acf91da203b5f943556c08422..23036157480e0116301bfa93932c92f5a80010ea 100644
--- a/drivers/mfd/bcm590xx.c
+++ b/drivers/mfd/bcm590xx.c
@@ -50,6 +50,9 @@ static int bcm590xx_i2c_probe(struct i2c_client *i2c_pri)
bcm590xx->dev = &i2c_pri->dev;
bcm590xx->i2c_pri = i2c_pri;
+ bcm590xx->device_type = \
+ (uintptr_t) of_device_get_match_data(bcm590xx->dev);
+
bcm590xx->regmap_pri = devm_regmap_init_i2c(i2c_pri,
&bcm590xx_regmap_config_pri);
if (IS_ERR(bcm590xx->regmap_pri)) {
@@ -91,7 +94,8 @@ static int bcm590xx_i2c_probe(struct i2c_client *i2c_pri)
}
static const struct of_device_id bcm590xx_of_match[] = {
- { .compatible = "brcm,bcm59056" },
+ { .compatible = "brcm,bcm59054", .data = (void *)BCM59054_TYPE },
+ { .compatible = "brcm,bcm59056", .data = (void *)BCM59056_TYPE },
{ }
};
MODULE_DEVICE_TABLE(of, bcm590xx_of_match);
diff --git a/include/linux/mfd/bcm590xx.h b/include/linux/mfd/bcm590xx.h
index 6b8791da6119b22514447bf1572238b71c8b0e97..b76fb57bf0dd17d51580e93db58ece4a4d6dc5e4 100644
--- a/include/linux/mfd/bcm590xx.h
+++ b/include/linux/mfd/bcm590xx.h
@@ -13,12 +13,19 @@
#include <linux/i2c.h>
#include <linux/regmap.h>
+/* device types */
+enum bcm590xx_device_type {
+ BCM59054_TYPE,
+ BCM59056_TYPE,
+};
+
/* max register address */
#define BCM590XX_MAX_REGISTER_PRI 0xe7
#define BCM590XX_MAX_REGISTER_SEC 0xf0
struct bcm590xx {
struct device *dev;
+ enum bcm590xx_device_type device_type;
struct i2c_client *i2c_pri;
struct i2c_client *i2c_sec;
struct regmap *regmap_pri;
--
2.48.1
next prev parent reply other threads:[~2025-01-31 18:14 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-31 18:13 [PATCH v3 0/7] mfd: bcm590xx: Add support for BCM59054 Artur Weber
2025-01-31 18:13 ` [PATCH v3 1/7] dt-bindings: mfd: brcm,bcm59056: Convert to YAML Artur Weber
2025-02-02 9:56 ` Stanislav Jakubek
2025-02-02 13:27 ` Krzysztof Kozlowski
2025-02-04 18:33 ` Artur Weber
2025-01-31 18:13 ` [PATCH v3 2/7] dt-bindings: mfd: brcm,bcm59056: Add compatible for BCM59054 Artur Weber
2025-01-31 19:41 ` Rob Herring (Arm)
2025-02-02 10:08 ` Stanislav Jakubek
2025-02-02 13:24 ` Krzysztof Kozlowski
2025-02-05 17:58 ` Artur Weber
2025-01-31 18:13 ` [PATCH v3 3/7] ARM: dts: Drop DTS for BCM59056 PMIC Artur Weber
2025-01-31 18:13 ` Artur Weber [this message]
2025-02-07 8:48 ` [PATCH v3 4/7] mfd: bcm590xx: Add compatible for BCM59054 Lee Jones
2025-02-07 13:06 ` Artur Weber
2025-02-10 16:33 ` Lee Jones
2025-01-31 18:13 ` [PATCH v3 5/7] regulator: bcm590xx: Store regulator descriptions in table Artur Weber
2025-01-31 18:13 ` [PATCH v3 6/7] regulator: bcm590xx: Rename BCM59056-specific data as such Artur Weber
2025-01-31 18:13 ` [PATCH v3 7/7] regulator: bcm590xx: Add support for BCM59054 regulators Artur Weber
2025-02-05 19:12 ` Stanislav Jakubek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250131-bcm59054-v3-4-bbac52a84787@gmail.com \
--to=aweber.kernel@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=florian.fainelli@broadcom.com \
--cc=krzk+dt@kernel.org \
--cc=lee@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjui@broadcom.com \
--cc=robh@kernel.org \
--cc=sbranden@broadcom.com \
--cc=stano.jakubek@gmail.com \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox