public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "José Expósito" <jose.exposito89@gmail.com>
To: louis.chauvet@bootlin.com
Cc: airlied@gmail.com, arthurgrillo@riseup.net, corbet@lwn.net,
	dri-devel@lists.freedesktop.org, hamohammed.sa@gmail.com,
	jeremie.dautheribes@bootlin.com, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org, maarten.lankhorst@linux.intel.com,
	mairacanal@riseup.net, marcheu@google.com, melissa.srw@gmail.com,
	miquel.raynal@bootlin.com, mripard@kernel.org,
	nicolejadeyee@google.com, pekka.paalanen@haloniitty.fi,
	rdunlap@infradead.org, rodrigosiqueiramelo@gmail.com,
	seanpaul@google.com, simona.vetter@ffwll.ch, simona@ffwll.ch,
	thomas.petazzoni@bootlin.com, tzimmermann@suse.de
Subject: [PATCH v16 3/7] drm/vkms: Drop YUV formats TODO
Date: Fri, 31 Jan 2025 09:40:45 +0100	[thread overview]
Message-ID: <20250131084045.2874-1-jose.exposito89@gmail.com> (raw)
In-Reply-To: <20250121-yuv-v16-3-a61f95a99432@bootlin.com>

Hi Louis,

Thanks a lot for the patches.

I'm not well versed in YUV color formats, so I did my best reading the kernel
documentation before reviewing this series... But I'll most likely ask some
basic/dump questions.

> From: Arthur Grillo <arthurgrillo@riseup.net>
> 
> VKMS has support for YUV formats now. Remove the task from the TODO
> list.
> 
> Signed-off-by: Arthur Grillo <arthurgrillo@riseup.net>
> Signed-off-by: Louis Chauvet <louis.chauvet@bootlin.com>
> ---
>  Documentation/gpu/vkms.rst | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/Documentation/gpu/vkms.rst b/Documentation/gpu/vkms.rst
> index ba04ac7c2167a9d484c54c69a09a2fb8f2d9c0aa..13b866c3617cd44043406252d3caa912c931772f 100644
> --- a/Documentation/gpu/vkms.rst
> +++ b/Documentation/gpu/vkms.rst
> @@ -122,8 +122,7 @@ There's lots of plane features we could add support for:
>  
>  - Scaling.
>  
> -- Additional buffer formats, especially YUV formats for video like NV12.
> -  Low/high bpp RGB formats would also be interesting.
> +- Additional buffer formats. Low/high bpp RGB formats would be interesting.

I see that you implemented support for 6 DRM_FORMAT_NV* formats, but
DRM_FORMAT_NV15, DRM_FORMAT_NV20 and DRM_FORMAT_NV30 are not implemented.

The same applies to DRM_FORMAT_Y210 or DRM_FORMAT_YUV410 among others.

Could it be useful to implement all of them in the future? If so, should we add
it to the ToDo list?
It might be a great task to get started in kernel development, as there are
already similar examples and tests.

>  
>  - Async updates (currently only possible on cursor plane using the legacy
>    cursor api).
> 

  reply	other threads:[~2025-01-31  8:40 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-21 10:48 [PATCH v16 0/7] drm/vkms: Add support for YUV and DRM_FORMAT_R* Louis Chauvet
2025-01-21 10:48 ` [PATCH v16 1/7] drm/vkms: Add YUV support Louis Chauvet
2025-01-21 10:48 ` [PATCH v16 2/7] drm/vkms: Add range and encoding properties to the plane Louis Chauvet
2025-01-21 10:48 ` [PATCH v16 3/7] drm/vkms: Drop YUV formats TODO Louis Chauvet
2025-01-31  8:40   ` José Expósito [this message]
2025-01-31 13:02     ` Louis Chauvet
2025-01-31 16:53       ` José Expósito
2025-01-21 10:48 ` [PATCH v16 4/7] drm: Export symbols to use in tests Louis Chauvet
2025-01-31  8:40   ` José Expósito
2025-01-21 10:48 ` [PATCH v16 5/7] drm/vkms: Create KUnit tests for YUV conversions Louis Chauvet
2025-01-26 17:06   ` Maxime Ripard
2025-01-27 10:48     ` Louis Chauvet
2025-02-05  8:55       ` Maxime Ripard
2025-02-05 15:32         ` Louis Chauvet
2025-02-19 10:15           ` Maxime Ripard
2025-02-19 13:35             ` Louis Chauvet
2025-03-07 10:20               ` Maxime Ripard
2025-03-07 14:50                 ` Louis Chauvet
2025-03-10  9:12                   ` Pekka Paalanen
2025-03-13 14:29                     ` Maxime Ripard
2025-01-31  8:41   ` José Expósito
2025-01-31 13:02     ` Louis Chauvet
2025-01-31 16:57       ` José Expósito
2025-01-21 10:48 ` [PATCH v16 6/7] drm/vkms: Add how to run the Kunit tests Louis Chauvet
2025-01-31  8:41   ` José Expósito
2025-01-21 10:48 ` [PATCH v16 7/7] drm/vkms: Add support for DRM_FORMAT_R* Louis Chauvet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250131084045.2874-1-jose.exposito89@gmail.com \
    --to=jose.exposito89@gmail.com \
    --cc=airlied@gmail.com \
    --cc=arthurgrillo@riseup.net \
    --cc=corbet@lwn.net \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=hamohammed.sa@gmail.com \
    --cc=jeremie.dautheribes@bootlin.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=louis.chauvet@bootlin.com \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mairacanal@riseup.net \
    --cc=marcheu@google.com \
    --cc=melissa.srw@gmail.com \
    --cc=miquel.raynal@bootlin.com \
    --cc=mripard@kernel.org \
    --cc=nicolejadeyee@google.com \
    --cc=pekka.paalanen@haloniitty.fi \
    --cc=rdunlap@infradead.org \
    --cc=rodrigosiqueiramelo@gmail.com \
    --cc=seanpaul@google.com \
    --cc=simona.vetter@ffwll.ch \
    --cc=simona@ffwll.ch \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox